[Due for Payment - Dec 1st] [$250] Reports - App not respond when tap on filter option after delete the saved search

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.2.59-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-1996/folder/13176922/41237510/1016711299
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: iphone 16 pro/18.7.1
App Component: Search

Action Performed:

1. Open app login with account have some reports
2. Tap on Reports tab
3. Tap on "Filters" button
4. Select any option (can select option with no result)
5. Tap Save
6. Tap Save search
7. Tap on the menu next to search box
8. Scroll down to Saved section
9. Tap on three dot of the saved search and delete
10. Tap on arrow of Type: Expense, Status, Date, From

Expected Result:

App should respond when tap on Type: Expense, Status, Date, From

Actual Result:

App doesn't respond when tap on Type: Expense, Status, Date, From

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021990590934016391139
• Upwork Job ID: 1990590934016391139
• Last Price Increase: 2025-11-18

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Filter popover doesn't show after deleting saved search.

What is the root cause of that problem?

This happens after #71048 which removes the code willAlertModalBecomeVisible(false) from hideModal and moves it to onModalWillHide.

App/src/components/Modal/BaseModal.tsx

Lines 108 to 115 in 5ddaed5

	const hideModal = useCallback(
	(callHideCallback = true) => {
	shouldCallHideModalOnUnmount.current = false;
	if (areAllModalsHidden()) {
	if (shouldSetModalVisibility && !Navigation.isTopmostRouteModalScreen()) {
	setModalVisibility(false);
	}
	}

When we delete the selected saved search, the delete confirm modal is immediately unmounted, leaving no time for the onModalWillHide to be called.

App/src/hooks/useDeleteSavedSearch.tsx

Lines 23 to 32 in 5ddaed5

	setIsDeleteModalVisible(false);
	if (hashToDelete === currentSearchHash) {
	clearAdvancedFilters();
	Navigation.navigate(
	ROUTES.SEARCH_ROOT.getRoute({
	query: buildCannedSearchQuery(),
	}),
	);
	}

We already have a logic to call hideModal when the modal is unmounted before calling the onModalHide, but since we don't call willAlertModalBecomeVisible(false) inside hideModal anymore, willAlertModalBecomeVisible value stays true.

App/src/components/Modal/BaseModal.tsx

Lines 148 to 154 in 5ddaed5

	useEffect(
	() => () => {
	if (!shouldCallHideModalOnUnmount.current) {
	return;
	}
	hideModalCallbackRef.current?.(true);
	},

App/src/components/Search/FilterDropdowns/DropdownButton.tsx

Lines 62 to 71 in 5ddaed5

	const [willAlertModalBecomeVisible] = useOnyx(ONYXKEYS.MODAL, {selector: willAlertModalBecomeVisibleSelector, canBeMissing: true});
	/**
	* Toggle the overlay between open & closed
	*/
	const toggleOverlay = useCallback(() => {
	setIsOverlayVisible((previousValue) => {
	if (!previousValue && willAlertModalBecomeVisible) {
	return false;
	}

What changes do you think we should make in order to solve the problem?

I can't really understand the root cause from the selected proposal of #70209 (comment), but we can add willAlertModalBecomeVisible(false) back to hideModal.

[trjExpensify]

I can repro this. 👍

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021990590934016391139

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

[dukenv0307]

@bernhardoj Did you test this issue, after bringing back willAlertModalBecomeVisible?