[Awaiting Payment 2025-12-01][$250] Workflow - After Advanced Approvals upgrade, user isn’t redirected to the next page

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.49-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: Exp
Email or phone of affected tester (no customers): applausetester+bm955@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Web, mweb, android
App Component: Workspace Settings

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Create a workspace
3. Go to Workflow
4. Click on the default workflow
5. Click on Additional Approver
6. Upgrade the Workspace

Expected Result:

After upgrading Advanced Approvals, the app should redirect to the next page, which is the List of Members page.

Actual Result:

After the Advanced Approvals upgrade, the app redirects back to the previous page, which is inconsistent with other areas of the app

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug7000824_1762883185947.bandicam_2025-11-11_20-42-15-007.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021988639771933815484
• Upwork Job ID: 1988639771933815484
• Last Price Increase: 2025-11-12

Issue Owner

Current Issue Owner: @NicMendonca

[melvin-bot]

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lorretheboy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After the Advanced Approvals upgrade, the app redirects back to the previous page, which is inconsistent with other areas of the app

What is the root cause of that problem?

addAdditionalApprover callback was passing Navigation.getActiveRoute() as the backTo parameter when navigating to the upgrade page. This meant it was passing the current route (the workflow editor page) instead of the next page in the flow.

App/src/pages/workspace/workflows/approvals/ApprovalWorkflowEditor.tsx

Line 118 in fa5e06d

Navigation.navigate(ROUTES.WORKSPACE_UPGRADE.getRoute(policyID, CONST.UPGRADE_FEATURE_INTRO_MAPPING.approvals.alias, Navigation.getActiveRoute()));

What changes do you think we should make in order to solve the problem?

Updated the addAdditionalApprover callback to pass the approver selection route (ROUTES.WORKSPACE_WORKFLOWS_APPROVALS_APPROVER.getRoute(policyID, approverCount)) as the backTo parameter, consistent with how other upgrade flows work in the codebase.

            Navigation.navigate(
                ROUTES.WORKSPACE_UPGRADE.getRoute(
                    policyID,
                    CONST.UPGRADE_FEATURE_INTRO_MAPPING.approvals.alias,
                    ROUTES.WORKSPACE_WORKFLOWS_APPROVALS_APPROVER.getRoute(policyID, approverCount),
                ),
            );

App/src/pages/workspace/workflows/approvals/ApprovalWorkflowEditor.tsx

Line 118 in fa5e06d

Navigation.navigate(ROUTES.WORKSPACE_UPGRADE.getRoute(policyID, CONST.UPGRADE_FEATURE_INTRO_MAPPING.approvals.alias, Navigation.getActiveRoute()));

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[paulnjs]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After upgrading to Advanced Approvals, the app redirects to the previous screen using the backTo parameter, which results in inconsistent navigation behavior compared to other parts of the app.

What is the root cause of that problem?

• The navigation relies solely on the backTo parameter:

App/src/pages/workspace/upgrade/WorkspaceUpgradePage.tsx

Lines 78 to 84 in 82a45ab

	case CONST.UPGRADE_FEATURE_INTRO_MAPPING.approvals.id:
	case CONST.UPGRADE_FEATURE_INTRO_MAPPING.multiApprovalLevels.id:
	Navigation.goBack();
	if (route.params.backTo) {
	Navigation.navigate(route.params.backTo);
	}
	return;

• However, the backTo value is being passed incorrectly from:

App/src/pages/workspace/workflows/approvals/ApprovalWorkflowEditor.tsx

Lines 116 to 122 in 82a45ab

	const addAdditionalApprover = useCallback(() => {
	if (!isControlPolicy(policy) && approverCount > 0) {
	Navigation.navigate(ROUTES.WORKSPACE_UPGRADE.getRoute(policyID, CONST.UPGRADE_FEATURE_INTRO_MAPPING.approvals.alias, Navigation.getActiveRoute()));
	return;
	}
	Navigation.navigate(ROUTES.WORKSPACE_WORKFLOWS_APPROVALS_APPROVER.getRoute(policyID, approverCount, ROUTES.WORKSPACE_WORKFLOWS_APPROVALS_NEW.getRoute(policyID)));
	}, [approverCount, policy, policyID]);

This leads to an unintended redirect after the upgrade flow completes.

What changes do you think we should make in order to solve the problem?

• Instead of relying on the backTo parameter, we should update the logic in:

App/src/pages/workspace/upgrade/WorkspaceUpgradePage.tsx

Line 78 in 82a45ab

case CONST.UPGRADE_FEATURE_INTRO_MAPPING.approvals.id:

to explicitly navigate to the appropriate screen for approvals:

case CONST.UPGRADE_FEATURE_INTRO_MAPPING.approvals.id:
    Navigation.goBack();
    Navigation.navigate(
        ROUTES.WORKSPACE_WORKFLOWS_APPROVALS_APPROVER.getRoute(
            policyID,
            approverCount,
            ROUTES.WORKSPACE_WORKFLOWS_APPROVALS_NEW.getRoute(policyID)
        )
    );
    return;

• To support this, define the approver count using Onyx:

const [approvalWorkflow] = useOnyx(ONYXKEYS.APPROVAL_WORKFLOW, {canBeMissing: true});
const approverCount = approvalWorkflow?.approvers.length;

• Note: The backTo param is no longer recommended for use in new navigation flows. Additionally, we currently reuse the same CONST.UPGRADE_FEATURE_INTRO_MAPPING.approvals value across multiple actions. This introduces ambiguity and limits our ability to handle post-upgrade routing on a per-action basis.

  To improve clarity and maintainability, we should define separate entries in CONST.UPGRADE_FEATURE_INTRO_MAPPING for each upgrade-triggering action. This ensures that each action maps cleanly to its own post-upgrade behavior without conflict.

What alternative solutions did you explore? (Optional)

• N/A

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021988639771933815484

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)

[NicMendonca]

@Pujan92 can you please review the above proposals? Thanks!

[Pujan92]

@lorretheboy's proposal looks correct, we are not adding a new backTo param but just correcting the existing one. So I think that's fine.

🎀👀🎀 C+ reviewed