[Due for payment 2025-12-17] [$250] Account - Avatar doesn't load when login from public room as existing user

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.2.43-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/folder/13176964/test-cases/41237765
Email or phone of affected tester (no customers): expensify416+da2@gmail.com
Issue reported by: Applause Internal Team
Device used: MacOS Chrome
App Component: Other

Action Performed:

1. Sign out if you are signed in
2. Open a public room: https://staging.new.expensify.com/r/2091104345528462
3. Sign in with existing user
4. Click on account setting icon

Expected Result:

Avatar and user name should load on account page

Actual Result:

Avatar and user name doesn't load on account page

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6993530_1762249024319.Screen_Recording_2025-11-04_at_12.29.42_in_the_afternoon.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021985740254199706090
• Upwork Job ID: 1985740254199706090
• Last Price Increase: 2025-11-04

[melvin-bot]

Triggered auto assignment to @heyjennahay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lorretheboy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Account - Avatar doesn't load when login from public room as existing user

What is the root cause of that problem?

The issue is that useOnyx is not detecting that the selector function has changed, or it's not re-running the selector when it changes

When the selector function changes (because the dependencies changed), useOnyx should re-run the new selector against the current data. But it's not doing that - it's still using the old selector result!

App/src/components/CurrentUserPersonalDetailsProvider.tsx

Lines 20 to 29 in 3485da8

	const userAccountSelector = useCallback(
	(allPersonalDetails: OnyxEntry<PersonalDetailsList>): CurrentUserPersonalDetails => {
	const personalDetailsForUser = (allPersonalDetails?.[userAccountID] ?? {}) as CurrentUserPersonalDetails;
	personalDetailsForUser.accountID = userAccountID;
	personalDetailsForUser.email = session?.email;
	return personalDetailsForUser;
	},
	[session?.email, userAccountID],
	);
	const [currentUserPersonalDetails = defaultCurrentUserPersonalDetails] = useOnyx(ONYXKEYS.PERSONAL_DETAILS_LIST, {selector: userAccountSelector, canBeMissing: true});

What changes do you think we should make in order to solve the problem?

Need to add deps to useOnyx

[userAccountID, session?.email] // Or just userAccountSelector

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021985740254199706090

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

[shubham1206agra]

@lorretheboy's proposal looks good.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @lakchote, see https://stackoverflow.com/c/expensify/questions/7972 for more details.