[$250] Error displayed and manual IOU expense fails to submit after split scan flow

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.2.40-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/folder/13177049/test-cases/49475610
Email or phone of affected tester (no customers): na
Issue reported by: Applause Internal Team
Device used: Web, ios, os
App Component: Money Requests

Action Performed:

1. Open the link www.staging.new.expensify.com
2. Logged in with new user (not yet to validate)
3. Click FAB>> Start Chat >> Enter New Account (account never has with expensify)
4. Click Split >> Select Scan >> Select Image (not a receipt)
5. Click back >> Select another valid receipt to scan
6. Click Create Expense and wait for the scan is completed
7. Click FAB >> Tap "Create" >> Select "Manual"
8. Enter any number in BNP >> Tap Next and select new not-validated account
9. On the confirm details, Click "Create XX Expense"

Expected Result:

If the system allowing user to submitted the expense, it should be no error displayed in IOU.

Actual Result:

An error message appears: "Unexpected error submitting this expense. Please try again later."
The IOU is created but appears hidden in the LHN, making it inaccessible or invisible to the user.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021985193994834967160
• Upwork Job ID: 1985193994834967160
• Last Price Increase: 2025-11-10

Issue Owner

Current Issue Owner: @sobitneupane

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Error when creating expense after doing a split scan bill.

What is the root cause of that problem?

The important steps here is that we need to open the split bill preview page, which is not mentioned in the OP steps. Here is the simplified steps:

1. Create a split scan expense in a DM chat
2. Press the split bill preview to open the details page
3. Close the split bill details page
4. Press the + create button > Create expense
5. Enter any amount and go Next
6. Create the expense
7. Error!

Notice that in the confirm page, there are multiple expenses, indicated by the arrows. When we create the split scan with multiple expenses, multiple transaction drafts are created.

App/src/libs/actions/IOU.ts

Lines 12408 to 12417 in f52b05d

	function setMultipleMoneyRequestParticipantsFromReport(transactionIDs: string[], reportValue: OnyxEntry<OnyxTypes.Report>) {
	const participants = getMoneyRequestParticipantsFromReport(reportValue);
	const updatedTransactions: Record<`${typeof ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${string}`, NullishDeep<OnyxTypes.Transaction>> = {};
	transactionIDs.forEach((transactionID) => {
	updatedTransactions[`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${transactionID}`] = {
	participants,
	participantsAutoAssigned: true,
	};
	});
	return Onyx.mergeCollection(ONYXKEYS.COLLECTION.TRANSACTION_DRAFT, updatedTransactions);

When we create the expenses, we don't clear the drafts (we clear it when doing a manual request). But this is not the real problem because when we start the IOU flow, we already clears the draft.

App/src/libs/actions/IOU.ts

Lines 1033 to 1034 in f52b05d

	// We remove draft transactions created during multi scanning if there are some
	removeDraftTransactions(true);

However, there are some drafts that can't be cleared because the transactionID is missing.

App/src/libs/actions/TransactionEdit.ts

Line 109 in f52b05d

acc[`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${item.transactionID}`] = null;

It only has taxAmount and taxCode. This draft transaction that only has taxAmount and taxCode is added when we open the split bill details page. Why?

Split bill details page uses MoneyRequestConfirmationList and in MoneyRequestConfirmationList, we have a logic to automatically update the tax code/amount when the default changes.

App/src/components/MoneyRequestConfirmationList.tsx

Lines 343 to 348 in f52b05d

	useEffect(() => {
	if (!transactionID) {
	return;
	}
	setMoneyRequestTaxRate(transactionID, defaultTaxCode);
	}, [defaultTaxCode, transactionID]);

App/src/components/MoneyRequestConfirmationList.tsx

Lines 488 to 493 in f52b05d

	useEffect(() => {
	if (!transactionID) {
	return;
	}
	setMoneyRequestTaxAmount(transactionID, taxAmountInSmallestCurrencyUnits);
	}, [transactionID, taxAmountInSmallestCurrencyUnits]);

This causes an extra transactionsDraft_ entry with only taxCode and taxAmount to be added to the Onyx. But, when editing the split bills, the data will be saved to splitTransactionsDraft_.

This happens after both of this PR:
#73361 and #73391

Previously, we check shouldShowTax (which is false) before updating the tax amount and rate.

What changes do you think we should make in order to solve the problem?

Add back the shouldShowTax condition to skip the logic if it false.

OR

MoneyRequestConfirmationList is being used in IOURequestStepConfirmation and SplitBillDetailsPage. It's clear that the logic to automatically update the tax to transactionsDraft_ data is only useful for IOURequestStepConfirmation (when creating the IOU flow), so it make sense if we move the logic up to IOURequestStepConfirmation.

useEffect(() => {
    if (!transaction?.transactionID) {
        return;
    }
    setMoneyRequestTaxRate(transaction?.transactionID, defaultTaxCode);
}, [defaultTaxCode, transaction?.transactionID]);

// Calculate and set tax amount in transaction draft
const taxableAmount = isDistanceRequest ? DistanceRequestUtils.getTaxableAmount(policy, customUnitRateID, distance) : (transaction?.amount ?? 0);
const taxPercentage = getTaxValue(policy, transaction, transaction?.taxCode ?? defaultTaxCode) ?? '';
const taxAmount = calculateTaxAmount(taxPercentage, taxableAmount, transaction?.currency ?? CONST.CURRENCY.USD);
const taxAmountInSmallestCurrencyUnits = convertToBackendAmount(Number.parseFloat(taxAmount.toString()));
useEffect(() => {
    if (!transaction?.transactionID) {
        return;
    }
    setMoneyRequestTaxAmount(transaction?.transactionID, taxAmountInSmallestCurrencyUnits);
}, [transaction?.transactionID, taxAmountInSmallestCurrencyUnits]);

What alternative solutions did you explore? (Optional)

1. Add a prop from SplitBillDetailsPage to ignore the update tax logic.
2. Currently, we get the transaction drafts collection values. Instead, we can get the whole collection, and then later get the transaction ID from the member key (transactionsDraft_1.split('_').pop())

App/src/libs/actions/TransactionEdit.ts

Lines 102 to 109 in f52b05d

	function removeDraftTransactions(shouldExcludeInitialTransaction = false, allTransactionDrafts?: OnyxCollection<Transaction>) {
	const draftTransactions = getDraftTransactions(allTransactionDrafts);
	const draftTransactionsSet = draftTransactions.reduce(
	(acc, item) => {
	if (shouldExcludeInitialTransaction && item.transactionID === CONST.IOU.OPTIMISTIC_TRANSACTION_ID) {
	return acc;
	}
	acc[`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${item.transactionID}`] = null;

Additional fix (not necessarry in this case):
Clear the draft transactions after split bill, just like request money, but not sure why we only do it when shouldHandleNavigation is true.

App/src/libs/actions/IOU.ts

Lines 6072 to 6074 in f52b05d

	if (shouldHandleNavigation) {
	// eslint-disable-next-line @typescript-eslint/no-deprecated
	InteractionManager.runAfterInteractions(() => removeDraftTransactions());

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021985193994834967160

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸