[Due for payment 2025-11-13] [$250] Workspace- Hmm... it's not here messages is not showing at the center when deleting workspace

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.2.39-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-1527/folder/13177019/41237785/976868394
Email or phone of affected tester (no customers): shussain@applausemail.com
Issue reported by: Applause Internal Team
Device used: Web, Desktop
App Component: Workspace Settings

Action Performed:

1. Log in as the admin of a workspace on both the main and secondary testing devices.
2. On the main device, navigate to More features.
3. On the secondary device, go to Workspace settings.
4. From the secondary device, delete the workspace.
5. Return to the main device and observe the screen.

Expected Result:

The “Hmm... it’s not here” message should be properly centered on the screen when the workspace is deleted from a secondary device.

Actual Result:

After deleting the workspace from the secondary device, the “Hmm... it’s not here” message appears but is not displayed at the center of the screen on the main device.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021983657926069125684
• Upwork Job ID: 1983657926069125684
• Last Price Increase: 2025-10-29
• Automatic offers:
• FitseTLT | Contributor | 109315037

Issue Owner

Current Issue Owner: @eh2077

[melvin-bot]

Triggered auto assignment to @heyjennahay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After deleting the workspace from the secondary device, the “Hmm... it’s not here” message appears but is not displayed at the center of the screen on the main device.

What is the root cause of that problem?

We're showing 2 not found pages after deleting policy, one in Workspace Initial page, and one in Workspace More Features page:

App/src/pages/workspace/WorkspaceInitialPage.tsx

Lines 471 to 479 in 4e8e2b8

	<FullPageNotFoundView
	onBackButtonPress={Navigation.dismissModal}
	onLinkPress={Navigation.goBackToHome}
	shouldShow={shouldShowNotFoundPage}
	subtitleKey={shouldShowPolicy ? 'workspace.common.notAuthorized' : undefined}
	addBottomSafeAreaPadding
	shouldForceFullScreen
	shouldDisplaySearchRouter
	>

App/src/pages/workspace/WorkspaceMoreFeaturesPage.tsx

Lines 477 to 480 in 4e8e2b8

	<AccessOrNotFoundWrapper
	accessVariants={[CONST.POLICY.ACCESS_VARIANTS.ADMIN, CONST.POLICY.ACCESS_VARIANTS.PAID]}
	policyID={route.params.policyID}
	>

isPolicyAccessible is false here, because deleted policy still have some props left:

App/src/libs/PolicyUtils.ts

Lines 1416 to 1420 in 4e8e2b8

	function isPolicyAccessible(policy: OnyxEntry<Policy>): boolean {
	return (
	!isEmptyObject(policy) && (Object.keys(policy).length !== 1 || isEmptyObject(policy.errors)) && !!policy?.id && policy?.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE
	);
	}

Deleted policy props:

So in here we only display the not found page it central pane instead of full screen:

App/src/pages/workspace/AccessOrNotFoundWrapper.tsx

Lines 112 to 116 in 4e8e2b8

	const shouldShowFullScreenFallback = !isFeatureEnabled || isPolicyNotAccessible;
	const {shouldUseNarrowLayout} = useResponsiveLayout();
	return (
	<NotFoundPage
	shouldForceFullScreen={shouldShowFullScreenFallback}

So the upper not found page is placed to the right and overlaps the under not found page.

What changes do you think we should make in order to solve the problem?

We should modify and use shouldShowPolicy here instead, same as WorkspaceInitialPage:

App/src/pages/workspace/AccessOrNotFoundWrapper.tsx

Line 190 in 4e8e2b8

const isPolicyNotAccessible = !isPolicyAccessible(policy);

AccessOrNotFoundWrapper is also used for personal policy in some pages, so we should modify as below:

App/src/libs/PolicyUtils.ts

Lines 281 to 289 in 4e8e2b8

	function shouldShowPolicy(policy: OnyxEntry<Policy>, shouldShowPendingDeletePolicy: boolean, currentUserLogin: string | undefined): boolean {
	return (
	!!policy?.isJoinRequestPending ||
	(!!policy &&
	policy?.type !== CONST.POLICY.TYPE.PERSONAL &&
	(shouldShowPendingDeletePolicy || policy?.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE || Object.keys(policy.errors ?? {}).length > 0) &&
	!!getPolicyRole(policy, currentUserLogin))
	);
	}

function shouldShowPolicy(policy: OnyxEntry<Policy>, shouldShowPendingDeletePolicy: boolean, currentUserLogin: string | undefined, shouldShowPersonalPolicy = false): boolean {
    return (
        !!policy?.isJoinRequestPending ||
        (!!policy &&
            (policy?.type !== CONST.POLICY.TYPE.PERSONAL || shouldShowPersonalPolicy) &&
            (shouldShowPendingDeletePolicy || policy?.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE || Object.keys(policy.errors ?? {}).length > 0) &&
            !!getPolicyRole(policy, currentUserLogin))
    );
}

Then use in AccessOrNotFoundWrapper like below:

const [currentUserLogin] = useOnyx(ONYXKEYS.SESSION, {selector: emailSelector, canBeMissing: false});
const isPolicyNotAccessible = !shouldShowPolicy(policy, true, currentUserLogin, true);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace- Hmm... it's not here messages is not showing at the center when deleting workspace

What is the root cause of that problem?

We show not found when a policy is not accessible

App/src/pages/workspace/AccessOrNotFoundWrapper.tsx

Line 190 in 4e8e2b8

const isPolicyNotAccessible = !isPolicyAccessible(policy);

and for deleted workspace it used to work because the policy data from onyx used to be cleared but now it has got some basic data as id and name so isPolicyAccessible returns true even for deleted. Not found page is getting shown now by isPageAccessible logic

App/src/pages/workspace/AccessOrNotFoundWrapper.tsx

Lines 182 to 188 in a60b73b

	const isPageAccessible = accessVariants.reduce((acc, variant) => {
	const accessFunction = ACCESS_VARIANTS[variant];
	if (variant === CONST.IOU.ACCESS_VARIANTS.CREATE) {
	return acc && accessFunction(policy, login, report, allPolicies ?? null, iouType, isReportArchived, isRestrictedToPreferredPolicy);
	}
	return acc && accessFunction(policy, login, report, allPolicies ?? null, iouType, isReportArchived);
	}, true);

App/src/pages/workspace/AccessOrNotFoundWrapper.tsx

Line 191 in a60b73b

const shouldShowNotFoundPage = (!isMoneyRequest && !isFromGlobalCreate && isPolicyNotAccessible) || !isPageAccessible || shouldBeBlocked;

but we have got a logic here to show the not found page full screen for the case of isPolicyNotAccessible here

App/src/pages/workspace/AccessOrNotFoundWrapper.tsx

Line 112 in a60b73b

const shouldShowFullScreenFallback = !isFeatureEnabled || isPolicyNotAccessible;

but it will be false because isPolicyNotAccessible is false

What changes do you think we should make in order to solve the problem?

We need to improve isPolicyAccessible logic by including a check for role. Policy data can be available in onyx for different reasons like when a user is invited to a policy chat etc. but AccessOrNotFoundWrapper wants to show not found when a user is not a member of a workspace (either archived or removed from membership) so we should add a check to isPolicyAccessible

App/src/libs/PolicyUtils.ts

Lines 1416 to 1420 in 4e8e2b8

	function isPolicyAccessible(policy: OnyxEntry<Policy>): boolean {
	return (
	!isEmptyObject(policy) && (Object.keys(policy).length !== 1 || isEmptyObject(policy.errors)) && !!policy?.id && policy?.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE
	);
	}

         &&   !!getPolicyRole(policy, currentUserLogin))

NOte: shouldShowPolicy is not an approriate function here as it is used to determine a workspace to show in the list so it can for instance return true for isJoinRequestPending policy.

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021983657926069125684

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eh2077 (External)

[eh2077]

Thanks for your proposals!

Both proposals are similar except for the nuance between methods shouldShowPolicy and isPolicyAccessible in the solution.

I think we should go with @FitseTLT 's proposal because it makes more sense to me to fix the issue by improve method isPolicyAccessible.

🎀👀🎀 C+ reviewed