[Due for payment 2025-11-26] [$250] Out-of-pocket spend & Company spend appear when non-reimbursable expense is split offline

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.38-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-1469/folder/13176791/41237176/972471062
Email or phone of affected tester (no customers): sdoisdjnoisjio@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Money Requests

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Create a non-reimbursable expense.
4. Open the expense thread.
5. Go offline.
6. Click More > Split.
7. Click Save.

Expected Result:

Out-of-pocket spend and Company spend will not appear because the report contains only non-reimbursable splits.

Actual Result:

Out-of-pocket spend and Company spend appear when non-reimbursable expense is split offline.
Both spends disappear after returning online.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6984992_1761577510710.Screen_Recording_2025-10-27_at_23.03.45.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021982917667716998576
• Upwork Job ID: 1982917667716998576
• Last Price Increase: 2025-11-03
• Automatic offers:
• situchan | Contributor | 109399403

Issue Owner

Current Issue Owner: @marcaaron

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[paulnjs]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Out-of-pocket spend and Company spend appear when non-reimbursable expense is split offline.
Both spends disappear after returning online.

What is the root cause of that problem?

Each time we call getMoneyRequestInformation to update the split expense, nonReimbursableTotal is updated unexpectedly here, which causes the nonReimbursableTotal to be changed incorrectly after splitting.

It should be the same as the previous if the split total is the same/the split transaction is reimbursable. But in this case, nonReimbursableTotal is double.

App/src/libs/actions/IOU.ts

Lines 13632 to 13645 in f5fd802

	const {transactionThreadReportID, createdReportActionIDForThread, onyxData, iouAction} = getMoneyRequestInformation({
	participantParams,
	parentChatReport,
	policyParams,
	transactionParams,
	moneyRequestReportID: splitExpense?.reportID,
	existingTransaction,
	existingTransactionID,
	newReportTotal: reportTotal - changesInReportTotal,
	isSplitExpense: true,
	currentReportActionID: currentReportAction?.reportActionID,
	});
	let updateMoneyRequestParamsOnyxData: OnyxData = {};

App/src/libs/actions/IOU.ts

Lines 3493 to 3498 in f5fd802

	if (!reimbursable) {
	iouReport.nonReimbursableTotal = (iouReport.nonReimbursableTotal ?? 0) - amount;
	}
	}
	if (typeof iouReport.unheldTotal === 'number') {
	// Use newReportTotal in scenarios where the total is based on more than just the current transaction amount, and we need to override it manually

What changes do you think we should make in order to solve the problem?

We can follow the same approach of newReportTotal to create newNonReimbursableTotal parameter

and update iouReport.nonReimbursableTotal to newNonReimbursableTotal if the transaction is non-reimbursable here

if (!reimbursable) {
                    if (newNonReimbursableTotal !== undefined) {
                        iouReport.nonReimbursableTotal = newNonReimbursableTotal;
                    } else {
                        iouReport.nonReimbursableTotal = (iouReport.nonReimbursableTotal ?? 0) - amount;
                    }
                }

App/src/libs/actions/IOU.ts

Lines 3493 to 3498 in f5fd802

	if (!reimbursable) {
	iouReport.nonReimbursableTotal = (iouReport.nonReimbursableTotal ?? 0) - amount;
	}
	}
	if (typeof iouReport.unheldTotal === 'number') {
	// Use newReportTotal in scenarios where the total is based on more than just the current transaction amount, and we need to override it manually

Then we can pass newNonReimbursableTotal param as (transactionReport?.nonReimbursableTotal ?? 0) - changesInReportTotal here

newNonReimbursableTotal: (transactionReport?.nonReimbursableTotal ?? 0) - changesInReportTotal,

App/src/libs/actions/IOU.ts

Lines 3493 to 3498 in f5fd802

	if (!reimbursable) {
	iouReport.nonReimbursableTotal = (iouReport.nonReimbursableTotal ?? 0) - amount;
	}
	}
	if (typeof iouReport.unheldTotal === 'number') {
	// Use newReportTotal in scenarios where the total is based on more than just the current transaction amount, and we need to override it manually

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Update the updateSplitTransactions to verify nonReimbursableTotal is updated correctly when splitting non-reimbursable transaction

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021982917667716998576

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

[melvin-bot]

@getusha Whoops! This issue is 2 days overdue. Let's get this updated quick!

[getusha]

@isabelastisser could you reassign this please, thank you!