[Due for payment 2025-12-03] [$250] Strict policy rules - "Waiting for you to fix the issues" is shown on paid report with violation

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.37-8
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #72663
Email or phone of affected tester (no customers): applausetester+231030kh@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• Be on private domain with "Strictly enforce expense workspace rules" enabled on OD.
• Submission frequency is set to Instantly in Workflows settings.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Create an expense without category (to have an expense with violation).
4. Open the expense report.
5. Click Approve.
6. Click Mark as paid.

Expected Result:

Next action message will not show "Waiting for you to fix the issues. Your admins have restricted submission of expenses with violations." when the report is paid.

Actual Result:

Next action message still shows "Waiting for you to fix the issues. Your admins have restricted submission of expenses with violations." when the report is paid.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6983240_1761310875086.3.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021985756984863931442
• Upwork Job ID: 1985756984863931442
• Last Price Increase: 2025-11-04
• Automatic offers:
• ChavdaSachin | Contributor | 109476634

Issue Owner

Current Issue Owner: @dylanexpensify

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[hasib711]

how to test local environment?

[ChavdaSachin]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Strict policy rules - "Waiting for you to fix the issues" is shown on paid report with violation

What is the root cause of that problem?

While building optimistic next step here, we do not check for report status and hence the wrong optimistic step description is generated.

App/src/components/MoneyReportHeader.tsx

Lines 405 to 406 in bceff96

	if (shouldBlockSubmit && isReportOwner(moneyRequestReport)) {
	optimisticNextStep = buildOptimisticNextStepForStrictPolicyRuleViolations();

What changes do you think we should make in order to solve the problem?

Add a status check here, so "Waiting for you to fix the issues. Your admins have restricted submission of expenses with violations." is only generate when report is not yet submitted.

    if (shouldBlockSubmit && isReportOwner(moneyRequestReport) && isOpenExpenseReport(moneyRequestReport)) {

App/src/components/MoneyReportHeader.tsx

Line 405 in bceff96

if (shouldBlockSubmit && isReportOwner(moneyRequestReport)) {

optionally we could check and make sure isInstantSubmitEnabled(policy) = false before generating this optimistic next step.

What alternative solutions did you explore? (Optional)

Alternatively we could prevent auto submission when strict rules are enabled and expense has any violations.
Needs BE support.

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[ChavdaSachin]

@hasib711 please checkout these contributing guidelines

[melvin-bot]

@dylanexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@dylanexpensify Still overdue 6 days?! Let's take care of this!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021985756984863931442