[Due for payment 2025-11-13] [$250] Chat - Setup specialist have fallback avatar on Admin page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.34-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://test-management.browserstack.com/projects/2219752/test-runs/TR-1372/folder/13176924/41237589/962796371
Email or phone of affected tester (no customers): gocemate+b2154574@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Login with new gmail account without +
2. Choose Manage my team expenses > select 1-10 employees > complete onboarding flow by selecting accounting
3. Navigate to "Admins room" and check Setup specialist avatar

Expected Result:

There should be regular avatar

Actual Result:

Setup specialist have fallback avatar on Admin page

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6979869_1760973358632.Recording__6240.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021980323981955749492
• Upwork Job ID: 1980323981955749492
• Last Price Increase: 2025-11-03
• Automatic offers:
• abzokhattab | Contributor | 109345212

Issue Owner

Current Issue Owner: @lschurr

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[samranahm]

Not a bug. It update when BE complete onboarding, and choose and a specialist.

[abzokhattab]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Setup specialist displays a fallback avatar icon instead of a regular default avatar in the #admins room.

What is the root cause of that problem?

• When a workspace is created during onboarding, the Setup Specialist is added to the #admins room as a participant
• If the policy doesn't have an assigned guide yet, the code creates an optimistic personal detail entry for the Setup Specialist
• This optimistic entry only includes login, displayName, and isOptimisticPersonalDetail fields here
• The avatar field is missing, which causes the Avatar component to fall back to the FallbackAvatar icon instead of showing a proper default avatar

What changes do you think we should make in order to solve the problem?

In ReportUtils.ts, add the avatar field to the optimistic personal detail:

Onyx.merge(ONYXKEYS.PERSONAL_DETAILS_LIST, {
    [assignedGuideAccountID]: {
        isOptimisticPersonalDetail: !assignedGuidePersonalDetail,
        login: assignedGuideEmail,
        displayName: assignedGuideEmail,
        avatar: getDefaultAvatarURL(assignedGuideAccountID), // Add this line
    },
});

This ensures the behavior is consistent accross the app, we have this case in the deleteAvatar where we add the avatar to the optimistic values until the backend data is return
POC

Screen.Recording.2025-10-20.at.17.31.13.mov

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

NA

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021980323981955749492

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)

[dmkt9]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Setup specialist have fallback avatar on Admin page

What is the root cause of that problem?

The setup specialist is just an optimistic personal detail created when the onboarding complete API is called:

So it falls back to FallbackAvatar because there is no avatar property.

App/src/components/ReportActionAvatars/useReportActionAvatars.ts

Lines 237 to 238 in 09a7472

	const userFallbackAvatar: IconType = {
	source: avatar ?? FallbackAvatar,

What changes do you think we should make in order to solve the problem?

Since the optimistic personal detail is only temporary and will be removed after the API call completes, when isOptimisticPersonalDetail === true, we should use the avatar URL instead of falling back to FallbackAvatar.

App/src/components/ReportActionAvatars/useReportActionAvatars.ts

Line 198 in 09a7472

const {avatar, fallbackIcon, login} = personalDetails?.[delegatePersonalDetails ? delegatePersonalDetails.accountID : accountID] ?? {};

const {avatar, fallbackIcon, login, isOptimisticPersonalDetail} = personalDetails?.[delegatePersonalDetails ? delegatePersonalDetails.accountID : accountID] ?? {};

App/src/components/ReportActionAvatars/useReportActionAvatars.ts

Lines 237 to 238 in 09a7472

	const userFallbackAvatar: IconType = {
	source: avatar ?? FallbackAvatar,

const userFallbackAvatar: IconType = {
    source: avatar ?? (isOptimisticPersonalDetail ? getDefaultAvatarURL(accountID) : FallbackAvatar),

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸