[HOLD for payment 2022-03-02] Saving without editing the multiline comments edit box shows [Comment Deleted] in LHN - Reported by @sobitneupane

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open app
2. Send multiline message
3. Click on edit
4. Save without editing

Expected Result:

[Comment Deleted] should display only if user deletes the comment

Actual Result:

Saving without editing the multiline comments edit box shows [Comment Deleted] in LHN

Workaround:

unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.30-0
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @sobitneupane
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1641828479234000

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @madmax330 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[sobitneupane]

Proposing as I reported this issue.
Reason:
In editReportComment in Report.js, we are using ExpensiMark as the parser and ExpensiMark uses <br> as the line break. But the originalReportAction.message[0].html has <br /> as the line break. So, two messages when compared appear different and it is considered to be edited. So, though the message is not edited, the message is indicated as an edited message. Problem begins here.

App/src/libs/actions/Report.js

Line 1387 in 74cf52f

const parser = new ExpensiMark();

Solution:

1. In ExpensiMark, use <br /> as the line break instead of <br>. This solves the root cause of the problem.
2. If it is not feasible to make above change, updateReportActionMessage is called. So, Adding following lines of code in updateReportActionMessage() in Report.js can also solve the issue

       if(message.isEdited === false){
           return;
       }
   

App/src/libs/actions/Report.js

Lines 542 to 561 in 74cf52f

	function updateReportActionMessage(reportID, sequenceNumber, message) {
	const actionToMerge = {};
	actionToMerge[sequenceNumber] = {message: [message]};
	Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${reportID}`, actionToMerge).then(() => {
	// Don't do anything for messages that aren't deleted.
	if (message.html) {
	return;
	}
	// If the message is deleted, update the last read in case the deleted message is being counted in the unreadActionCount
	setLocalLastRead(reportID, lastReadSequenceNumbers[reportID]);
	});
	// If this is the most recent message, update the lastMessageText in the report object as well
	if (sequenceNumber === reportMaxSequenceNumbers[reportID]) {
	Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${reportID}`, {
	lastMessageText: message.text || `[${Localize.translateLocal('common.deletedCommentMessage')}]`,
	});
	}
	}

[MelvinBot]

Triggered auto assignment to @puneetlath (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[madmax330]

Was OOO this can be an external issue