If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Open app
- Navigate to any chat
- Send messages
- Hit Edit to make any changes
Expected Result:
Composer should hide when we edit any message.
Actual Result:
Composer still displayed on the screen above keyboard
Context
Based on this line of code
|
toggleReportActionComposeView(false); |
Composer should hide when we edit any message. I remember it used to happen.
In this commit
243819e.
we only enabled it for Mobile. But we missed to update the
|
toggleReportActionComposeView(false); |
to pass props.isSmallScreen as second param.
It was updated here
|
toggleReportActionComposeView(true, this.props.isSmallScreenWidth); |
. But missed on the above line.
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platform:
Where is this issue occurring?
Version Number:
Reproducible in staging?:
Reproducible in production?:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @parasharrajat
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1641824507232400
View all open jobs on GitHub
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
Composer should hide when we edit any message.
Actual Result:
Composer still displayed on the screen above keyboard
Context
Based on this line of code
App/src/pages/home/report/ReportActionItemMessageEdit.js
Line 159 in bc24202
Composer should hide when we edit any message. I remember it used to happen.
In this commit 243819e.
we only enabled it for Mobile. But we missed to update the
App/src/pages/home/report/ReportActionItemMessageEdit.js
Line 159 in bc24202
It was updated here
App/src/pages/home/report/ReportActionItemMessageEdit.js
Line 99 in bc24202
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platform:
Where is this issue occurring?
Version Number:
Reproducible in staging?:
Reproducible in production?:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @parasharrajat
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1641824507232400
View all open jobs on GitHub