[Due for payment 2025-11-21] [Due for payment 2025-11-12] [$250] Expense - Submit button is the primary button and not Mark as resolved after rejecting expense

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.29-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #62787
Email or phone of affected tester (no customers): sjndoijsojiodnjiosji@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Money Requests

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Create an expense in workspace chat.
4. Open the expense report.
5. Click Submit.
6. Click More > Reject.
7. Enter reason and click Reject expense.
   → After rejecting expense, Submit is shown instead of Mark as resolved.
8. Create one more expense in the same report.
9. Open the rejected expense.
   → Mark as resolved is only shown in the transaction thread and not in the single expense report view.

Expected Result:

In Step 7, after rejecting expense, Mark as resolved button will be shown as the primary button in the single expense report view.

Actual Result:

In Step 7, after rejecting expense, Submit button is shown as the primary button instead of Mark as resolved in the single expense report view.
In Step 9, Mark as resolved is only shown in the transaction thread.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021978290512474314478
• Upwork Job ID: 1978290512474314478
• Last Price Increase: 2025-10-15
• Automatic offers:
• daledah | Contributor | 109157653

Issue Owner

Current Issue Owner: @VictoriaExpensify

[melvin-bot]

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In Step 7, after rejecting expense, Submit button is shown as the primary button instead of Mark as resolved in the single expense report view.
In Step 9, Mark as resolved is only shown in the transaction thread.

What is the root cause of that problem?

We defined the CONST.REPORT.TRANSACTION_PRIMARY_ACTIONS.MARK_AS_RESOLVED in MoneyReportHeader here

App/src/components/MoneyReportHeader.tsx

Lines 838 to 849 in f05f7b7

	[CONST.REPORT.TRANSACTION_PRIMARY_ACTIONS.MARK_AS_RESOLVED]: (
	<Button
	success
	onPress={() => {
	if (!transaction?.transactionID) {
	return;
	}
	markRejectViolationAsResolved(transaction?.transactionID, transactionThreadReport?.reportID);
	}}
	text={translate('iou.reject.markAsResolved')}
	/>
	),

But we don't return the type of CONST.REPORT.TRANSACTION_PRIMARY_ACTIONS.MARK_AS_RESOLVED action in getReportPrimaryAction function

App/src/libs/ReportPrimaryActionUtils.ts

Lines 323 to 337 in f05f7b7

	function getReportPrimaryAction(params: GetReportPrimaryActionParams): ValueOf<typeof CONST.REPORT.PRIMARY_ACTIONS> | '' {
	const {
	currentUserEmail,
	report,
	reportTransactions,
	violations,
	policy,
	reportNameValuePairs,
	reportActions,
	isChatReportArchived,
	chatReport,
	invoiceReceiverPolicy,
	isPaidAnimationRunning,
	isSubmittingAnimationRunning,
	} = params;

What changes do you think we should make in order to solve the problem?

1. We should add MARK_AS_RESOLVED to the PRIMARY_ACTIONS in const.ts

        PRIMARY_ACTIONS: {
            SUBMIT: 'submit',
            ...
            MARK_AS_CASH: 'markAsCash',
            MARK_AS_RESOLVED: 'markAsResolved',
        },

2. We can reuse isMarkAsResolvedAction logic like we did with MoneyRequestHeader component to add the logic in getReportPrimaryAction function

    if(isExpenseReportUtils(report) && reportTransactions.length === 1 && isMarkAsResolvedAction(report, getTransactionViolations(reportTransactions.at(0), violations), policy)) {
        return CONST.REPORT.PRIMARY_ACTIONS.MARK_AS_RESOLVED;
    }

App/src/libs/ReportPrimaryActionUtils.ts

Line 354 in f05f7b7

Note: Because we only Mark as resolved for the one transaction in MoneyReportHeader here so we will only show Mark as resolved if the report has only 1 transaction

If we want to show Mark as resolved button with multiple transactions, we can do the same with the remove hold logic here.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Update the test of getReportPrimaryAction function to cover this case

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[VictoriaExpensify]

Yeah I think it would be good to get this fixed and make it clear that something needs to be resolved.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021978290512474314478

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ZhenjaHorbach (External)

[ZhenjaHorbach]

Thanks for your proposal
I will check tomorrow!

[ZhenjaHorbach]

This proposal looks good to me

🎀 👀 🎀 С+