[Due for payment 2025-11-12] [$250] Invoice - Delete option is missing in More menu of an unpaid invoice report

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.28-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-1221/folder/13176671/41237464/941908676
Email or phone of affected tester (no customers): sdjoisjdnoidjoisjdi@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• Invoice is enabled.

1. Go to staging.new.expensify.com
2. Go to workspace settings > More features.
3. Disable Workflows.
4. Open FAB > Send invoice.
5. Send an invoice to any user.
6. Go to Reports.
7. Search with type:invoice.
8. Select the invoice via checkbox > Click dropdown button.
   → Delete option is present on Reports > Invoices.
9. Go to Inbox.
10. Open the invoice thread.
11. Click More.

Expected Result:

Delete option will be present in More menu

Actual Result:

Delete option is missing in More menu.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021978623247997152112
• Upwork Job ID: 1978623247997152112
• Last Price Increase: 2025-10-16
• Automatic offers:
• etCoderDysto | Contributor | 109177600

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[etCoderDysto]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Invoice - Delete option is missing in More menu when Workflows are disabled

What is the root cause of that problem?

We have policy?.approvalMode !== CONST.POLICY.APPROVAL_MODE.OPTIONAL check here. And when we disable workflow, policy?.approvalMode will be optional

App/src/libs/ReportUtils.ts

Lines 2683 to 2684 in f50b779

	if (isInvoiceReport(report)) {
	return report?.ownerAccountID === currentUserAccountID && isReportOpenOrProcessing && policy?.approvalMode !== CONST.POLICY.APPROVAL_MODE.OPTIONAL;

What changes do you think we should make in order to solve the problem?

We should remove the check

if (isInvoiceReport(report)) {
        return report?.ownerAccountID === currentUserAccountID && isReportOpenOrProcessing;

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We can write a test that asserts that canDeleteMoneyRequestReport will return true for invoice report when workflow is disabled

What alternative solutions did you explore? (Optional)

[Eskalifer1]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Invoice - Delete option is missing in More menu when Workflows are disabled

What is the root cause of that problem?

We dont check here if workflows are enabled

App/src/libs/ReportUtils.ts

Lines 2683 to 2685 in f50b779

	if (isInvoiceReport(report)) {
	return report?.ownerAccountID === currentUserAccountID && isReportOpenOrProcessing && policy?.approvalMode !== CONST.POLICY.APPROVAL_MODE.OPTIONAL;
	}

What changes do you think we should make in order to solve the problem?

We should check if workflows are enabled And if they are enabled, only then check approvalMode. Here is an example of the code::

if (isInvoiceReport(report)) {
        return report?.ownerAccountID === currentUserAccountID && isReportOpenOrProcessing &&  (!policy?.areWorkflowsEnabled || policy?.approvalMode !== CONST.POLICY.APPROVAL_MODE.OPTIONAL);
    }

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[trjExpensify]

Mhm... @cristipaval @joekaufmanexpensify for a hipcheck...

1. The invoice was submitted (thus processing) and waiting on someone to pay it
2. Disabling workflows doesn't mean anything for the Invoice report.
3. Thus, they should be able to delete a submitted invoice report?
4. Seems like they can from the Reports page, but not from the More menu on the invoice report itself?

[cristipaval]

• Invoices should be completely decoupled from Workflows.
• Deleting an invoice should behave similarly to deleting an expense report.

[trjExpensify]

Cool, thanks!