[Discussion] No mutually exclusive boolean props

[roryabraham]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Coming from here, I'm proposing a new code style guideline: "No mutually exclusive boolean props".

What I mean by this is that we should ban the use of boolean props that are meant to be mutually exclusive: i.e: instead of having small, medium, large each be their own separate boolean props, create a single size prop that's PropTypes.oneOf(['small', 'medium', 'large']).

This prevents unpredictable behavior in the event that two mutually exclusive boolean props are passed as the same time.

View all open jobs on GitHub

[marcaaron]

This sounds good to me if the alternative is having both isSmall and isLarge as separate props.

Are there other examples?

[roryabraham]

None that come to mind

[parasharrajat]

We can take the Button component as an example. It has three Boolean props small, 'medium' and 'large'.

What Rory suggested above is to create a single prop size which will accept above mentioned values are strings.

[roryabraham]

What Rory suggested above is to create a single prop size which will accept above mentioned values are strings.

Yeah, this makes more sense to me. Since I couldn't find other examples for the time being, I would be fine doing nothing here 🤷 It's not really a problem we should prioritize atm.

[tgolen]

I like the idea, and as long as we can find an example of it in our code, then let's do it!

[melvin-bot]

@roryabraham, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.