[Awaiting Checklist] [Due for payment 2025-11-18] [$250] Workspace-Able to enable 'Required' in offline without error in Tag settings

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.2.27-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: #71183
Email or phone of affected tester (no customers): ndk.2303+new237@gmail.com
Issue reported by: Applause Internal Team
Device used: Windows 11 Home/Chrome
App Component: Workspace Settings

Action Performed:

Prerequisites:

• User with workspace
• Workspace with the Tags extension enabled

1. Open https://staging.new.expensify.com/
2. Go to the "Workspaces settings"
3. Click on "Tag"
4. Click "More" button and select "Settings"
5. Set "Members must tag all expenses" to disabled.
6. Change path in url from /workspaces/{{WORKSPACE_ID}}/tags/settings to /workspaces/{{WORKSPACE_ID}}/tag-list/0
7. Go offline
8. Enable "Required"
9. Go online

Expected Result:

At step 8, It should cause an error. Click 'x' can dismiss the error
At step 9, error should be still displayed (if not dismiss yet).

Actual Result:

At step 8, user is able to enable 'Required' without error
At step 9, 'Required' is disabled, eror briefly shown

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6968194_1759907512098.User_can_enable_Required_in_offline.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021977803846845267235
• Upwork Job ID: 1977803846845267235
• Last Price Increase: 2025-10-20

Issue Owner

Current Issue Owner: @garrettmknight

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

At step 8, user is able to enable 'Required' without error
At step 9, 'Required' is disabled, eror briefly shown

What is the root cause of that problem?

The tag list still appears because all tags are in a tag section with a custom name Tag.

App/src/pages/workspace/tags/WorkspaceViewTagsPage.tsx

Line 61 in 94b7ea2

function WorkspaceViewTagsPage({route}: WorkspaceViewTagsProps) {

What changes do you think we should make in order to solve the problem?

This page should only appear if the tag is a multilevel tag list. We should show the not found page if the policy tags is not multilevel tag

shouldBeBlocked={!isMultiLevelTagsPolicyUtils(policyTags)}

App/src/pages/workspace/tags/WorkspaceViewTagsPage.tsx

Line 332 in 94b7ea2

<AccessOrNotFoundWrapper

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When enabling the tag list item required while offline and then going online, the error is gone.

What is the root cause of that problem?

When we reconnect, the OPEN_POLICY_TAGS_PAGE is called, which returns an onyx method of set that overwrites the existing error.

App/src/pages/workspace/tags/WorkspaceTagsPage.tsx

Line 127 in 94b7ea2

const {isOffline} = useNetwork({onReconnect: fetchTags});

What changes do you think we should make in order to solve the problem?

We have a few options.

1. Fix this on the BE so it uses MERGE instead of SET.

2. Disable the Required toggle when it's not a multi-level tag
   or show the lock icon, just like when "Members must tag all expenses" is enabled.

[melvin-bot]

@garrettmknight Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021977803846845267235