[Due for payment 2025-11-14] [$250] There's no sound effect in sending message with 2 attachments

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.23-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: #71128
Email or phone of affected tester (no customers): mysticque00@gmail.com
Issue reported by: Applause Internal Team
Device used: iPhone 13 / iOS 18.5
App Component: Other

Action Performed:

1. Navigate to a DM.
2. Type a message, e.g., "hello" and Attach two attachments to the message
3. Send the message with the two attachment

Expected Result:

there's 1 sound effect being played for sending the message (since we're only sending 1 message even though it has 2 attachments).

Actual Result:

no sound effect played in iOS app, Android app, mWeb-Android

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

iOS: App

Bug6966006_1759734956671.sound_effect1.mp4

Android: mWeb

Bug6966006_1759735991767.sound_effect_mweb_android.mp4

Android: App

Bug6966006_1759736249836.sound_effect_android_app.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021975109852277366006
• Upwork Job ID: 1975109852277366006
• Last Price Increase: 2025-10-27
• Automatic offers:
• situchan | Contributor | 109281072

Issue Owner

Current Issue Owner: @jliexpensify

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[jliexpensify]

@Expensify/design does this warrant fixing? It seems like a minor nitpick so deferring to you for thoughts!

[shawnborton]

Hmm I would expect a sound effect to be played each time a message is sent, so this seems like a bug.

[jliexpensify]

@shawnborton ugggh, totally missed the Actual Result. Yes, this is a bug 😄

I misread this as 2 attachments = 2 sound effects.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021975109852277366006

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[daledah]

🚨 Edited by proposal-police: This proposal was edited at 2025-10-06 08:18:55 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

no sound effect played in iOS app, Android app, mWeb-Android

What is the root cause of that problem?

We are only calling handlePlaySound once here

App/src/libs/actions/Report.ts

Lines 875 to 881 in b1a83aa

	// Remaining: attachment-only actions (no text duplication)
	for (let i = 1; i < attachments?.length; i += 1) {
	addActions(reportID, notifyReportID, timezone, '', attachments?.at(i));
	}
	// Play sound once
	handlePlaySound();

What changes do you think we should make in order to solve the problem?

We should move handlePlaySound function to the for loop

    // Multiple attachments - first: combine text + first attachment as a single action
    addActions(reportID, notifyReportID, timezone, text, attachments?.at(0));
    handlePlaySound();

    // Remaining: attachment-only actions (no text duplication)
    for (let i = 1; i < attachments?.length; i += 1) {
        addActions(reportID, notifyReportID, timezone, '', attachments?.at(i));
        handlePlaySound();
    }

App/src/libs/actions/Report.ts

Lines 875 to 881 in b1a83aa

	// Remaining: attachment-only actions (no text duplication)
	for (let i = 1; i < attachments?.length; i += 1) {
	addActions(reportID, notifyReportID, timezone, '', attachments?.at(i));
	}
	// Play sound once
	handlePlaySound();

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We should update this test for this case

App/tests/actions/ReportTest.ts

Line 1283 in b1a83aa

it('should create attachment only action & not play sound when adding attachment without a comment & shouldPlaySound not passed', async () => {

What alternative solutions did you explore? (Optional)

or we can move the handling of sending multiple attachments to the ReportActionCompose.tsx component and pass empty text for the following attachments

        if (Array.isArray(attachmentFileRef.current)) {
            // Handle multiple files
            attachmentFileRef.current.forEach((file, index) => {
                addAttachmentReportActions(reportID, file, personalDetail.timezone ?? CONST.DEFAULT_TIME_ZONE, index === 0 ? newCommentTrimmed : '', true);
            });
        } 

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.