[$250] Edit comment is not focused when editing a message with emoji

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.2.22-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exporatory
Email or phone of affected tester (no customers): testpayment935@gmail.com
Issue reported by: Applause Internal Team
Device used: mWeb
App Component: Chat Report View

Action Performed:

1. Navigate to staging.new.expensify.com
2. Go to any chat
3. Send a message only containing emojis
4. Edit comment

Expected Result:

The edit box is focused when editing a message

Actual Result:

The edit box is not focused

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

11.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021973943174730472694
• Upwork Job ID: 1973943174730472694
• Last Price Increase: 2025-10-24

Issue Owner

Current Issue Owner: @shubham1206agra

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[thelullabyy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The edit box is not focused

What is the root cause of that problem?

On Android after select edit comment, the modal disappear and trigger focus to the input.

App/src/pages/home/report/PureReportActionItem.tsx

Line 568 in 009a76b

focusComposerWithDelay(composerTextInputRef.current)(true);

However, when trigger focusComposerWithDelay the animation of the modal still in progress lead to ComposerFocusManager.isReadyToFocus() return false and the logic to focus input will not be executed

App/src/libs/focusComposerWithDelay/index.ts

Line 31 in 009a76b

Promise.all([ComposerFocusManager.isReadyToFocus(), isWindowReadyToFocus()]).then(() => {

What changes do you think we should make in order to solve the problem?

Old logic checked promiseMap and returned Promise.resolve() immediately when there were no promises, while promiseMap could be cleared early (due to setReadyToFocus) before the modal actually finished closing.

App/src/libs/ComposerFocusManager.ts

Lines 216 to 219 in 009a76b

	if (!promise) {
	return Promise.resolve();
	}
	return promise.ready;

Update to this logic, add a check for activeModals to ensure it only resolves when the modal has truly finished closing completely

    if (activeModals.length === 0) {
        return Promise.resolve();
    }

    if (!promise) {
        console.log('[ComposerFocus] No promise, creating new one');
        resetReadyToFocus(key);
        return promiseMap.get(key)!.ready;
    }

    return promise.ready;

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[jliexpensify]

I can't repro this on Staging Android, or on the Android app.

@thelullabyy @jponikarchuk can you please check on the latest versions and share a new video?

[thelullabyy]

@jliexpensify I'm still able to reproduce it. Not just for the emoji message

Screen.Recording.2025-10-03.at.09.40.57.mov

[jliexpensify]

Oh, I misunderstood this one 🤦 I thought this was the issue:

Yeah i can reproduce then.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021973943174730472694

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)