[Due for payment 2025-10-21] [$250] Expense - Amount input page resets to 0.00 after returning from confirm page twice

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.16-0
Reproducible in staging?: Y
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: https://test-management.browserstack.com/projects/2219752/folder/13177049/test-cases/41237808
Email or phone of affected tester (no customers): jsoindjoijnd1oisios@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• Account does not have a workspace

1. Go to staging.new.expensify.com
2. Open FAB > Create expense > Manual
3. Enter amount > Next
4. Enter the email of a user that doesn't have an Expensify account yet and select them
5. On confirm page, click RHP back button
6. Click RHP back button again
7. Edit the amount (optional)
8. Click Next
9. Enter the same user email
10. On confirm page, click RHP back button
11. Click RHP back button again

Expected Result:

The amount on the input page will remain preserved

Actual Result:

The amount on the input page is reset to 0.00 after returning from confirm page twice

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6950906_1758392652303.Screen_Recording_2025-09-21_at_02.20.33.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021970227442867655345
• Upwork Job ID: 1970227442867655345
• Last Price Increase: 2025-10-06

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @bfitzexpensify

[melvin-bot]

Triggered auto assignment to @flaviadefaria (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @neil-marcellini (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[neil-marcellini]

Deploy Blocker Analysis

Staging Deploy: #70900

Top 3 Most Likely Causative PRs

1. PR #69380 - "fix:67907: autofocus inputs in PerDiem and Amount page" (Likelihood: 9/10)

Why this is likely the cause:

• Direct functional overlap: This PR specifically modified the Amount page behavior, which is exactly where the issue occurs
• Focus handling changes: The PR changed autofocus behavior for amount inputs, which could impact form state management
• iOS-specific fixes: The PR mentions "focus is lost on iOS" - navigation state issues could be related to focus/input state management
• Timing correlation: This PR modified the exact page experiencing the issue
• State persistence risk: Changes to input focus behavior often affect how form values are maintained during navigation

Connection to symptoms:
The reported issue involves the amount input resetting after navigation. If the autofocus implementation doesn't properly preserve the existing value when the component remounts or regains focus, it could cause the amount to reset to the default $0.00 value.

2. PR #70043 - "Remove Onyx.connect() for the key: ONYXKEYS.FORMS.WORKSPACE_REPORT_FIELDS_FORM_DRAFT in src/libs/actions/Policy/ReportField.ts" (Likelihood: 7/10)

Why this is likely the cause:

• State management changes: This PR modified Onyx form state management, specifically removing Onyx.connect() calls
• Form state implications: Changes to how form drafts are managed could affect expense form state persistence
• Navigation impact: Form draft state is crucial for maintaining values during navigation flows
• Onyx refactoring: The move away from Onyx.connect() to newer patterns could introduce subtle state management bugs

Connection to symptoms:
If the Onyx refactoring affected how expense form state is preserved during navigation, the amount field could lose its value when navigating back and forth, reverting to the default empty/0.00 state.

3. PR #70261 - "[No QA] Migrate static styles to use StyleSheet.create" (Likelihood: 6/10)

Why this is likely the cause:

• Architectural changes: This PR split styles into different categories (static, dynamic, nested)
• Component re-rendering: Changes to style definitions can trigger unexpected component re-renders
• State preservation impact: Component re-renders during navigation could cause form state to be lost
• Systematic scope: Being a broad architectural change, it could have unforeseen effects on form components

Connection to symptoms:
If the style refactoring caused the Amount input component to re-render differently during navigation, the form state might not be preserved properly. The component could be unmounting/remounting in ways that weren't happening before, causing the input value to reset.

Additional Observations

Common Patterns

1. State Management Focus: Multiple PRs in this release involve changes to state management (Onyx connections, form drafts)
2. Input/Form Changes: Several PRs modify input behavior and form handling
3. Navigation Context: The issue specifically involves navigation between pages, suggesting navigation-related state management problems

Risk Factors

• The issue affects the expense creation workflow, which is a critical user path
• Cross-platform impact suggests the issue is in shared JavaScript code rather than platform-specific implementations
• The "twice" requirement in reproduction suggests a specific state accumulation or cleanup issue

Investigation Recommendations

1. Immediate Focus: Investigate PR fix:67907: autofocus inputs in PerDiem and Amount page #69380 first, specifically looking at how the autofocus changes interact with form state during navigation
2. State Management Review: Examine how expense form state is persisted during navigation, particularly in the context of the Onyx changes in PR Remove Onyx.connect() for the key: ONYXKEYS.FORMS.WORKSPACE_REPORT_FIELDS_FORM_DRAFT in src/libs/actions/Policy/ReportField.ts #70043
3. Component Lifecycle: Check if the style changes in PR [No QA] Migrate static styles to use StyleSheet.create #70261 are causing unexpected component mount/unmount cycles
4. Navigation State: Review the navigation stack behavior when backing out of the confirm page multiple times

The most likely culprit is PR #69380 due to its direct modification of the Amount page and input focus behavior, which closely aligns with the reported symptoms.

[neil-marcellini]

I can reproduce on dev, but it looks like the user has to be someone you haven't chatted with before.

2025-09-22_12-06-05.mp4