[Due for payment 2025-10-15] [$250] Report - Incorrect workspace displayed when adding expense after changing report´s workspace

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.15-9
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://test-management.browserstack.com/projects/2219752/test-runs/TR-828/folder/13176670/41237098/899332206
Email or phone of affected tester (no customers): ibellicotest+1811@gmail.com
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 / Android 12 / Chrome ( mWeb / Hybrid app) - Windows 11 / Chrome
App Component: Money Requests

Action Performed:

Prerequisite: Account has at least two workspaces.

1. Open the Expensify app.
2. Open any workspace chat.
3. Create two manual expenses.
4. Open the report of the just created expenses.
5. Tap on "More" and select "Change Workspace"
6. Select any workspace to move the report to.
7. Once redirected to report again, tap on "Add Expense" > "Create Expense"
8. Enter any amount and tap on "Next"
9. Note that previous workspace is displayed on "To" field
10. Finish creation flow.
11. Return to chat,
12. Note that now, chat is empty, as the expenses were moved to a different workspace.
13. Return to "Inbox"
14. Note that GBR is still displayed on workspace chat, despite not having expenses in it anymore.
15. Note that no GBR is displayed on the workspace where the expenses were moved, despite having now expenses in it.

Expected Result:

After moving a report to a different workspace, and adding a new expense to it, the new workspace should be displayed on the "To" field during creation flow.
Also, GBR should not be displayed anymore on the first workspace, and it should appear on the workspace where the report was moved.

Actual Result:

After moving a report to a different workspace, and adding a new expense to it, the previous workspace appears on the "To" field during creation flow.
Also, after this action, GBR remains displayed on the first workspace, despite no longer having expenses in it, and the workspace where the report was moved, doesn´t display any GBR.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021970281886019808772
• Upwork Job ID: 1970281886019808772
• Last Price Increase: 2025-09-30

Issue Owner

Current Issue Owner: @alexpensify

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[abzokhattab]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When adding a new expense after changing a report's workspace, the "To" field incorrectly displays the previous workspace instead of the new workspace.

What is the root cause of that problem?

• The getMoneyRequestParticipantsFromReport function uses the chat report's policyID here instead of the main report's current policyID
• When a report is moved to a new workspace, the report's policyID is updated correctly, but the chat report retains the old policyID
• This causes transaction participants to be initialized with the old workspace information, making the "To" field show the wrong workspace

What changes do you think we should make in order to solve the problem?

• Update the getMoneyRequestParticipantsFromReport function to use report?.policyID instead of chatReport?.policyID for the sender workspace here :

                policyID: report?.policyID || chatReport?.policyID,

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

we should add a test case inside the IOUTest to test this scenario

What alternative solutions did you explore? (Optional)

NA

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After moving a report to a different workspace, and adding a new expense to it, the previous workspace appears on the "To" field during creation flow.
Also, after this action, GBR remains displayed on the first workspace, despite no longer having expenses in it, and the workspace where the report was moved, doesn´t display any GBR.

What is the root cause of that problem?

The issue was in the getMoneyRequestParticipantsFromReport function.
When a report is moved to a new workspace: we gets updated with new policyID and chatReportID pointing to the new workspace chat. However, the old workspace chat report still exists with the old policyID

Thus, the function was using chatReport?.reportID and chatReport?.policyID which referenced the old workspace data

App/src/libs/actions/IOU.ts

Line 10945 in 353237f

participants = [{accountID: 0, reportID: chatReport?.reportID, isPolicyExpenseChat: isPolicyExpenseChatReportUtil(chatReport), selected: true}];

What changes do you think we should make in order to solve the problem?

Update to use Expense Report's reportID for Policy Expense Chats

reportID: isPolicyExpenseChatReportUtil(chatReport) && isMoneyRequestReportReportUtils(report) ? report?.reportID : chatReport?.reportID

We can also add policyID as well with the same condition above

policyID: isPolicyExpenseChatReportUtil(chatReport) && isMoneyRequestReportReportUtils(report)
            ? report?.policyID
            : chatReport?.policyID

Optional: Can check and apply the same for invoice room if it has the same issue

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The previous workspace is shown as the participant in confirm page after changing workspace.

What is the root cause of that problem?

We get the chat report (as the participant) from the expense report chatReportID.

App/src/libs/actions/IOU.ts

Lines 10937 to 10939 in 79f111b

	function getMoneyRequestParticipantsFromReport(report: OnyxEntry<OnyxTypes.Report>): Participant[] {
	// If the report is iou or expense report, we should get the chat report to set participant for request money
	const chatReport = isMoneyRequestReportReportUtils(report) ? getReportOrDraftReport(report?.chatReportID) : report;

However, when we change the workspace, we don't change the expense report chatReportID, we only change the parentReportID.

App/src/libs/actions/Report.ts

Lines 5873 to 5882 in 79f111b

	optimisticData.push({
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.REPORT}${reportID}`,
	value: {parentReportActionID: optimisticReportPreviewAction.reportActionID, parentReportID: newPolicyExpenseChatReportID},
	});
	failureData.push({
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.REPORT}${reportID}`,
	value: {parentReportActionID: report.parentReportActionID, parentReportID: report.parentReportID},
	});

What changes do you think we should make in order to solve the problem?

We need to optimistically update the chatReportID when changing the workspace (and revert when fail).

value: {parentReportActionID: optimisticReportPreviewAction.reportActionID, parentReportID: newPolicyExpenseChatReportID, chatReportID: newPolicyExpenseChatReportID},

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We can test changeReportPolicy and assert that the expense report chatReportID is updated to the new workspace chat reportID.

What alternative solutions did you explore? (Optional)

Get the chat report from parentReportID.

App/src/libs/actions/IOU.ts

Line 10939 in 79f111b

const chatReport = isMoneyRequestReportReportUtils(report) ? getReportOrDraftReport(report?.chatReportID) : report;

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021970281886019808772

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)