[Due for payment 2025-10-13] [$250] Onboarding - Navigating back from the #admins chat redirects to the Workspaces page

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.3-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: #69620
Email or phone of affected tester (no customers): biruknew45ss@gmail.com
Issue reported by: Applause Internal Team
Device used: android
App Component: Other

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Signup with email that should not contain "+"
3. Choose Track and budget expenses
4. Create workspace and complete and onboarding flow
5. After completing the onboarding flow, you are automatically taken to the #admins room.
6. Click the back navigation from the #admins room.

Expected Result:

Clicking the back navigation should return to LHN

Actual Result:

Clicking the back navigation redirects to the Workspaces page

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021965449221653042953
• Upwork Job ID: 1965449221653042953
• Last Price Increase: 2025-09-09
• Automatic offers:
• gijoe0295 | Contributor | 108802625

Issue Owner

Current Issue Owner: @isabelastisser

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[gijoe0295]

🚨 Edited by proposal-police: This proposal was edited at 2025-09-10 06:08:31 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Navigating back from the #admins chat redirects to the Workspaces page

What is the root cause of that problem?

App/src/components/TestDrive/Modal/AdminTestDriveModal.tsx

Lines 25 to 39 in 1e4751d

	const skipTestDrive = () => {
	Log.hmmm('[AdminTestDriveModal] Skip test drive function called');
	Navigation.dismissModal();
	Log.hmmm('[AdminTestDriveModal] Running after interactions');
	InteractionManager.runAfterInteractions(() => {
	if (!isAdminRoom(onboardingReport)) {
	Log.hmmm('[AdminTestDriveModal] Not an admin room');
	return;
	}
	Log.hmmm('[AdminTestDriveModal] Navigating to report', {reportID: onboardingReport?.reportID});
	Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(onboardingReport?.reportID));
	});
	};

We're dismissing the modal before navigating to the admins room report. But there might be race condition (due to the indeterministic nature of InteractionManager.runAfterInteractions) that causes navigate to take place before the modal is completely dismissed. The log below clearly says that we're navigating before handling the dismiss modal action:

So the navigation state at this point is: ReportsSplitNavigator (LHN) > TestDriveModalNavigator > ReportsSplitNavigator (ReportScreen). The dismiss modal action is not handled until that time. Inside handleDismissModalAction we have a check for whether the last route is a modal, if it's not, we won't execute the dismissal:

App/src/libs/Navigation/AppNavigator/createRootStackNavigator/GetStateForActionHandlers.ts

Lines 150 to 152 in c45d1d3

	if (!lastRoute?.name || !MODAL_ROUTES_TO_DISMISS.includes(lastRoute?.name)) {
	Log.hmmm('[Navigation] dismissModal failed because there is no modal stack to dismiss');
	return null;

We can see that at this point the last route is the ReportsSplitNavigator which is not a modal so dismissal is not executed, and the eventual navigation state is: ReportsSplitNavigator (LHN) > TestDriveModalNavigator > ReportsSplitNavigator (ReportScreen).

So later when we navigate back from the admin room, the navigation state is ReportsSplitNavigator (LHN) > TestDriveModalNavigator, so we go back to the test drive modal navigator which now does not show because the modal visibility had been set to false. So it shows a random page which is the WorkspacesListPage. I'm not sure the exact reason why it's the WorkspacesListPage but not others.

What changes do you think we should make in order to solve the problem?

We should use dismissModalWithReport instead. This must be used for cases where we open the report after dismissing modal.

const skipTestDrive = () => {
    InteractionManager.runAfterInteractions(() => {
        if (!onboardingReport || !isAdminRoom(onboardingReport)) {
            Navigation.dismissModal();
            return;
        }

        Navigation.dismissModalWithReport({reportID: onboardingReport.reportID});
    });
};

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

None

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021965449221653042953

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (External)

[marufsharifi]

🚫 Duplicated proposal withdrawn by 🤖 ProposalPolice.

[github-actions]

⚠️ @marufsharifi Your proposal is a duplicate of an already existing proposal and has been automatically withdrawn to prevent spam. Please review the existing proposals before submitting a new one.

[marufsharifi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

The redirection to Workspaces_List occurs because the navigate call in skipTestDrive creates a duplicate ReportsSplitNavigator due to a timing issue with modal dismissal, resulting in an inconsistent navigation stack state. When goBack() is called, the stack unwinds through the invalid modal and initial navigator, and React Navigation’s fallback mechanism redirects to the preloaded Workspaces_List route, which is the last preloaded route as a safe default.

App/src/components/TestDrive/Modal/AdminTestDriveModal.tsx

Lines 26 to 38 in 712e38e

	Log.hmmm('[AdminTestDriveModal] Skip test drive function called');
	Navigation.dismissModal();
	Log.hmmm('[AdminTestDriveModal] Running after interactions');
	InteractionManager.runAfterInteractions(() => {
	if (!isAdminRoom(onboardingReport)) {
	Log.hmmm('[AdminTestDriveModal] Not an admin room');
	return;
	}
	Log.hmmm('[AdminTestDriveModal] Navigating to report', {reportID: onboardingReport?.reportID});
	Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(onboardingReport?.reportID));
	});

What changes do you think we should make in order to solve the problem?

Make sure the modal is fully dismissed before navigating to the admin report page. Replace InteractionManager.runAfterInteractions with Navigation.isNavigationReady() to ensure navigation happens at the right time.

App/src/components/TestDrive/Modal/AdminTestDriveModal.tsx

Lines 30 to 38 in 712e38e

	InteractionManager.runAfterInteractions(() => {
	if (!isAdminRoom(onboardingReport)) {
	Log.hmmm('[AdminTestDriveModal] Not an admin room');
	return;
	}
	Log.hmmm('[AdminTestDriveModal] Navigating to report', {reportID: onboardingReport?.reportID});
	Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(onboardingReport?.reportID));
	});

Update to

   Navigation.isNavigationReady().then(() => {
            if (!isAdminRoom(onboardingReport)) {
                Log.hmmm('[AdminTestDriveModal] Not an admin room');
                return;
            }

                        Log.hmmm('[AdminTestDriveModal] Navigating to report', {reportID: onboardingReport?.reportID});
            Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(onboardingReport?.reportID));
        });

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

As a workaround, use dismissModalWithReport, which leverages forceReplace to navigate to the report page.

App/src/libs/Navigation/Navigation.ts

Lines 559 to 572 in 712e38e

	const dismissModalWithReport = ({reportID, reportActionID, referrer, backTo}: ReportsSplitNavigatorParamList[typeof SCREENS.REPORT], ref = navigationRef) => {
	isNavigationReady().then(() => {
	const topmostReportID = getTopmostReportId();
	const areReportsIDsDefined = !!topmostReportID && !!reportID;
	const isReportsSplitTopmostFullScreen = ref.getRootState().routes.findLast((route) => isFullScreenName(route.name))?.name === NAVIGATORS.REPORTS_SPLIT_NAVIGATOR;
	if (topmostReportID === reportID && areReportsIDsDefined && isReportsSplitTopmostFullScreen) {
	dismissModal();
	return;
	}
	const reportRoute = ROUTES.REPORT_WITH_ID.getRoute(reportID, reportActionID, referrer, backTo);
	if (getIsNarrowLayout()) {
	navigate(reportRoute, {forceReplace: true});
	return;
	}