[Due for payment 2025-09-17] [$250] Distance - Waypoints are not cleared after relaunching app

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.0-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp https://test-management.browserstack.com/projects/2219752/test-runs/TR-515/folder/13176744/41237142/864761862
Email or phone of affected tester (no customers): sdhshssdjiosdndjs@gmail.com
Issue reported by: Applause Internal Team
Device used: Samsung Galaxy Z Fold 4 / Android 15
App Component: Money Requests

Action Performed:

1. Launch Expensify app.
2. Open FAB > Create expense > Distance.
3. Enter Start and Stop waypoints.
4. On waypoints page, kill the app.
5. Relaunch the app.
6. Open FAB > Create expense > Distance.

Expected Result:

Waypoint fields will be cleared after relaunching app.

Actual Result:

Waypoint fields are not cleared after relaunching app.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6929093_1756387784895.Screen_Recording_20250828_203101_Expensify.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021965100725678806793
• Upwork Job ID: 1965100725678806793
• Last Price Increase: 2025-09-08

Issue Owner

Current Issue Owner: @greg-schroeder

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The distance waypoints are not cleared when reopen it after closing the app.

What is the root cause of that problem?

When we press the create expense option, we call removeDraftTransactions to remove all the draft transactions.

App/src/libs/actions/IOU.ts

Lines 1020 to 1027 in 10f648b

	function clearMoneyRequest(transactionID: string, skipConfirmation = false) {
	removeDraftTransactions();
	Onyx.set(`${ONYXKEYS.COLLECTION.SKIP_CONFIRMATION}${transactionID}`, skipConfirmation);
	}
	function startMoneyRequest(iouType: ValueOf<typeof CONST.IOU.TYPE>, reportID: string, requestType?: IOURequestType, skipConfirmation = false, backToReport?: string) {
	Performance.markStart(CONST.TIMING.OPEN_CREATE_EXPENSE);
	clearMoneyRequest(CONST.IOU.OPTIMISTIC_TRANSACTION_ID, skipConfirmation);

It gets the list of draft transaction from the Onyx.connect

App/src/libs/actions/TransactionEdit.ts

Lines 100 to 113 in 10f648b

	function removeDraftTransactions(shouldExcludeInitialTransaction = false) {
	const draftTransactions = getDraftTransactions();
	const draftTransactionsSet = draftTransactions.reduce(
	(acc, item) => {
	if (shouldExcludeInitialTransaction && item.transactionID === CONST.IOU.OPTIMISTIC_TRANSACTION_ID) {
	return acc;
	}
	acc[`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${item.transactionID}`] = null;
	return acc;
	},
	{} as Record<string, null>,
	);
	return Onyx.multiSet(draftTransactionsSet);
	}

App/src/libs/actions/Transaction.ts

Lines 1166 to 1168 in 10f648b

	function getDraftTransactions(): Transaction[] {
	return Object.values(allTransactionDrafts ?? {}).filter((transaction): transaction is Transaction => !!transaction);
	}

App/src/libs/actions/Transaction.ts

Lines 77 to 85 in 10f648b

	let allTransactionDrafts: OnyxCollection<Transaction> = {};
	Onyx.connect({
	key: ONYXKEYS.COLLECTION.TRANSACTION_DRAFT,
	waitForCollectionCallback: true,
	callback: (value) => {
	allTransactionDrafts = value ?? {};
	},
	});

However, when we call removeDraftTransactions after reopening the app, the list is empty. It's because inline require is enabled, and this Onyx.connect is only executed once we call the code from Transaction.ts.

App/src/libs/actions/Transaction.ts

Lines 77 to 85 in 10f648b

	let allTransactionDrafts: OnyxCollection<Transaction> = {};
	Onyx.connect({
	key: ONYXKEYS.COLLECTION.TRANSACTION_DRAFT,
	waitForCollectionCallback: true,
	callback: (value) => {
	allTransactionDrafts = value ?? {};
	},
	});

What changes do you think we should make in order to solve the problem?

We need to pass the list of draft transaction keys using useOnyx.

In FloatingActionButtonAndPopover,

const [draftTransactionKeys = []] = useOnyx(ONYXKEYS.COLLECTION.TRANSACTION_DRAFT, {selector: (value) => Object.keys(value ?? {})});

then pass it down tostartMoneyRequest > clearMoneyRequest > removeDraftTransactions.

const draftTransactionsSet = draftTransactionKeys.reduce(
    (acc, item) => {
        if (shouldExcludeInitialTransaction && item.replace(ONYXKEYS.COLLECTION.TRANSACTION_DRAFT, "") === CONST.IOU.OPTIMISTIC_TRANSACTION_ID) {
            return acc;
        }
        acc[item] = null;
        return acc;
    },
    {} as Record<string, null>,
);
return Onyx.multiSet(draftTransactionsSet);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

[lorretheboy]

🚨 Edited by proposal-police: This proposal was edited at 2025-09-02 15:49:20 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Waypoints are not cleared after relaunching app

What is the root cause of that problem?

The issue was caused by the Onyx.connect() callback in for allTransactionDrafts not being executed until the code is actually imported. When removeDraftTransactions() was called during app startup, the allTransactionDrafts variable was still empty because the Onyx.connect() callback hadn't been triggered yet.

App/src/libs/actions/Transaction.ts

Lines 77 to 84 in 3e3a327

	let allTransactionDrafts: OnyxCollection<Transaction> = {};
	Onyx.connect({
	key: ONYXKEYS.COLLECTION.TRANSACTION_DRAFT,
	waitForCollectionCallback: true,
	callback: (value) => {
	allTransactionDrafts = value ?? {};
	},
	});

So that this function is not working

App/src/libs/actions/TransactionEdit.ts

Line 100 in 5da0d43

function removeDraftTransactions(shouldExcludeInitialTransaction = false) {

What changes do you think we should make in order to solve the problem?

We should fix the problematic function which is removeDraftTransactions. If no draft transactions in memory (likely due to inline require), we should use Onyx.connectWithoutView to get the current state from storage

By doing this way, we can make sure all the place that trigger removeDraftTransactions would work as expected

    if (!draftTransactions.length || draftTransactions.length === 0) {
        return new Promise<void>((resolve) => {
            const conn = Onyx.connectWithoutView({
                key: ONYXKEYS.COLLECTION.TRANSACTION_DRAFT,
                waitForCollectionCallback: true,
                callback: (draftTransactionCollection) => {
                    Onyx.disconnect(conn);

                    if (!draftTransactionCollection) {
                        resolve();
                        return;
                    }

                    const draftTransactionsSet = Object.keys(draftTransactionCollection).reduce(
                        (acc, key) => {
                            if (shouldExcludeInitialTransaction && key.replace(ONYXKEYS.COLLECTION.TRANSACTION_DRAFT, '') === CONST.IOU.OPTIMISTIC_TRANSACTION_ID) {
                                return acc;
                            }
                            acc[key] = null;
                            return acc;
                        },
                        {} as Record<string, null>,
                    );
                    Onyx.multiSet(draftTransactionsSet).then(() => resolve());
                },
            });
        });
    }

Note: We can add new prop in removeDraftTransactions to only use connectWithoutView for the clear draft txn data in App.tsx

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @brunovjk (External)

[brunovjk]

Thank you all for the proposals.
@bernhardoj — you correctly identified the root cause, but I think your solution complicates the API surface and risking missed callers of startMoneyRequest or clearMoneyRequest. Thanks for the effort.

I prefer the fix that refreshes draft transactions from storage using Onyx.connectWithoutView before clearing them.

I think we can go with @lorretheboy's proposal

🎀 👀 🎀 C+ reviewed