[HOLD for payment 2022-01-11] Tooltip above your own avatar in the LHN does not say “settings”

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open app
2. Login
3. Hover over the your own avatar in the LHN

Expected Result:

Tooltip above your own avatar in the LHN would say “settings” instead of my name, since clicking on it opens the settings modal.

Actual Result:

Tooltip above your own avatar in the LHN does not say “settings”.

Workaround:

unknown

Platform:

Where is this issue occurring?

• Web
• Desktop App

Version Number: 1.1.23-0
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @puneetlath
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1640640138138800

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @francoisl (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[MelvinBot]

Triggered auto assignment to @Christinadobrzyn (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[sobitneupane]

Proposal:
Changing tooltipText to {this.props.translate('common.settings')} in AvatarWithIndicator component in SidebarLink.js solves the issue.

<AvatarWithIndicator
                            source={this.props.myPersonalDetails.avatar}
                            isActive={this.props.network && !this.props.network.isOffline}
                            isSyncing={this.props.network && !this.props.network.isOffline && this.props.isSyncingData}
                            tooltipText={this.props.translate('common.settings')} // <--- Changed Line
                        />