[Due for payment 2025-10-28] [$250] [ORTF] report:enddate

[arosiclair]

Add support for

• {report:enddate} – Report end date (newest expense date)

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021958951223479393587
• Upwork Job ID: 1958951223479393587
• Last Price Increase: 2025-09-11
• Automatic offers:
• linhvovan29546 | Reviewer | 108794897

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @stephanieelliott / @clarajones-expensify

[mohammadjafarinejad]

🚨 Edited by proposal-police: This proposal was edited at 2025-09-06 05:45:02 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Add support for Report dates.

What is the root cause of that problem?

• New Feature request.

What changes do you think we should make in order to solve the problem?

1. Add enddate case in computeReportPart()

   App/src/libs/Formula.ts

   Lines 243 to 247 in 869b6ad

   	switch (field.toLowerCase()) {
   	case 'type':
   	return formatType(report.type);
   	case 'startdate':
   	return formatDate(getOldestTransactionDate(report.reportID), format);

   switch (field.toLowerCase()) {
     // ... other cases
     case "enddate":
       return formatDate(getNewestTransactionDate(report.reportID, context), format);
     // ... other cases
   }

2. Implement getAllReportTransactionsWithContext() function

Use a shared helper to get transactions with context, ensuring the latest transaction is included. Both getOldestTransactionDate() and getNewestTransactionDate() should use it.

function getAllReportTransactionsWithContext(reportID: string, context?: FormulaContext): Transaction[] {
    const transactions = [...getReportTransactions(reportID)];
    const ctxTxn = context?.transaction;

    if (ctxTxn?.transactionID && ctxTxn.reportID === reportID) {
        const idx = transactions.findIndex((t) => t?.transactionID === ctxTxn.transactionID);
        if (idx >= 0) {
            transactions[idx] = ctxTxn;
        } else {
            transactions.push(ctxTxn);
        }
    }

    return transactions;
}

3. Implement getNewestTransactionDate() function

   Add a new utility function to get the newest transaction date:
   Optionally, we can use getAllSortedTransactions() in both getNewestTransactionDate() and getOldestTransactionDate().

   /**
    * Get the date of the newest transaction for a given report
    */
   function getNewestTransactionDate(reportID: string, context?: FormulaContext): string | undefined {
     if (!reportID) {
       return undefined;
     }
   
     const transactions = getReportTransactions(reportID);
     if (!transactions || transactions.length === 0) {
       return new Date().toISOString();
     }
   
     let newestDate: string | undefined;
   
     transactions.forEach((transaction) => {
       // Use updated transaction data if available and matches this transaction
       const currentTransaction = context?.transaction && transaction.transactionID === context.transaction.transactionID ? context.transaction : transaction;
   
       const created = getCreated(currentTransaction);
       if (!created) {
         return;
       }
       if (newestDate && created <= newestDate) {
         return;
       }
       if (isPartialTransaction(currentTransaction)) {
         return;
       }
       newestDate = created;
     });
   
     return newestDate;
   }

4. Update populateOptimisticReportFormula() to support enddate

   App/src/libs/ReportUtils.ts

   Lines 6024 to 6026 in fab7cf8

   	.replaceAll(/\{report:type\}/gi, 'Expense Report')
   	.replaceAll(/\{report:startdate\}/gi, createdDate ? format(createdDate, CONST.DATE.FNS_FORMAT_STRING) : '')
   	.replaceAll(/\{report:total\}/gi, report.total !== undefined ? convertToDisplayString(Math.abs(report.total), report.currency).toString() : '')

   Two ways to fix it:

   Option A – Use compute() from Formula

   This creates a dependency cycle with Formula.ts. It can be fixed in the PR. There are multiple ways to fix it.

   function populateOptimisticReportFormula(formula: string, report: OptimisticExpenseReport, policy: OnyxEntry<Policy>): string {
     try {
       const context = { report, policy };
       return compute(formula, context);
     } catch (error) {
       Log.warn("Failed to process optimistic report names", { error });
       return formula;
     }
   }

   Option B – Manual regex replacements

   Update the function directly using manual regex patterns for endDate. However, this option does not support formatting. We can use helpers from Formula.ts within the function.

   function populateOptimisticReportFormula(formula: string, report: OptimisticExpenseReport, policy: OnyxEntry<Policy>): string {
     const createdDate = report.lastVisibleActionCreated ? new Date(report.lastVisibleActionCreated) : undefined;
   
     const result = formula
       // Existing patterns ...
       .replaceAll(/\{report:enddate\}/gi, createdDate ? format(createdDate, CONST.DATE.FNS_FORMAT_STRING) : "");
   
     return result.trim().length ? result : formula;
   }

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

• Add tests in tests/unit/FormulaTest.ts for date formatting.

What alternative solutions did you explore? (Optional)

N/A

Test branch: test/ortf-59689

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021958951223479393587

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @linhvovan29546 (External)

[melvin-bot]

Triggered auto assignment to @stephanieelliott (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.