[Due for payment 2025-09-19] [$250] Xero - Some advanced settings have undefined default values

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.1.95-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://test-management.browserstack.com/projects/2219752/folder/13176909/test-cases/41237455
Email or phone of affected tester (no customers): -
Issue reported by: Applause Internal Team
Device used: Win 11, MacOS 10.15.7
App Component: Other

Action Performed:

Preconditions: workspace with connected Xero integration.

1. Go to WS > Accounting
2. Go to Advanced tab

Expected Result:

"Xero bill payment account" and "Xero invoice payment account" options display the list of account OR a message that instructs the user to add the account and sync the connection.
No undefined default value.

Actual Result:

'undefined' default value.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021957957951525394793
• Upwork Job ID: 1957957951525394793
• Last Price Increase: 2025-08-20
• Automatic offers:
• truph01 | Reviewer | 108538969
• nkdengineer | Contributor | 108538971

Issue Owner

Current Issue Owner: @stephanieelliott

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

'undefined' default value.

What is the root cause of that problem?

We are using String(selectedBillPaymentAccountName) to set title and if selectedBillPaymentAccountName is undefined, it'll return string undefined

App/src/pages/workspace/accounting/xero/advanced/XeroAdvancedPage.tsx

Lines 101 to 124 in 9297c81

	<OfflineWithFeedback pendingAction={settingsPendingAction([CONST.XERO_CONFIG.REIMBURSEMENT_ACCOUNT_ID], pendingFields)}>
	<MenuItemWithTopDescription
	shouldShowRightIcon
	title={String(selectedBillPaymentAccountName)}
	description={translate('workspace.xero.advancedConfig.xeroBillPaymentAccount')}
	key={translate('workspace.xero.advancedConfig.xeroBillPaymentAccount')}
	wrapperStyle={[styles.sectionMenuItemTopDescription]}
	onPress={() => Navigation.navigate(ROUTES.POLICY_ACCOUNTING_XERO_BILL_PAYMENT_ACCOUNT_SELECTOR.getRoute(policyID))}
	brickRoadIndicator={areSettingsInErrorFields([CONST.XERO_CONFIG.REIMBURSEMENT_ACCOUNT_ID], errorFields) ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : undefined}
	/>
	</OfflineWithFeedback>
	<OfflineWithFeedback pendingAction={settingsPendingAction([CONST.XERO_CONFIG.INVOICE_COLLECTIONS_ACCOUNT_ID], pendingFields)}>
	<MenuItemWithTopDescription
	shouldShowRightIcon
	title={String(selectedBankAccountName)}
	description={translate('workspace.xero.advancedConfig.xeroInvoiceCollectionAccount')}
	key={translate('workspace.xero.advancedConfig.xeroInvoiceCollectionAccount')}
	wrapperStyle={[styles.sectionMenuItemTopDescription]}
	onPress={() => Navigation.navigate(ROUTES.POLICY_ACCOUNTING_XERO_INVOICE_SELECTOR.getRoute(policyID))}
	brickRoadIndicator={
	areSettingsInErrorFields([CONST.XERO_CONFIG.INVOICE_COLLECTIONS_ACCOUNT_ID], errorFields) ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : undefined
	}
	/>
	</OfflineWithFeedback>

What changes do you think we should make in order to solve the problem?

We should update this line to

          title={selectedBillPaymentAccountName ? String(selectedBillPaymentAccountName) : undefined}

App/src/pages/workspace/accounting/xero/advanced/XeroAdvancedPage.tsx

Line 104 in 9297c81

title={String(selectedBillPaymentAccountName)}

And same here

App/src/pages/workspace/accounting/xero/advanced/XeroAdvancedPage.tsx

Line 115 in 9297c81

title={String(selectedBankAccountName)}

or we can set the default value to Not configured

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[lorretheboy]

🚨 Edited by proposal-police: This proposal was edited at 2025-08-22 01:23:29 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Xero - Some advanced settings have undefined default values

What is the root cause of that problem?

We return nothing here if no account --> that cause title is undefined

App/src/pages/workspace/accounting/xero/advanced/XeroAdvancedPage.tsx

Line 36 in a4ed0c5

return;

App/src/pages/workspace/accounting/xero/advanced/XeroAdvancedPage.tsx

Line 115 in 9297c81

title={String(selectedBankAccountName)}

App/src/pages/workspace/accounting/xero/advanced/XeroAdvancedPage.tsx

Line 104 in 9297c81

title={String(selectedBillPaymentAccountName)}

What changes do you think we should make in order to solve the problem?

We should return not configured message if not found account

return translate('workspace.xero.notConfigured');

App/src/pages/workspace/accounting/xero/advanced/XeroAdvancedPage.tsx

Line 36 in a4ed0c5

return;

Can do similar to other places if needed

Or
We need to check if there is no match account, then we should leave it as empty string return ''; or leave it as undefined (remove the String() convert) here and here

We also need to update these places (and check other places as well) for the consistency

App/src/pages/workspace/accounting/intacct/export/SageIntacctNonReimbursableExpensesPage.tsx

Line 78 in 7083c03

title: config?.export.nonReimbursableAccount ? config.export.nonReimbursableAccount : translate('workspace.sageIntacct.notConfigured'),

App/src/pages/workspace/accounting/qbd/export/QuickbooksDesktopCompanyCardExpenseAccountPage.tsx

Line 42 in 7083c03

return qbdReimbursableAccounts.find(({id}) => nonReimbursableAccount === id)?.name || qbdReimbursableAccounts.at(0)?.name || translate('workspace.qbd.notConfigured');

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021957957951525394793

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @truph01 (External)

[lorretheboy]

Just noted for C+ here, the first proposal has updated their proposal for the solution to set default value to Not configured. So if the Design team decide to go with this way, I believe my proposal should be selected as it is the first proposal suggested this change. Thank you

or we can set the default value to Not configured