[Due for payment 2025-09-04] Clean up hasRestrictedPrimaryLogin use in App

[mountiny]

We had been using hasRestrictedPrimaryLogin property in App but the real key should be enableRestrictedPrimaryLogin which is saved in the db so we should refactor to start using that valued instead

Issue Owner

Current Issue Owner: @JmillsExpensify

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

@mountiny Only this place uses this property. Does this bug open for contributor?

App/src/pages/settings/Profile/Contacts/ContactMethodDetailsPage.tsx

Line 132 in 3921a4e

return !securityGroups?.[`${ONYXKEYS.COLLECTION.SECURITY_GROUP}${primaryDomainSecurityGroupID}`]?.hasRestrictedPrimaryLogin;

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Clean up hasRestrictedPrimaryLogin use in App

What is the root cause of that problem?

Cleanup

What changes do you think we should make in order to solve the problem?

We should update SecurityGroup type with enableRestrictedPrimaryLogin property

App/src/types/onyx/SecurityGroup.ts

Line 4 in 3921a4e

hasRestrictedPrimaryLogin: boolean;

And update all places that are using hasRestrictedPrimaryLogin

App/src/pages/settings/Profile/Contacts/ContactMethodDetailsPage.tsx

Line 132 in 3921a4e

return !securityGroups?.[`${ONYXKEYS.COLLECTION.SECURITY_GROUP}${primaryDomainSecurityGroupID}`]?.hasRestrictedPrimaryLogin;

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[mountiny]

Thanks, I can handle this one and make sure the BE is ready for this

[mountiny]

PR is up, on hold for BE