[Due for payment 2025-09-12] [BACK BUTTON] [$250] Unapproved Cash list doesn’t refresh after approving multi-expense reports

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.1.87-1
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: #67252
Email or phone of affected tester (no customers): applausetester+dp265@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac / Web
App Component: Other

Action Performed:

1. Log in as an admin of a workspace with approval and payment enabled.
   2. Ensure there are reports with multiple expenses pending approval.
   3. Go to Reports > Unapproved Cash from the left-hand navigation.
   4. Locate a report with multiple expenses — note it only shows a “View” button.
   5. Click View to open the expense details, then click report name in the header to get to Report
   6. Click Approve from the report details view.
   7. Press the back button in the app twice to return to the Unapproved Cash list.

Expected Result:

• The report is removed from the Unapproved Cash list after approval.
• The total expense count and amount are updated accordingly.
• Approval flow is consistent regardless of how many expenses are in the report.

Actual Result:

• The report is still visible in the Unapproved Cash list after approval.
• The total count and amount are not updated.
• User must manually refresh the page to see the updated state.
• Reports with multiple expenses can’t be approved directly from the list.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6902307_1753820241276.1_14_PM_2025-07-29.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021950831064819658134
• Upwork Job ID: 1950831064819658134
• Last Price Increase: 2025-07-31

Issue Owner

Current Issue Owner: @stephanieelliott

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nabi-ebrahimi]

🚨 Edited by proposal-police: This proposal was edited at 2025-07-31 15:03:52 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Unapproved Cash list doesn’t refresh after approving multi-expense reports

What is the root cause of that problem?

We don't retrigger the search for the current hash and key when we approve the report.

App/src/components/MoneyReportHeader.tsx

Lines 362 to 365 in fbc5bec

	} else {
	startApprovedAnimation();
	approveMoneyRequest(moneyRequestReport, true);
	}

What changes do you think we should make in order to solve the problem?

We only need to trigger the search again immediately after approving the request.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Demo

Screen.Recording.1404-05-09.at.7.32.26.PM.mov

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021950831064819658134

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[nabi-ebrahimi]

Updated Proposal

We can do more optimization and refactoring in the PR, but I am sure the RCA and solution are this.

[Ollyws]

I think @nabi-ebrahimi's proposal has the correct RCA, but I have noticed this also happens to other options such as 'Pay' so let's make sure to get that fixed too.

🎀👀🎀 C+ reviewed