[Due for payment 2025-10-13] [$250] Expense - Paying the expense removed the amount violation, but it re-appeared later

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.87-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Launch app
2. Create a Workspace
3. Tap overview - change plan to control
4. Go to workspace chat
5. Create a manual expense with 8 digit number which shows violation for amount
6. Submit, approve and pay elsewhere via top dropdown

Expected Result:

Paying the expense must remove the amount violation

Actual Result:

Paying the expense removed the amount violation, but it re-appeared later

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6902024_1753797937249.Screenrecorder-2025-07-29-19-27-56-979.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021953013986992609495
• Upwork Job ID: 1953013986992609495
• Last Price Increase: 2025-08-13
• Automatic offers:
• FitseTLT | Contributor | 108533959

Issue Owner

Current Issue Owner: @JmillsExpensify

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense - Paying the expense removed the amount violation, but it re-appeared later

What is the root cause of that problem?

We remove the violations when we pay optimstically so it disappears but the BE is adding it back so it re-appears.

What changes do you think we should make in order to solve the problem?

This can be solved in BE but we also avoid showing RBR's in FE when the iou report is settled ones like we do here

App/src/components/ReportActionItem/TransactionPreview/TransactionPreviewContent.tsx

Line 355 in 59ab268

{!isIOUSettled && shouldShowRBR && (

So we can implement the same solution for MoneyRequestView

App/src/components/ReportActionItem/MoneyRequestView.tsx

Lines 328 to 329 in 59ab268

	const getErrorForField = useCallback(
	(field: ViolationField, data?: OnyxTypes.TransactionViolation['data'], policyHasDependentTags = false, tagValue?: string) => {

  if (isSettled) {
                return '';
            }

Similarly we can avoid showing receipt audit violations for settled report's.

App/src/components/ReportActionItem/MoneyRequestView.tsx

Lines 565 to 571 in 59ab268

	{shouldShowReceiptAudit && (
	<OfflineWithFeedback pendingAction={getPendingFieldAction('receipt')}>
	<ReceiptAudit
	notes={receiptViolations}
	shouldShowAuditResult={!!shouldShowAuditMessage}
	/>
	</OfflineWithFeedback>

App/src/components/ReportActionItem/MoneyRequestView.tsx

Line 636 in 59ab268

{!!shouldShowAuditMessage && <ReceiptAuditMessages notes={receiptImageViolations} />}

Or we can easily set receiptImageViolations, receiptViolations to be empty for settled reports here so that no receipt RBR will be shown.
May be also the transaction error here but it is not a violation so we might still need to display it for settled reports too.
And also avoid the RBR's in TransactionItemRow here

App/src/components/TransactionItemRow/index.tsx

Lines 429 to 433 in 59ab268

	<TransactionItemRowRBRWithOnyx
	transaction={transactionItem}
	containerStyles={[styles.mt2, styles.minHeight4]}
	missingFieldError={missingFieldError}
	/>

App/src/components/TransactionItemRow/index.tsx

Lines 462 to 464 in 59ab268

	<TransactionItemRowRBRWithOnyx
	transaction={transactionItem}
	missingFieldError={missingFieldError}

but if we want to show non-violation errors like the transaction errors we can explicitly avoid violations in case of a settled report in ViolationsUtils.getRBRMessages

If needed we can also avoid RBRs for errors linked to settled reports in getReasonAndReportActionThatHasRedBrickRoad but for violations we are already not including settled report's violations in the calculation here.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N / A

What alternative solutions did you explore? (Optional)

[melvin-bot]

@JmillsExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@JmillsExpensify Still overdue 6 days?! Let's take care of this!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021953013986992609495

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (External)