[Due for payment 2025-08-29] [$250] Expense - Split distance expense shows unexpected error with rate not valid &duplicate violation

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: V9.1.86-3
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp https://test-management.browserstack.com/projects/2148171/test-runs/TR-215/folder/12015351/39318458/805630292
Email or phone of affected tester (no customers): slottwo1g@gmail.com
Issue reported by: Applause Internal Team
Device used: Redminote 10s android 13
App Component: Money Requests

Action Performed:

1. Go to https://staging.new.expensify.com/home
2. Open workpace chat
3. Create 2 potential duplicate distance expense
4. Enable distance rate
5. Create new distance rate and delete old rate
6. Go to workspace chat
7. Open expense report
8. Open the second expense - more- split
9. Tap save

Expected Result:

Split distance expense must be created without error when there is rate not valid and duplicate violation.

Actual Result:

Split distance expense shows unexpected error when there is rate not valid and duplicate violation.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021952393342401200146
• Upwork Job ID: 1952393342401200146
• Last Price Increase: 2025-08-04
• Automatic offers:
• huult | Contributor | 108379578

Issue Owner

Current Issue Owner: @sonialiap

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

@sonialiap Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021952393342401200146

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[huult]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Split distance expense shows unexpected error with rate not valid &duplicate violation

What is the root cause of that problem?

When we delete the old rate, the rate of the first/second expense will be out of policy because it was removed.

Continuing to click ‘More’ and splitting the expense using a rate that has been removed or is out of policy will result in a backend validation error, preventing the split.

Due to invalid data, the split expense incorrectly appears after the API call fails

App/src/libs/actions/IOU.ts

Line 12076 in 4d41b83

API.write(WRITE_COMMANDS.SPLIT_TRANSACTION, parameters, {optimisticData, successData, failureData});

What changes do you think we should make in order to solve the problem?

To fix this issue, we should validate the distance rate before proceeding with the split. If the rate doesn’t exist or is disabled, we should display an error and return early.

App/src/libs/actions/IOU.ts

Line 11933 in 4d41b83

add this

    const customUnitRateID = originalTransaction?.comment?.customUnit?.customUnitRateID;
    if (customUnitRateID && policy) {
        const customUnitRate = getDistanceRateCustomUnitRate(policy, customUnitRateID);

        // If the rate doesn't exist or is disabled, show an error and return early
        if (!customUnitRate || !customUnitRate.enabled) {
            const errorMessage = !customUnitRate ? 'iou.error.invalidRate' : 'iou.error.genericEditFailureMessage';

            console.log('****** errorMessage ******', errorMessage);

            // Show error to user
            Onyx.merge(`${ONYXKEYS.COLLECTION.SPLIT_TRANSACTION_DRAFT}${originalTransactionID}`, {
                errors: getMicroSecondOnyxErrorWithTranslationKey(errorMessage),
            });
            return;
        }
    }

and show this error in SplitExpensePage

App/src/pages/iou/SplitExpensePage.tsx

Line 68 in 46c3e9a

add

 useEffect(() => {
        if (!draftTransaction?.errors) {
            return;
        }

        const errorKeys = Object.keys(draftTransaction.errors);
        if (errorKeys.length === 0) {
            return;
        }

        const firstErrorKey = errorKeys.at(0);
        if (!firstErrorKey) {
            return;
        }

        const errorText = draftTransaction.errors[firstErrorKey];
        if (errorText) {
            // Error can be either a string or ReceiptError object
            const errorString = typeof errorText === 'string' ? errorText : errorText.source;
            setErrorMessage(errorString);
        }
    }, [draftTransaction?.errors]);

App/src/pages/iou/SplitExpensePage.tsx

Line 70 in 46c3e9a

addSplitExpenseField(transaction, draftTransaction);

add:

if (draftTransaction?.errors) {
    clearSplitTransactionDraftErrors(transactionID);
}

App/src/pages/iou/SplitExpensePage.tsx

Line 74 in 46c3e9a

if (sumOfSplitExpenses > Math.abs(transactionDetailsAmount)) {

  if (draftTransaction?.errors) {
      clearSplitTransactionDraftErrors(transactionID);
  }

Screen.Recording.2025-08-05.at.12.20.46.mp4

Test branch

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

none

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

Option 1:
We will automatically select a valid rate when splitting an expense

function getValidDistanceRate(policy: OnyxEntry<OnyxTypes.Policy>, originalRateID?: string): string | undefined {
    if (!policy?.customUnits) {
        return undefined;
    }

    const distanceUnit = getDistanceRateCustomUnit(policy);
    if (!distanceUnit?.rates) {
        return undefined;
    }

    // Check if the original rate is still valid and enabled
    if (originalRateID) {
        const originalRate = getDistanceRateCustomUnitRate(policy, originalRateID);
        if (originalRate?.enabled && originalRate.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE) {
            return originalRateID;
        }
    }

    // Get the default rate (first rate created) if it's enabled
    const defaultRate = DistanceRequestUtils.getDefaultMileageRate(policy);
    if (defaultRate?.customUnitRateID && defaultRate.enabled) {
        const rate = getDistanceRateCustomUnitRate(policy, defaultRate.customUnitRateID);
        if (rate?.enabled && rate.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE) {
            return defaultRate.customUnitRateID;
        }
    }

    // Find any enabled rate as fallback
    const enabledRates = Object.entries(distanceUnit.rates).filter(([, rate]) => rate.enabled && rate.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE);

    if (enabledRates.length > 0) {
        return enabledRates.at(0)?.[0]; // Return the first enabled rate ID
    }

    return undefined;
}

App/src/libs/actions/IOU.ts

Line 11969 in 4d41b83

add:

    // If the original transaction is a distance request, ensure we use a valid rate
    if (originalTransaction && isDistanceRequestTransactionUtils(originalTransaction)) {
        const originalRateID = originalTransaction.comment?.customUnit?.customUnitRateID;
        const validRateID = getValidDistanceRate(policy, originalRateID);

        // If the original rate is invalid but we found a valid one, update the transaction params
        if (validRateID && validRateID !== originalRateID) {
            // Add customUnitRateID to transactionParams since it's a distance request
            (transactionParams as RequestMoneyTransactionParams).customUnitRateID = validRateID;
        }
    }

Option 2:
The BE needs to be updated to not return a 402 when we split an expense with an invalid rate