[Due for payment 2025-09-04] [$250] Expensify Card - Smart limit is missing in the list when it is the selected limit type

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.84-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp https://test-management.browserstack.com/projects/2148171/test-runs/TR-135/folder/12015321/39317903/797466705?sort=%2Bidentifier
Email or phone of affected tester (no customers): applausetester+210703kh@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

• Workspace is set up with Expensify card feature.

1. Go to staging.expensify.com
2. Go to workspace settings > Expensify Card.
3. Click Issue card.
4. Select user > Next.
5. Select any card type > Next.
6. On Limit type page, select Smart limit > Next.
7. Proceed to limit input page.
8. Close the RHP.
9. Go to Workflows.
10. Disable Add approvals.
11. Go back to Expensify Card.
12. Click Issue card.
13. Continue with the card assignment and complete it.
14. Click on the assigned card.
15. Click Limit type.
    → Smart limit is selected but it is missing on the list.

Expected Result:

In Step 15, Smart limit should be present in the list because it is the selected option.

Actual Result:

In Step 15, Smart limit is missing in the list when it is the selected option.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6895022_1753165421894.20250722_141437.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021947709516358065429
• Upwork Job ID: 1947709516358065429
• Last Price Increase: 2025-07-22
• Automatic offers:
• mkzie2 | Contributor | 108212519

Issue Owner

Current Issue Owner: @ahmedGaber93

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In Step 15, Smart limit is missing in the list when it is the selected option.

What is the root cause of that problem?

In card limit type editor page, we only show the Smart Limit option if Approvals is enabled in that workspace:

App/src/pages/workspace/expensifyCard/WorkspaceEditCardLimitTypePage.tsx

Lines 121 to 123 in 1aa5d22

	if (areApprovalsConfigured) {
	options.push({
	value: CONST.EXPENSIFY_CARD.LIMIT_TYPES.SMART,

The problem is you're should not have been able to turn off Approvals when an Expensify card has SmartLimit. But in this case, the user works around by closing the issue new card flow after selecting the limit type, turn off Approvals first then resume the limit value step.

What changes do you think we should make in order to solve the problem?

We have several approaches regarding this:

1. Show an error and disallow issuing the card in confirmation step if selected SmartLimit but Approvals is disabled
2. Show the selected limit type as selected with checkmark but disabled (gray-out) in limit type editor page
3. Clear the issueNewCard Onyx data whenever the issue new card flow RHP is dismissed

For (1):

Disable the submit button here when Approvals are disabled and data?.limitType is SmartLimit. And display an explanative error message here if so. It requires the user to update limit type before proceeding.

const hasApprovalError = !!policy?.errorFields?.approvalMode;
const isAddApprovalEnabled = [CONST.POLICY.APPROVAL_MODE.BASIC, CONST.POLICY.APPROVAL_MODE.ADVANCED].some((approvalMode) => approvalMode === policy?.approvalMode) && !hasApprovalError;
const shouldDisableSubmitButton = !isAddApprovalEnabled && data?.limitType === CONST.EXPENSIFY_CARD.LIMIT_TYPES.SMART;

const errorMessage = getLatestErrorMessage(issueNewCard) || (shouldDisableSubmitButton ? translate('workspace.card.issueNewCard.approvalsRequiredError') : '');

For (2):

Update this line:

App/src/pages/workspace/expensifyCard/WorkspaceEditCardLimitTypePage.tsx

Line 121 in 1aa5d22

if (areApprovalsConfigured) {

to:

if (areApprovalsConfigured || card?.nameValuePairs?.limitType === CONST.EXPENSIFY_CARD.LIMIT_TYPES.SMART) {

And set the option's isDisabled: !areApprovalsConfigured.

Same for FIXED option:

App/src/pages/workspace/expensifyCard/WorkspaceEditCardLimitTypePage.tsx

Line 140 in 1aa5d22

if (shouldShowFixedOption) {

For (3):

Return a cleanup function the clearIssueNewCardFlow in this effect.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021947709516358065429

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 (External)

[sakluger]

Hey @ahmedGaber93, could you please review the proposal above?