[Due for payment 2025-08-29] [$250] App crashes when entering type:expense date:2025-07 in the search bar

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.82-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @puneetlath
Slack conversation (hyperlinked to channel name): #Expensify Bugs

Action Performed:

1. Navigate to the Reports > Reports
2. Enter the following query into the search bar : type:expense date:2025-07
3. Hit Enter.

Expected Result:

The search should return filtered report results based on the specified type and search query or provide "Nothing to show" if the date format is incorrect

Actual Result:

The page crashes completely upon submitting the query.

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.1430.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021948018474765437697
• Upwork Job ID: 1948018474765437697
• Last Price Increase: 2025-07-30
• Automatic offers:
• thelullabyy | Contributor | 108306005

Issue Owner

Current Issue Owner: @CortneyOfstad

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Eskalifer1]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crashes when entering type:expense date:2025-07 in the search bar

What is the root cause of that problem?

we dont have any validation here, so we got an error:

App/src/libs/DateUtils.ts

Lines 953 to 956 in 6ebb38d

	const formatToReadableString = (date: string): string => {
	const parsedDate = parse(date, 'yyyy-MM-dd', new Date());
	return format(parsedDate, 'MMMM d, yyyy');
	};

What changes do you think we should make in order to solve the problem?

We should add some validation:

const formatToReadableString = (date: string): string => {
    const parsedDate = parse(date, 'yyyy-MM-dd', new Date());

    if (!isValid(parsedDate)) {
        return date;
    }

    return format(parsedDate, 'MMMM d, yyyy');
};

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[thelullabyy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The page crashes entirely upon submitting a query that includes an incomplete date string, such as 2025-07.

What is the root cause of that problem?

• In the logic for retrieving filtersForm[onKey]:
  

  App/src/libs/SearchQueryUtils.ts

  Line 637 in 373fc15

  const onFilter = filterList.find((filter) => filter.operator === 'eq' && (isValidDate(filter.value.toString()) || isSearchDatePreset(filter.value.toString())));

  
  we already handle invalid dates by returning undefined when the date is clearly invalid.

• However, for a string like 2025-07, the isValidDate('2025-07') function currently returns true. This is because it relies on JavaScript’s new Date() constructor, which auto-fills missing parts (like the day), making 2025-07 default to 2025-07-01.
  See:
  

  App/src/libs/ValidationUtils.ts

  Line 71 in d21254b

  return isValid(testDate) && isAfter(testDate, pastDate) && isBefore(testDate, futureDate);

• As a result, filtersForm[onKey] ends up being '2025-07', even though that format is not strictly valid for our use case.

• Later, when formatting this value for display:
  

  App/src/components/Search/SearchPageHeader/SearchFiltersBar.tsx

  Line 135 in 373fc15

  displayText.push(isSearchDatePreset(value.On) ? translate(`search.filters.date.presets.${value.On}`) : `${translate('common.on')} ${DateUtils.formatToReadableString(value.On)}`);

  
  the app crashes because:

  App/src/libs/DateUtils.ts

  Line 955 in eac0214

  return format(parsedDate, 'MMMM d, yyyy');

• Here, the parsedDate becomes an Invalid Date, and calling format(parsedDate, 'MMMM d, yyyy') throws an error, leading to a full app crash.

What changes do you think we should make in order to solve the problem?

We should treat values like 2025-07 as invalid in our validation logic. To do this, we can modify isValidDate() to include a strict validation mode that uses parse() with an explicit format, e.g., 'yyyy-MM-dd'. If the input does not match this format exactly, we should return false.

Here's the updated version of the function:

App/src/libs/ValidationUtils.ts

Line 63 in d21254b

function isValidDate(date: string | Date): boolean {

function isValidDate(date: string | Date, isStrict: boolean = false): boolean {
    if (!date) {
        return false;
    }

    const pastDate = subYears(new Date(), 1000);
    const futureDate = addYears(new Date(), 1000);

    if (isStrict && typeof date === 'string') {
        const parsedDate = parse(date, 'yyyy-MM-dd', new Date());
        if (!isValid(parsedDate)) {
            return false;
        }
        return isAfter(parsedDate, pastDate) && isBefore(parsedDate, futureDate);
    }

    const testDate = new Date(date);
    return isValid(testDate) && isAfter(testDate, pastDate) && isBefore(testDate, futureDate);
}

Then, when calling this function during query processing, ensure isStrict is set to true so formats like 2025-07 are correctly rejected:

App/src/libs/SearchQueryUtils.ts

Line 637 in 373fc15

const onFilter = filterList.find((filter) => filter.operator === 'eq' && (isValidDate(filter.value.toString()) || isSearchDatePreset(filter.value.toString())));

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

• Ensure that isValidDate('2025-07', true) returns false.

What alternative solutions did you explore? (Optional)

[dmkt9]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crashes when entering type:expense date:2025-07 in the search bar

What is the root cause of that problem?

1. The date entered by the user is checked by isValidDate, and in this function, new Date is used, so the check will pass:
   

   App/src/libs/ValidationUtils.ts

   Lines 70 to 71 in 67242be

   	const testDate = new Date(date);
   	return isValid(testDate) && isAfter(testDate, pastDate) && isBefore(testDate, futureDate);

2. The date will be formatted through formatToReadableString to display:
   

   App/src/libs/DateUtils.ts

   Lines 953 to 956 in 67242be

   	const formatToReadableString = (date: string): string => {
   	const parsedDate = parse(date, 'yyyy-MM-dd', new Date());
   	return format(parsedDate, 'MMMM d, yyyy');
   	};

   
   In the formatToReadableString function, parse helper is used to parse, but the input data does not have enough 3 parts yyyy, MM, dd, so it will return Invalid Date. And the format helper will check the input by isValid, if it is Invalid Date, it will throw an error.

What changes do you think we should make in order to solve the problem?

We should make the parse and format functions safer. We'll wrap them and handle errors:

const safeParse: typeof parse = (dateStr, formatString, referenceDate, options?) => {
    const parsedDate = parse(dateStr, formatString, referenceDate, options);
    if (!isValid(parsedDate)) {
        Log.warn('something');
        return new Date(dateStr);
    }
    return parsedDate;
};

const safeFormat: typeof format = (date, formatStr, options?) => {
    try {
        return format(date, formatStr, options);
    } catch (e) {
        Log.warn('something');
        return 'Invalid Date'; // or something else
    }
};

And use replace all where parse and format helpers are used.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

We can apply it only to formatToReadableString or the functions in DateUtils.ts

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[PiyushChandra17]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crashes when entering type:expense date:2025-07 in the search bar

What is the root cause of that problem?

We are providing invalid date format, the date format input should be yyyy-MM-dd format, if the input date is invalid ,format will throw range error => Invalid time value

App/src/libs/DateUtils.ts

Line 903 in 2e1cddf

return transactionYear !== new Date().getFullYear();

App/src/libs/DateUtils.ts

Lines 953 to 956 in 2e1cddf

	const formatToReadableString = (date: string): string => {
	const parsedDate = parse(date, 'yyyy-MM-dd', new Date());
	return format(parsedDate, 'MMMM d, yyyy');
	};

App/src/components/Search/SearchPageHeader/SearchFiltersBar.tsx

Line 141 in 2e1cddf

displayText.push(`${translate('common.before')} ${DateUtils.formatToReadableString(value.Before)}`);

What changes do you think we should make in order to solve the problem?

We can update formatToReadableString function here,

App/src/libs/DateUtils.ts

Lines 953 to 956 in 2e1cddf

	const formatToReadableString = (date: string): string => {
	const parsedDate = parse(date, 'yyyy-MM-dd', new Date());
	return format(parsedDate, 'MMMM d, yyyy');
	};

• Add a validation check > If parsedDate is not valid, simply return ''> this will prevent that invalid time range error

with,

const formatToReadableString = (date: string): string => {
    const parsedDate = parse(date, 'yyyy-MM-dd', new Date());
    if (!isValid(parsedDate)) {
        return '';
    }
    return format(parsedDate, 'MMMM d, yyyy');
};

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

n/A

What alternative solutions did you explore? (Optional)

n/A

Result

invalid-date-format-fix.mov

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[PiyushChandra17]

@CortneyOfstad FYI: this issue is reproducible in production too (native iOS).

[melvin-bot]

@CortneyOfstad Eep! 4 days overdue now. Issues have feelings too...

[CortneyOfstad]

Was able to recreate in both iOS and on web (chrome) – getting eyes on this!