[$250] Expense-The Pay button is enabled on the expense details page when offline

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.1.80-8
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: #65296
Email or phone of affected tester (no customers): agexptest+pr1407b@gmail.com
Issue reported by: Applause Internal Team
Device used: Windows 11/ Chrome, Samsung S23FE/ Android 15, iPhone 13 Mini/ iOS 18.5
App Component: Money Requests

Action Performed:

Precondition:
User A and User B have set USD as the payment currency.
User B has paid an expense from User A at least once.

1. Go to staging.new.expensify.com
2. [User A] Submit an expense to User B
3. [User B] Go to Reports > Expenses
4. [User B] Click on the expense submitted by User A and close the RHP
5. [User B] Go offline
6. [User B] Verify that the Pay button is disabled
7. [User B] Click on the expense submitted by User A
8. [User B] In the expense details, note that the Pay button is enabled

Expected Result:

Similar to the Reports page, the Pay button should be disabled on the expense details.

Actual Result:

The Pay button is enabled on the expense details page when the app is in offline mode.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6888013_1752544082564.Pay_button_enabled_on_expense_details.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021946093916416415276
• Upwork Job ID: 1946093916416415276
• Last Price Increase: 2025-07-18

Issue Owner

Current Issue Owner: @rlinoz

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The Pay button is enabled on the expense details page when the app is in offline mode.

What is the root cause of that problem?

We only disable this button in expense details page when it's offline and the user cann't allow settlement

App/src/components/MoneyReportHeader.tsx

Line 564 in 7323ec5

isDisabled={isOffline && !canAllowSettlement}

And disable the pay button when it's offline

App/src/components/SelectionList/Search/ActionCell.tsx

Lines 98 to 107 in 7323ec5

	<Button
	text={text}
	onPress={goToItem}
	small
	style={[styles.w100]}
	isLoading={isLoading}
	success
	isDisabled={isOffline}
	isNested
	/>

What changes do you think we should make in order to solve the problem?

We should update this line to

    isDisabled={isOffline || !canAllowSettlement}

App/src/components/MoneyReportHeader.tsx

Line 564 in 7323ec5

isDisabled={isOffline && !canAllowSettlement}

Note: we should do the same here

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021946093916416415276

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)