[Due for payment 2025-07-22] [Fix CP'd] After paying with bank account, Pay button in other workspace&invoice defaults to bank payment

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.80-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: #65296
Email or phone of affected tester (no customers): applausetester+ds90nu23@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• Workspace is set up with bank account.
• Admin invites member to the workspace.
• Member has a personal bank account.

1. Go to staging.new.expensify.com
2. [Member] Submit an expense with amount more than $100 to the workspace chat.
3. [Member] Click Submit on the expense preview.
4. [Admin] Open workspace chat with member.
5. [Admin] Click Approve and Pay by bank account.
6. [Admin] Create a new workspace and go to workspace chat.
7. [Admin] Create an expense in the workspace chat.
8. [Admin] Click Submit and Approve.
9. [Admin] Click Pay button.
   → Connect bank account page opens when it is a new workspace with no prior payment made in the workspace.
10. [Member] Send an invoice to admin.
11. [Admin] Open the invoice report.
12. [Admin] Click Pay button.
    → Payment fails. System message shows "paid with wallet" and error appears.

Expected Result:

In Step 9, when admin pays the expense for the first time in the new workspace, the Pay button should ask to select Pay with business account or Mark as paid first.

In Step 12, Pay button should ask to select Pay as an individual or a business first because this is the first time the invoice is paid.

Actual Result:

In Step 9, when admin pays the expense for the first time in the new workspace, the Pay button opens Connect bank account page

In Step 12, when admin pays the invoice for the first time, the Pay button defaults to bank account payment and it leads to error. System message shows "paid with wallet" and error appears.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

2.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @MarioExpensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[rushatgabhane]

@BlameGPT guess the cause

[BlameGPT]

Suspects on the loose 🕵

• feat: standardize pay button #65296: Introduces major refactor of SettlementButton, PaymentUtils, and preferred payment-method storage, directly changing how the Pay button decides and displays payment options across workspaces, expenses, and invoices.
• fix: replace dropdown menu when only one option #65390: Alters ButtonWithDropdownMenu to swap dropdowns for a single button when only one option is detected, which could suppress the method-selection menu used by the Pay button.

If not above, check these

• Fix - Pay someone - Mark down is not rendered in description field after paying someone #60197: Touches IOU pay-flow parameters in actions/IOU.ts; though smaller, it still modifies pay logic and could influence default handling after payment.

[hungvu193]

Checking 👀

[hungvu193]

@getusha we might need to change the logic of hasIntentToPay here:

App/src/components/SettlementButton/index.tsx

Line 556 in ccd01b2

const shouldUseSplitButton = hasPreferredPaymentMethod || !!lastPaymentPolicy || ((isInvoiceReport || isExpenseReportUtil(iouReport)) && hasIntentToPay);

App/src/components/SettlementButton/index.tsx

Line 126 in ccd01b2

const hasIntentToPay = formattedPaymentMethods.length === 1 && !lastPaymentMethod;

With expense, I think we should also check if !!policy?.achAccount is available?