[Due for payment 2025-07-30] [$250] `Register for webinar` button is shown on the thread of admin room.

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.79-11
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dukenv0307
Slack conversation (hyperlinked to channel name): #expensify_bugs

Action Performed:

1. Sign in with a new account
2. Select Manage my team's expenses
3. Select 1-10 employees
4. Select NetSuite or Sage Intacct, then the workspace is auto-upgraded to control plan
5. Open the admin room
6. Send a message and reply in thread

Expected Result:

Register for webinar shouldn't be shown in the thread of the admin room

Actual Result:

Register for webinar is shown in the thread of the admin room

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Screen.Recording.2025-07-11.at.13.45.42.mov

Recording.3301.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021943716666697247971
• Upwork Job ID: 1943716666697247971
• Last Price Increase: 2025-07-11

Issue Owner

Current Issue Owner: @clarajones-expensify

[melvin-bot]

Triggered auto assignment to @clarajones-expensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[izarutskaya]

From @dukenv0307

Proposal

Please re-state the problem that we are trying to solve in this issue.

Register for webinar button is shown on the thread of admin room.

What is the root cause of that problem?

The thread inherits the chatType of the parent report, so isAdminRoom is still true for the thread of the admin room.

App/src/pages/home/HeaderView.tsx

Line 229 in 4dbbb24

const shouldShowRegisterForWebinar = introSelected?.companySize === CONST.ONBOARDING_COMPANY_SIZE.MICRO && (isChatUsedForOnboarding || isAdminRoom(report));

What changes do you think we should make in order to solve the problem?

We should prevent the button from being shown on the thread like the same here

const shouldShowRegisterForWebinar = introSelected?.companySize === CONST.ONBOARDING_COMPANY_SIZE.MICRO && (isChatUsedForOnboarding || (isAdminRoom(report) && !isChatThread));

App/src/pages/home/HeaderView.tsx

Line 229 in 4dbbb24

const shouldShowRegisterForWebinar = introSelected?.companySize === CONST.ONBOARDING_COMPANY_SIZE.MICRO && (isChatUsedForOnboarding || isAdminRoom(report));

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

We can update isAdminRoom function to not return true for the thread report

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[samranahm]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Register for webinar button is shown on the thread of admin room.

What is the root cause of that problem?

• "Register for webinar", "Guide booking", and "Scheduled call" options display in OnboardingHelpDropdownButton and if there is only one option we display OnboardingHelpDropdownButton as single button ("Register for webinar" in this case).

App/src/pages/home/HeaderView.tsx

Line 230 in 4668539

const shouldShowOnBoardingHelpDropdownButton = (shouldShowRegisterForWebinar || shouldShowGuideBooking) && !isArchived;

• Here we only check for isArchived to prevent getting any button Archived chat, but we are not checking if the chat is isChatThread so that we can prevent showing any option of OnboardingHelpDropdownButton in chatThread

What changes do you think we should make in order to solve the problem?

We should update the shouldShowOnBoardingHelpDropdownButton variable to include !isChatThread that will make sure we did not get the same error for another OnboardingHelpDropdownButton option

const shouldShowOnBoardingHelpDropdownButton = (shouldShowRegisterForWebinar || shouldShowGuideBooking) && !isArchived && !isChatThread;

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We can update our test case

App/tests/ui/components/OnboardingHelpDropdownButtonTest.tsx

Lines 47 to 50 in 4668539

	function renderOnboardingHelpDropdownButton(props: {
	reportID: string;
	shouldUseNarrowLayout: boolean;
	shouldShowRegisterForWebinar: boolean;

to include this change to make sure there is no onboarding help button available for "chat thread"

What alternative solutions did you explore? (Optional)

We should explicitly check for isChatThread separately instead of just with isAdminRoom

const shouldShowRegisterForWebinar = introSelected?.companySize === CONST.ONBOARDING_COMPANY_SIZE.MICRO && (isChatUsedForOnboarding || isAdminRoom(report)) && !isChatThread);

isChatUsedForOnboarding can also be admin room so we should check the thread report for both.

[clarajones-expensify]

Hi @izarutskaya - showing the Register for webinar button (not in a dropdown) is the expected behavior for 1-10 employees, based on this GH: https://github.com/Expensify/Expensify/issues/520830

cc: @dylanexpensify - is this actually a bug? Not totally clear on this one.

[dylanexpensify]

Ah I see, @dubielzyk-expensify @dannymcclain should this not be visible in thread? I'd think the user wouldn't see the button in thread, but correct me if wrong here

[dannymcclain]

I would not expect it to show in the header for a thread either. You're not really "in" the admins room at that point. The focus/hierarchy of the chat has shifted to be whatever the thread topic is.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021943716666697247971

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rojiphil (External)