[$250] Invoice - Not here page opens when trying to add US bank account as unvalidated user

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.76-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/6426311
Email or phone of affected tester (no customers): nsjoijdoijsdosid1@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• Account is new and not validated with magic code.
• User has received an invoice.

1. Go to staging.expensify.com
2. Go to invoice room.
3. Click Pay button.
4. Click Pay as an individual > Add bank account.
5. Select United States and click Next.

Expected Result:

Account validation page will open because user account is not validated yet.

Actual Result:

Not here page opens.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021944734976720791249
• Upwork Job ID: 1944734976720791249
• Last Price Increase: 2025-07-14
• Automatic offers:
• nkdengineer | Contributor | 108092851

Issue Owner

Current Issue Owner: @nkdengineer

[melvin-bot]

Triggered auto assignment to @flaviadefaria (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Not here page opens.

What is the root cause of that problem?

We'll show the not found page for the invalidated user here

App/src/pages/AddPersonalBankAccountPage.tsx

Line 86 in 74e1436

<FullPageNotFoundView shouldShow={!isUserValidated}>

What changes do you think we should make in order to solve the problem?

We should navigate user to SETTINGS_CONTACT_METHOD_VERIFY_ACCOUNT to verify account first

        if (currentCountry === CONST.COUNTRY.US) {
            if (isUserValidated) {
                Navigation.navigate(ROUTES.SETTINGS_ADD_US_BANK_ACCOUNT);
            } else {
                Navigation.navigate(ROUTES.SETTINGS_CONTACT_METHOD_VERIFY_ACCOUNT.getRoute(Navigation.getActiveRoute(), ROUTES.SETTINGS_ADD_US_BANK_ACCOUNT));
            }
            return;
        }

App/src/pages/settings/Wallet/InternationalDepositAccount/substeps/CountrySelection.tsx

Lines 28 to 39 in 74e1436

	const onCountrySelected = useCallback(() => {
	if (currentCountry === CONST.COUNTRY.US) {
	Navigation.navigate(ROUTES.SETTINGS_ADD_US_BANK_ACCOUNT);
	return;
	}
	if (isEditing && formValues.bankCountry === currentCountry) {
	onNext();
	return;
	}
	fetchCorpayFields(currentCountry);
	resetScreenIndex?.(CONST.CORPAY_FIELDS.INDEXES.MAPPING.BANK_ACCOUNT_DETAILS);
	}, [currentCountry, formValues.bankCountry, isEditing, onNext, resetScreenIndex]);

Note: we can remove this condition and will navigate to SETTINGS_CONTACT_METHOD_VERIFY_ACCOUNT if user access by the link

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

OR we can add the ValidateCodeActionModal like we did here

App/src/pages/settings/Security/TwoFactorAuth/CopyCodesPage.tsx

Lines 170 to 186 in 74e1436

	<ValidateCodeActionModal
	title={translate('contacts.validateAccount')}
	descriptionPrimary={translate('contacts.featureRequiresValidate')}
	descriptionSecondary={translate('contacts.enterMagicCode', {contactMethod})}
	isVisible={isValidateModalVisible}
	validateCodeActionErrorField="validateLogin"
	validatePendingAction={loginData?.pendingFields?.validateCodeSent}
	sendValidateCode={() => requestValidateCodeAction()}
	handleSubmitForm={(validateCode) => validateSecondaryLogin(loginList, contactMethod, validateCode, true)}
	validateError={!isEmptyObject(validateLoginError) ? validateLoginError : getLatestErrorField(loginData, 'validateCodeSent')}
	clearError={() => clearContactMethodErrors(contactMethod, !isEmptyObject(validateLoginError) ? 'validateLogin' : 'validateCodeSent')}
	onModalHide={() => {}}
	onClose={() => {
	setIsValidateModalVisible(false);
	quitAndNavigateBack();
	}}
	/>

And will show this modal if the user is invalidated

    const [account, accountMetadata] = useOnyx(ONYXKEYS.ACCOUNT, {canBeMissing: true});
    const isUserValidated = account?.validated ?? false;
    const [isValidateModalVisible, setIsValidateModalVisible] = useState(!isUserValidated);

       useEffect(() => {
        setIsValidateModalVisible(!isUserValidated);
    }, [isUserValidated]);

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[dmkt9]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Not here page opens when trying to add US bank account as unvalidated user

What is the root cause of that problem?

When the account hasn't been validated yet, a not found page is rendered here:

App/src/pages/AddPersonalBankAccountPage.tsx

Line 86 in f181a83

<FullPageNotFoundView shouldShow={!isUserValidated}>

What changes do you think we should make in order to solve the problem?

Instead of showing the not found page, we should display the ValidateCodeActionModal to prompt the user to validate their account—similar to here:

App/src/pages/AddPersonalBankAccountPage.tsx

Line 29 in f181a83

const [isUserValidated] = useOnyx(ONYXKEYS.ACCOUNT, {selector: (account) => account?.validated, canBeMissing: false});

const [account] = useOnyx(ONYXKEYS.ACCOUNT, {canBeMissing: true});
const isUserValidated = account?.validated ?? false;
const contactMethod = account?.primaryLogin ?? '';
const [loginList] = useOnyx(ONYXKEYS.LOGIN_LIST, {canBeMissing: true});
const loginData = useMemo(() => loginList?.[contactMethod], [loginList, contactMethod]);
const validateLoginError = getEarliestErrorField(loginData, 'validateLogin');

App/src/pages/AddPersonalBankAccountPage.tsx

Lines 86 to 87 in f181a83

	<FullPageNotFoundView shouldShow={!isUserValidated}>
	<DelegateNoAccessWrapper accessDeniedVariants={[CONST.DELEGATE.DENIED_ACCESS_VARIANTS.DELEGATE]}>

{isUserValidated ? (
    <DelegateNoAccessWrapper accessDeniedVariants={[CONST.DELEGATE.DENIED_ACCESS_VARIANTS.DELEGATE]}>
        ...
) : (
    <ValidateCodeActionModal
        title={translate('contacts.validateAccount')}
        descriptionPrimary={translate('contacts.enterMagicCode', {contactMethod})}
        isVisible={!isUserValidated}
        validateCodeActionErrorField="validateLogin"
        validatePendingAction={loginData?.pendingFields?.validateCodeSent}
        sendValidateCode={() => requestValidateCodeAction()}
        handleSubmitForm={(validateCode) => validateSecondaryLogin(loginList, contactMethod, validateCode, true)}
        validateError={!isEmptyObject(validateLoginError) ? validateLoginError : getLatestErrorField(loginData, 'validateCodeSent')}
        clearError={() => clearContactMethodErrors(contactMethod, !isEmptyObject(validateLoginError) ? 'validateLogin' : 'validateCodeSent')}
        onClose={shouldShowSuccess ? exitFlow : Navigation.goBack}
    />
)}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

@flaviadefaria Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@flaviadefaria Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@flaviadefaria 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021944734976720791249