Reports - First workspace option in Workspaces list is highlighted

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.76-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp #63706
Email or phone of affected tester (no customers): applausetester+khcategory19@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Search

Action Performed:

Precondition:

• Have a few workspaces.

1. Go to staging.expensify.com
2. Go to Reports.
3. Click Filters.
4. Go to Workspaces.
5. Select a few workspaces.
6. Click Save.
7. Open Workspaces.

Expected Result:

Now that Workspaces filter supports multiple workspace search, the first option in the Workspaces list should not be highlighted.

Actual Result:

The first option in the Workspaces list is highlighted and disappears after selecting/unselecting workspace.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6877798_1751616912436.20250704_160902.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Eskalifer1]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Reports - First workspace option in Workspaces list is highlighted

What is the root cause of that problem?

The reason for this is on this line:

App/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersWorkspacePage.tsx

Line 105 in 81d84d7

initiallyFocusedOptionKey={selectedOptions?.at(0)}

What changes do you think we should make in order to solve the problem?

We jusnt need to remove that line

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[nabi-ebrahimi]

Now that Workspaces filter supports multiple workspace search, the first option in the Workspaces list should not be highlighted.

@mitarachim, You mean, it should show the unchecked workspaces first, then the checked workspaces?

[mitarachim]

Hello @nabi-ebrahimi, what the QA team meant is the highlight on the first workspace.

When multiple workspaces are selected, the first workspace should not be highlighted —
just like when multiple statuses are selected, no status is highlighted.

Screen.Recording.2025-07-07.at.10.16.55.AM.mov

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The first option in the Workspaces list is highlighted and disappears after selecting/unselecting workspace.

What is the root cause of that problem?

We're setting the default focused item as the first one in

App/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersWorkspacePage.tsx

Line 105 in 81d84d7

initiallyFocusedOptionKey={selectedOptions?.at(0)}

What changes do you think we should make in order to solve the problem?

There're other places that use both canSelectMultiple and initiallyFocusedOptionKey such as

App/src/components/CurrencySelectionList/index.tsx

Lines 102 to 111 in f660f73

	ListItem={canSelectMultiple ? SelectableListItem : RadioListItem}
	textInputLabel={searchInputLabel}
	textInputValue={searchValue}
	onChangeText={setSearchValue}
	onSelectRow={onSelect}
	shouldSingleExecuteRowSelect
	headerMessage={headerMessage}
	initiallyFocusedOptionKey={initiallySelectedCurrencyCode}
	showScrollIndicator
	canSelectMultiple={canSelectMultiple}

initiallyFocusedOptionKey shouldn't be set when canSelectMultiple is true. To prevent this issue totally, we should fix it in SelectionList

1. create the new variable: actualInitiallyFocusedOptionKey, and set it to empty when canSelectMultiple is true

    const actualInitiallyFocusedOptionKey = useMemo(() => {
        if (canSelectMultiple) {
            return '';
        }
        return initiallyFocusedOptionKey;
    }, [initiallyFocusedOptionKey, canSelectMultiple]);

2. Then use actualInitiallyFocusedOptionKey instead of initiallyFocusedOptionKey

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Write test for BaseSelectionList to cover this case

What alternative solutions did you explore? (Optional)

We can remove this line

App/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersWorkspacePage.tsx

Line 105 in 81d84d7

initiallyFocusedOptionKey={selectedOptions?.at(0)}

and update

App/src/components/CurrencySelectionList/index.tsx

Line 109 in f660f73

initiallyFocusedOptionKey={initiallySelectedCurrencyCode}

to

initiallyFocusedOptionKey={canSelectMultiple ? '' : initiallySelectedCurrencyCode}

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[parasharrajat]

The PR is reverted so this is no more an issue.

[parasharrajat]

Solved it in #65547

[melvin-bot]

@JmillsExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[JmillsExpensify]

Closing this out.