[$250] mWeb - RBR not displayed in lhn and preview after replacing receipt

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.1.74-3
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://github.com/Expensify/Expensify/issues/492269
Email or phone of affected tester (no customers): gocemate+b2153614@gmail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Login with any account
3. Create a scan expense to another user
4. Turn on 'Simulate failing network requests'
5. Replace and upload a new image for the receipt

Expected Result:

RBR must be displayed in lhn and preview after replacing receipt

Actual Result:

RBR not displayed in lhn and preview after replacing receipt.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021940799323856781330
• Upwork Job ID: 1940799323856781330
• Last Price Increase: 2025-07-03
• Automatic offers:
• FitseTLT | Contributor | 107981526

Issue Owner

Current Issue Owner: @francoisl

[melvin-bot]

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

mWeb - RBR not displayed in lhn and preview after replacing receipt

What is the root cause of that problem?

We implemented adding RBR on LHN and moeny request preview for receipt errors here so LHN RBR still exists for the expense reports

App/src/libs/SidebarUtils.ts

Lines 472 to 488 in 39f3cf4

	const transactionThreadReportID = getOneTransactionThreadReportID(report, chatReport, reportActions ?? []);
	if (transactionThreadReportID) {
	const transactionID = getTransactionID(transactionThreadReportID);
	const transaction = transactions?.[`${ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`];
	if (hasReceiptError(transaction)) {
	return {
	reason: CONST.RBR_REASONS.HAS_ERRORS,
	};
	}
	}
	const transactionID = getTransactionID(report.reportID);
	const transaction = transactions?.[`${ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`];
	if (isTransactionThread(parentReportAction) && hasReceiptError(transaction)) {
	return {
	reason: CONST.RBR_REASONS.HAS_ERRORS,
	};
	}

but MoneyRequestPreview content has gone through a lot of updates and the receipt error logic no longer exists in the Preview

What changes do you think we should make in order to solve the problem?

We can add receipt errors in here

App/src/libs/TransactionPreviewUtils.ts

Line 323 in 39f3cf4

const shouldShowRBR = hasAnyViolations || hasErrorOrOnHold || hasReportViolationsOrActionErrors;

    const shouldShowRBR = hasAnyViolations || hasErrorOrOnHold || hasReportViolationsOrActionErrors || hasReceiptError(transaction);

And then we will set RBRMessage to receiptFailureMessageShort copy in getTransactionPreviewTextAndTranslationPaths if it has receipt error.

  if (hasReceiptError(transaction) && RBRMessage === undefined) {
        RBRMessage = {translationPath: 'iou.error.receiptFailureMessageShort'};
    }

We can also display the RBR in LHN of the workspace chat if needed but I think we intentionally only display RBR if there are violations in the transactions linked to the worspace chat

App/src/libs/ReportUtils.ts

Lines 7920 to 7925 in 39f3cf4

	return potentialReports.some((potentialReport) => {
	return (
	!isInvoiceReport(potentialReport) &&
	(hasViolations(potentialReport.reportID, transactionViolations, true) ||
	hasWarningTypeViolations(potentialReport.reportID, transactionViolations, true) ||
	hasNoticeTypeViolations(potentialReport.reportID, transactionViolations, true))

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We can add a test for createTransactionPreviewConditionals to check it returns shouldShowRBR as true for receipt errors
and same for getTransactionPreviewTextAndTranslationPaths too.

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021940799323856781330

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rojiphil (External)

[OfstadC]

@rojiphil Could you please review the available proposal? Thank you! 😃

[melvin-bot]

@rojiphil Huh... This is 4 days overdue. Who can take care of this?

[rojiphil]

Thanks @FitseTLT for the proposal. The proposed solution LGTM i.e. add receipt errors to the expense preview. And, I also think it is intentional not to display RBR in policy chat according to this PR
🎀👀🎀 C+ reviewed