[Due for payment 2025-07-11][$125] Report - Review required error is displayed while a receipt is being scanned

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.1.74-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: #65201
Email or phone of affected tester (no customers): applausetester+ljweoiua@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: MacOS Chrome, Desktop, mWeb
App Component: Money Requests

Action Performed:

1. Navigate to a workspace chat
2. Tap + > Create expense > Scan > Select a receipt > Add Category > submit the expense
3. Before the scan finished, navigate to Reports > Expense

Expected Result:

There shouldn't be review required message while the receipt is scanning

Actual Result:

There is a review required message while the receipt is scanning

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021942113220743101619
• Upwork Job ID: 1942113220743101619
• Last Price Increase: 2025-07-10
• Automatic offers:
• linhvovan29546 | Contributor | 107993168

Issue Owner

Current Issue Owner: @RachCHopkins

[melvin-bot]

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[linhvovan29546]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Report - Review required error is displayed while a receipt is being scanned

What is the root cause of that problem?

The logic for displaying the RBR relies on the hasMissingSmartscanFields property, as seen here:

App/src/components/TransactionItemRow/index.tsx

Line 181 in 2846678

const hasFieldErrors = hasMissingSmartscanFields(transactionItem);

App/src/libs/TransactionUtils/index.ts

Lines 869 to 871 in 2846678

	function hasMissingSmartscanFields(transaction: OnyxInputOrEntry<Transaction>): boolean {
	return !!(transaction && !isDistanceRequest(transaction) && !isReceiptBeingScanned(transaction) && areRequiredFieldsEmpty(transaction));
	}

However, due to the Search command returning an incorrect receipt state(this value can be random and is not reliably catchable.), then the isReceiptBeingScanned function returns false.

App/src/libs/TransactionUtils/index.ts

Line 859 in 2846678

return [CONST.IOU.RECEIPT_STATE.SCAN_READY, CONST.IOU.RECEIPT_STATE.SCANNING].some((value) => value === transaction?.receipt?.state);

This results in the RBR display falling back to checking the amount and merchant, which is not the desired behavior.

What changes do you think we should make in order to solve the problem?

I think we can update the logic so that it isReceiptBeingScanned like this:

App/src/libs/TransactionUtils/index.ts

Lines 858 to 860 in 2846678

	function isReceiptBeingScanned(transaction: OnyxInputOrEntry<Transaction>): boolean {
	return [CONST.IOU.RECEIPT_STATE.SCAN_READY, CONST.IOU.RECEIPT_STATE.SCANNING].some((value) => value === transaction?.receipt?.state);
	}

function isReceiptBeingScanned(transaction: OnyxInputOrEntry<Transaction>): boolean {
    return !!transaction?.receipt?.state && ![CONST.IOU.RECEIPT_STATE.OPEN, CONST.IOU.RECEIPT_STATE.SCAN_FAILED, CONST.IOU.RECEIPT_STATE.SCAN_COMPLETE].some((value) => value === transaction?.receipt?.state);
}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We can write unit test for isReceiptBeingScanned or hasMissingSmartscanFields

What alternative solutions did you explore? (Optional)

The BE should return correct receipt state 'SCANNING'

[RachCHopkins]

9.1.76-4 iOS

Can repro!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021942113220743101619

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)