[Due for payment 2025-08-05] [$250] tags-Not all violations are shown in report preview and some colon is shown for missing tags

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: V9.1.69-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: #62483
Email or phone of affected tester (no customers): applausetester+96@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Redminote 10s android 13
App Component: Money Requests

Action Performed:

1. Go to https://staging.new.expensify.com/home
2. Go to workspace settings - enable tags - import dependent tags with GL code
3. Tap next - got it
4. Enable all tags
5. Tap settings - toggle on members must tag all expenses
6. Open workspace chat
7. Create a expense with merchant
8. Create a expense with merchant and city GL
9. Go to reports
10. Open first expense (note violations shown in report page)
11. Open second expense - select/deselect any option ( note violations shown in report page)
12. In reports page, note second expense's preview eg: category::::state

Expected Result:

All Violations must be shown in report preview and some colon must not be displayed for missing tags.

Actual Result:

Not all violations are displayed in the report preview, and some colons are displayed for missing tags.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6864905_1750363745541!Dependent_with_GL_codes_format (1).csv

Bug6864905_1750363745542.Screenrecorder-2025-06-20-01-25-50-533.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021937155756754024135
• Upwork Job ID: 1937155756754024135
• Last Price Increase: 2025-07-07

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @eVoloshchak

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Burhan-Rashid]

Proposal

Please re-state the problem that we are trying to solve in this issue.

tags-Not all violations are shown in report preview and some colon is shown for missing tags

What is the root cause of that problem?

The Onyx data for transaction violation has a little different structure than other violations. We are directly returning only one error message here based on tagName.

App/src/libs/Violations/ViolationsUtils.ts

Line 482 in 445080e

case 'someTagLevelsRequired':

The onyx data for transaction violation for multi level tag looks like this:

{
    "type": "violation",
    "name": "someTagLevelsRequired",
    "data": {
        "errorIndexes": [
            0,
            1,
            2
        ],
        "tagName": "State"
    },
    "showInReview": true
}

We need to check the errorIndexes of the transaction violation object and create the errors for all the errorIndexes.

2. For the second part with colon issue:
   Backend returns the tagName in that format only (e.g. "::San Francisco:::100" ), when some of the multilevel tags are missing and we show it directly on the UI. Currently we only remove the \\: while formatting tagName. We need to format it to remove the starting and trailing colons and also reduce multiple consecutive colons in the middle to a comma followed by a space ', ' as discussed here [Due for payment 2025-08-05] [$250] tags-Not all violations are shown in report preview and some colon is shown for missing tags #64624 (comment).
   

   App/src/libs/PolicyUtils.ts

   Lines 415 to 417 in ee04ec8

   	function getCleanedTagName(tag: string) {
   	return tag?.replace(/\\:/g, CONST.COLON);
   	}

What changes do you think we should make in order to solve the problem?

We can create a new function getTagViolationMessagesForMultiLevelTags to get the error for each missing tag in multi level tag here:

function getTagViolationMessagesForMultiLevelTags(tagName, errorIndexes, tags, translate): string {
    if (_isEmpty(errorIndexes) || _isEmpty(tags)) {
        return translate('violations.someTagLevelsRequired', {tagName});
    }
    const tagsWithIndexes = _keyBy(Object.values(tags), 'orderWeight');
    return errorIndexes.map((i) => translate('violations.someTagLevelsRequired', {tagName: tagsWithIndexes[i]?.name})).join(', ');
}

And call it here instead of returning a single error.

case 'someTagLevelsRequired':
                return getTagViolationMessagesForMultiLevelTags(tagName, errorIndexes, tags, translate);

Also in order to get the exact tag name based on index, we need to get the policyTags here

    const [policyTags] = useOnyx(`${ONYXKEYS.COLLECTION.POLICY_TAGS}${report?.policyID}`, {canBeMissing: true});

and pass the policyTags here

    const violationMessage = firstViolation ? ViolationsUtils.getViolationTranslation(firstViolation, translate, policyTags, canEdit) : undefined;

We need to change the function signature of ViolationsUtils.getViolationTranslation here:

getViolationTranslation(violation: TransactionViolation, translate: LocaleContextProps['translate'], tags = {}, canEdit = true): string {
        const {
            brokenBankConnection = false,
            isAdmin = false,
            email,
            isTransactionOlderThan7Days = false,
            member,
            category,
            rejectedBy = '',
            rejectReason = '',
            formattedLimit = '',
            surcharge = 0,
            invoiceMarkup = 0,
            maxAge = 0,
            tagName,
            taxName,
            type,
            rterType,
            message = '',
            errorIndexes = [],
        } = violation.data ?? {};

to accept tags as optional parameter and also make sure that whereever this function is called we are properly passing the arguments due to the function signature change.

2. For the second part, we can create a new function getCommaSeperatedTagNameWithSanitizedColons here and call that function here:

/**
 * Removes the starting, trailing colons from multi-level tags and also reduces multiple consecutive colons in the middle to a single comma and space ', ' from the tag name that we receive from backend
 */
function getCommaSeperatedTagNameWithSanitizedColons(tag: string) {
    return tag?.replace(/^:+|:+$/g, '').replace(/:+/g, ', ');
}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

we can create tests for the new functions that we created.

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

@isabelastisser Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021937155756754024135

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)