[Due for payment 2025-08-11] [Due for payment 2025-08-05] [$250] LHN - Chat with draft message disappears when change priority mode

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.1.69-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/6315635&group_by=cases:section_id&group_order=asc&group_id=296775
Email or phone of affected tester (no customers): gocemate+b215249@gmail.com
Issue reported by: Applause Internal Team
Device used: Lenovo 80ES / Windows 10 Pro
App Component: Left Hand Navigation (LHN)

Action Performed:

Preconditions:

1. User have a pin chat and other empty chat with drafted message
2. User is in Most Recent mode

Steps:

1. Go to Account> Preferences> Change the Priority mode to Focus
2. Go to Inbox and verify that drafted chat appears
3. Go to Account> Preferences> Change the Priority mode to Most Recent
4. Go to Inbox

Expected Result:

Chat with drafted message should persist when user change priority mode

Actual Result:

Chat with draft message disappears when user change priority mode to Focus and back to Most recent

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6864329_1750316273154.Recording__5541.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021937800198754685662
• Upwork Job ID: 1937800198754685662
• Last Price Increase: 2025-07-02
• Automatic offers:
• thelullabyy | Contributor | 108011507

Issue Owner

Current Issue Owner: @flaviadefaria

[melvin-bot]

Triggered auto assignment to @flaviadefaria (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[thelullabyy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• A draft chat message disappears when the user switches the priority mode from "Focus" to "Most Recent" and back.

What is the root cause of that problem?

• Switching priority modes triggers a call to the OpenApp API:
  

  App/src/libs/actions/App.ts

  Lines 86 to 89 in 8c88036

  	if (nextPriorityMode === CONST.PRIORITY_MODE.DEFAULT && priorityMode === CONST.PRIORITY_MODE.GSD) {
  	// eslint-disable-next-line @typescript-eslint/no-use-before-define
  	openApp();
  	}

  This call resets all report_ data in Onyx. Reports that have no actual chat messages but contain a draft message are also cleared from Onyx, causing the bug.

What changes do you think we should make in order to solve the problem?

• We should ensure that reports with draft messages are preserved during the reset. In the following section of the code:
  

  App/src/libs/actions/App.ts

  Line 326 in 8c88036

  Add logic to identify and retain such reports:

const reportsHaveDraftComments = Object.entries(allReportsDraftComment ?? {})
    .filter(([, value]) => value !== null)
    .map(([key]) => key.replace(ONYXKEYS.COLLECTION.REPORT_DRAFT_COMMENT, ''))
    .map((reportID) => allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${reportID}`]);

reportsHaveDraftComments?.forEach((report) => {
    result.successData?.push({
        onyxMethod: Onyx.METHOD.MERGE,
        key: `${ONYXKEYS.COLLECTION.REPORT}${report?.reportID}`,
        value: {
            ...report,
        },
    });
});

This ensures that any report with a draft comment is preserved in Onyx even if it doesn’t contain chat history.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

• N/A

What alternative solutions did you explore? (Optional)

[dmkt9]

I can't reproduce it

msedge_9T3wshGxpU.mp4

[melvin-bot]

@flaviadefaria Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021937800198754685662

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)