[Due for payment 2025-07-17] [$250] Web - Onboarding - Back button on accounting step closes onboarding when signed in from OD

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.68-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.expensify.com
2. Select Manage expenses for a small team
3. Enter email
4. Click Get started
5. Click Join
6. Click Skip on work email page
7. Click modal back button on accounting software step

Expected Result:

App will return to organization size with 1-10 employees preselected

Actual Result:

Onboarding exits

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6841988_1748190729625.Screen_Recording_2025-05-26_at_00.26.43.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021935729655629066684
• Upwork Job ID: 1935729655629066684
• Last Price Increase: 2025-06-19
• Automatic offers:
• brunovjk | Reviewer | 107756451
• samranahm | Contributor | 107756453
• daledah | Contributor | 108129538

Issue Owner

Current Issue Owner: @joekaufmanexpensify

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[samranahm]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Back button on accounting step closes onboarding when signed in from OD

What is the root cause of that problem?

Here we always show back Button

App/src/pages/OnboardingAccounting/BaseOnboardingAccounting.tsx

Lines 314 to 318 in 077e011

	<HeaderWithBackButton
	shouldShowBackButton
	progressBarPercentage={80}
	onBackButtonPress={Navigation.goBack}
	/>

Even if we are redirected from OD and there is no previous page to goBack

What changes do you think we should make in order to solve the problem?

We should explicitly check if isMergeAccountStepCompleted and prevent displaying back Button, when we redirect from OD to ND isMergeAccountStepCompleted is true and in these cases we should prevent displaying the button

    shouldShowBackButton={!onboarding?.isMergeAccountStepCompleted}

Here

App/src/pages/OnboardingAccounting/BaseOnboardingAccounting.tsx

Lines 314 to 315 in 077e011

	<HeaderWithBackButton
	shouldShowBackButton

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Onboarding exits

What is the root cause of that problem?

We always show the header back button here

App/src/pages/OnboardingAccounting/BaseOnboardingAccounting.tsx

Lines 314 to 315 in 077e011

	<HeaderWithBackButton
	shouldShowBackButton

What changes do you think we should make in order to solve the problem?

We'll not show the header back button if we are redirected from OD

            const isVsb = onboarding?.signupQualifier === CONST.ONBOARDING_SIGNUP_QUALIFIERS.VSB
             ...
            <HeaderWithBackButton
                shouldShowBackButton={!isVsb}
                ... 
            />

Note for C+: we should not to remove forceReplace: true because of this comment

App/src/pages/OnboardingWorkEmail/BaseOnboardingWorkEmail.tsx

Lines 73 to 78 in 9838da2

	// Once we verify that shouldValidate is false, we need to force replace the screen
	// so that we don't navigate back on back button press
	if (isVsb) {
	Navigation.navigate(ROUTES.ONBOARDING_ACCOUNTING.getRoute(), {forceReplace: true});
	return;
	}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

We can add the fallback route here

    Navigation.goBack(ROUTES.ONBOARDING_EMPLOYEES.getRoute());

Optional: we also need to update the fallback route here

            onBackButtonPress={() => {
                Navigation.goBack(ROUTES.ONBOARDING_PURPOSE.getRoute());
            }}

App/src/pages/OnboardingEmployees/BaseOnboardingEmployees.tsx

Line 83 in 077e011

onBackButtonPress={Navigation.goBack}

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Back button on accounting step closes onboarding when signed in from OD

What is the root cause of that problem?

This is because when navigating from Work Email to Accounting, we pass the forceReplace option. This makes the Accounting page as the first page in the nav stack, and on pressing the back button the Onboarding flow closes.

We should not be using forceReplace when going back from the Accounting Section, since VSB owners might actually want to go back and write the email.

What changes do you think we should make in order to solve the problem?

We will remove the forceReplace option when Navigating for VSB accounts here:

App/src/pages/OnboardingWorkEmail/BaseOnboardingWorkEmail.tsx

Lines 165 to 168 in b2eddc7

	if (isVsb) {
	Navigation.navigate(ROUTES.ONBOARDING_ACCOUNTING.getRoute(), {forceReplace: true});
	return;
	}

Navigation.navigate(ROUTES.ONBOARDING_ACCOUNTING.getRoute());

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

[joekaufmanexpensify]

Reproduced.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021935729655629066684

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @brunovjk (External)