[Due for payment 2025-07-15] [Betas][Clean Up] Enforce Permissions Pattern

[grgia]

Let's enforce the clean up refactor we did to Permissions.ts recently to prevent habitual patterns

https://expensify.slack.com/archives/C01GTK53T8Q/p1750096771551159?thread_ts=1750091383.820109&cid=C01GTK53T8Q

Issue Owner

Current Issue Owner: @laurenreidexpensify

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[grgia]

@parasharrajat is taking this 🚀

[parasharrajat]

Update: I will work on this soon.

[parasharrajat]

@grgia So I have created a new ESLint rule for this. It is simply a check for betas?.includes('anything') in the return statement of the function to determine the invalid case. Should I create a PR for this in the expensify-eslint config? It is not a very generic rule, so I am not sure whether we should put this in the config package. Can you please confirm?

[grgia]

I don't think we need to add it to the config package given it's repo specific

[parasharrajat]

Ok, Thanks. Then it makes it a bit complicated, as our ESLint version only allows adding the rules via a plugin. I will check other ways to do so in the app.

[parasharrajat]

After trying a few times, I think we can't add the rule locally. Eslint only supports via plugin so I used one eslint-plugin-rulesdir. This one allows passing customer rules, but it is not working as we are also using this same eslint-plugin-rulesdir plugin in our common plugin https://github.com/Expensify/eslint-config-expensify/blob/77884bbc3e7c3782f94fe8799f2cd0ca3fafef9b/index.js#L4. The only way is to move the rule to our package and then enable it only in new Dot Eslint config. This works, I tested it.

I noticed that we also have a few more repo-specific rules like https://github.com/Expensify/eslint-config-expensify/blob/main/eslint-plugin-expensify/prefer-actions-set-data.js in the plugin, so it will not be an issue to put another one there.

What do you say?

Created the PR Expensify/eslint-config-expensify#148