[Due for payment 2025-07-10] [$250] "Company card" in system message is hyperlinked for admin when the card is assigned to member

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.67-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+160604kh@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

• Workspace has at least one card in Company cards page.
• Workspace has at least one member other than yourself.

1. Go to staging.new.expensify.com
2. Go to workspace settings > Members.
3. Click on the member.
4. Click Add card.
5. Select the card feed.
6. Complete the flow to assign a company card to the member.
7. Go to workspace chat with member.
8. Click "company card" link in the system message.

Expected Result:

"company card" in the system message should not be hyperlinked for admin because the card is assigned to the other member and the link will open admin's wallet page.

Actual Result:

"company card" in the system message is hyperlinked for admin when the card is assigned to the other member and the link opens admin's wallet page.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021934909674354177466
• Upwork Job ID: 1934909674354177466
• Last Price Increase: 2025-06-17
• Automatic offers:
• daledah | Contributor | 107779723

Issue Owner

Current Issue Owner: @laurenreidexpensify

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"company card" in the system message is hyperlinked for admin when the card is assigned to the other member and the link opens admin's wallet page.

What is the root cause of that problem?

In here, we render link to Wallet page regardless of current user is card owner or not

App/src/libs/ReportActionsUtils.ts

Lines 2849 to 2851 in 4e9fe02

	const companyCardLink = shouldRenderHTML
	? `<a href='${environmentURL}/${ROUTES.SETTINGS_WALLET}'>${translateLocal('workspace.companyCards.companyCard')}</a>`
	: translateLocal('workspace.companyCards.companyCard');

What changes do you think we should make in order to solve the problem?

We should render normal text if current user is not card owner

App/src/libs/ReportActionsUtils.ts

Lines 2849 to 2852 in 4e9fe02

	const companyCardLink = shouldRenderHTML
	? `<a href='${environmentURL}/${ROUTES.SETTINGS_WALLET}'>${translateLocal('workspace.companyCards.companyCard')}</a>`
	: translateLocal('workspace.companyCards.companyCard');
	const isAssigneeCurrentUser = currentUserAccountID === assigneeAccountID;

    const isAssigneeCurrentUser = currentUserAccountID === assigneeAccountID;
    const companyCardLink = (shouldRenderHTML && isAssigneeCurrentUser)
        ? `<a href='${environmentURL}/${ROUTES.SETTINGS_WALLET}'>${translateLocal('workspace.companyCards.companyCard')}</a>`
        : translateLocal('workspace.companyCards.companyCard');

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021934909674354177466

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

[dukenv0307]

@daledah's proposal looks good to me

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @thienlnam, see https://stackoverflow.com/c/expensify/questions/7972 for more details.