[Due for payment 2025-07-14] [$250] Expense - After creating a report and changing workspace, app back button reopens same report

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.66-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+x40@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max / IOS 18.5
App Component: Money Requests

Action Performed:

Precondition:

• Create at least two workspaces.

1. Launch Expensify app.
2. Open FAB > Create report.
3. Tap More > Change workspace.
4. Select another workspace.
5. Tap app back button.

Expected Result:

After creating a report and changing workspace, app back button will return to LHN.

Actual Result:

After creating a report and changing workspace, app back button reopens the same report.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6859014_1749816141921.ScreenRecording_06-13-2025_19-59-31_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021934646126042272671
• Upwork Job ID: 1934646126042272671
• Last Price Increase: 2025-06-23
• Automatic offers:
• thelullabyy | Contributor | 107807377

Issue Owner

Current Issue Owner: @shubham1206agra

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[FitseTLT]

🚨 Edited by proposal-police: This proposal was edited at 2025-06-13 14:30:09 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense - After creating a report and changing workspace, app back button reopens same report

What is the root cause of that problem?

When we press create report in main FAB we are navigated to SEARCH.MONEY_REQUEST_REPORT screen so when we change workspace we goBAck to the report screen of the report here

App/src/pages/ReportChangeWorkspacePage.tsx

Line 47 in 2908e67

Navigation.goBack(ROUTES.REPORT_WITH_ID.getRoute(reportID));

but this will not remove the previous search screen from the stack so when we go back we go back to the same report in search screen which was under the screen stack.

What changes do you think we should make in order to solve the problem?

We need to go back to the search screen if we are already on search screen but only go back to report screen if we were in report screen

            Navigation.goBack(isSearchTopmostFullScreenRoute() ? ROUTES.SEARCH_MONEY_REQUEST_REPORT.getRoute({reportID}) : ROUTES.REPORT_WITH_ID.getRoute(reportID));

We can apply the same logic for the back button here
We can optionally use goBack () without a fallback route or dismissModal

On a related note currently when we refresh on ReportChangeWorkspacePage it always takes the central pane to report screen even if you were on search screen to fix that we can start appending a backTo here

App/src/components/MoneyReportHeader.tsx

Line 794 in 2908e67

Navigation.navigate(ROUTES.REPORT_WITH_ID_CHANGE_WORKSPACE.getRoute(moneyRequestReport.reportID));

                Navigation.navigate(ROUTES.REPORT_WITH_ID_CHANGE_WORKSPACE.getRoute(moneyRequestReport.reportID, Navigation.getActiveRoute()));

This can simplify our gackTo navigation because if we add this we can use the backTo param as a fallback to goBack or even goBack without a fallback can solve our current issue.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N / A

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021934646126042272671

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (External)

[thelullabyy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After creating a report and changing workspace, app back button reopens the same report.

What is the root cause of that problem?

After creating a report, the user is redirected to the Search Money Report page.

App/src/pages/home/sidebar/FloatingActionButtonAndPopover.tsx

Line 433 in 7b6e4e1

Navigation.navigate(ROUTES.SEARCH_MONEY_REQUEST_REPORT.getRoute({reportID: createdReportID, backTo: Navigation.getActiveRoute()}));

After changing the workspace, we return to the report screen.

App/src/pages/ReportChangeWorkspacePage.tsx

Line 48 in 7b6e4e1

Navigation.goBack(ROUTES.REPORT_WITH_ID.getRoute(reportID));

The navigation stack is now Report Screen --> Search Money Report. So, clicking on the app back button will go to the Search Money Report page, which has the same UI as the Report screen.

What changes do you think we should make in order to solve the problem?

1. I don't think it makes sense to open the search money report page if we create a new report from the Inbox. It looks like when the feature is initialized, we always navigate to this page because the expense report on the report screen doesn't have the same UI. But now, both UI are the same, we can improve the flow:

• If the user is on the search page, creating a report will redirect to the search money report page.
• Otherwise, redirect to the report screen.

Navigation.navigate(isSearchTopmostFullScreenRoute() ? ROUTES.SEARCH_MONEY_REQUEST_REPORT.getRoute({reportID: createdReportID, backTo: Navigation.getActiveRoute()}) : ROUTES.REPORT_WITH_ID.getRoute(createdReportID, undefined, undefined, undefined, undefined, Navigation.getActiveRoute()));

App/src/pages/home/sidebar/FloatingActionButtonAndPopover.tsx

Line 433 in 7b6e4e1

Navigation.navigate(ROUTES.SEARCH_MONEY_REQUEST_REPORT.getRoute({reportID: createdReportID, backTo: Navigation.getActiveRoute()}));

App/src/libs/actions/QuickActionNavigation.ts

Line 69 in 7b6e4e1

Navigation.navigate(ROUTES.SEARCH_MONEY_REQUEST_REPORT.getRoute({reportID: optimisticReportID, backTo: Navigation.getActiveRoute()}));

With this, the current flow in the OP works correctly

2. We shouldn't always go back to the report screen because we can also open the change workspace page from the search money report, RHP report. We should add the backTo param when we open the change workspace page here

Navigation.navigate(ROUTES.REPORT_WITH_ID_CHANGE_WORKSPACE.getRoute(moneyRequestReport.reportID, Navigation.getActiveRoute()));

App/src/components/MoneyReportHeader.tsx

Line 794 in 7b6e4e1

Navigation.navigate(ROUTES.REPORT_WITH_ID_CHANGE_WORKSPACE.getRoute(moneyRequestReport.reportID));

And goBack to the backTo param instead

function ReportChangeWorkspacePage({report, route}: ReportChangeWorkspacePageProps) {
const {backTo} = route.params;
Navigation.goBack(backTo);

App/src/pages/ReportChangeWorkspacePage.tsx

Line 48 in 7b6e4e1

Navigation.goBack(ROUTES.REPORT_WITH_ID.getRoute(reportID));

We can apply the same logic to the back button

App/src/pages/ReportChangeWorkspacePage.tsx

Line 90 in 7b6e4e1

onBackButtonPress={Navigation.goBack}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.