[Due for payment 2025-06-25] [$250] cards-On opening visa card for the first time, the more button display is misaligned briefly.

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: V9..159-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/6207382
Email or phone of affected tester (no customers): applausetester+ccardfeed@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Redminote 10s android 13
App Component: Workspace Settings

Action Performed:

1. Go to https://staging.new.expensify.com/home
2. Login with expensifail account - applausetester+ccardfeed@applause.expensifail.com
3. Go to company card do not delete workspace settings - company card
4. Add dropdown and select visa card

Expected Result:

On opening visa card for the first time, the more button display must not be misaligned briefly.

Actual Result:

On opening visa card for the first time, the more button display is misaligned briefly.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6851154_1749092940731.Screenrecorder-2025-06-05-08-32-14-413.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021932195306945703575
• Upwork Job ID: 1932195306945703575
• Last Price Increase: 2025-06-09
• Automatic offers:
• linhvovan29546 | Contributor | 107668651

Issue Owner

Current Issue Owner: @johncschuster

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[aadil42]

@mitarachim , I'm trying to login with applausetester+ccardfeed@applause.expensifail.com But how do I get back the magic code sent to that email?

[linhvovan29546]

Proposal

Please re-state the problem that we are trying to solve in this issue.

cards-On opening visa card for the first time, the more button display is misaligned briefly

What is the root cause of that problem?

We conditionally render the Assign Card button on the Company Cards page. Then the step from the OP causes shouldShowAssignCardButton to evaluate to false, then the Assign Card button is hidden:

App/src/pages/workspace/companyCards/WorkspaceCompanyCardsListHeaderButtons.tsx

Lines 110 to 119 in 46949ad

	{!!shouldShowAssignCardButton && (
	<Button
	success
	isDisabled={!currentFeedData || !!currentFeedData?.pending || isSelectedFeedConnectionBroken}
	onPress={handleAssignCard}
	icon={Expensicons.Plus}
	text={translate('workspace.companyCards.assignCard')}
	style={shouldChangeLayout && styles.flex1}
	/>
	)}

The issue arises because the ButtonWithDropdownMenu has a wrapperStyle is flexGrow0 and a minWidth is 40px, which causes the button to always appear small. So when the Assign Card button is not rendered (based on the OP), the More button does not expand to fill the available space, leading to a UI issue.

App/src/pages/workspace/companyCards/WorkspaceCompanyCardsListHeaderButtons.tsx

Line 120 in 46949ad

<ButtonWithDropdownMenu

What changes do you think we should make in order to solve the problem?

We can update the wrapperStyle conditionally to allow the More button to take the full width only when the Assign Card button is not displayed.

App/src/pages/workspace/companyCards/WorkspaceCompanyCardsListHeaderButtons.tsx

Line 127 in 46949ad

wrapperStyle={styles.flexGrow0}

                    <ButtonWithDropdownMenu
                        ...
                        wrapperStyle={shouldShowAssignCardButton ? styles.flexGrow0 : styles.flex1}
                    />

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A – this is a UI issue

What alternative solutions did you explore? (Optional)

Always render the Assign Card button and disable it if the condition is not met (shouldShowAssignCardButton is false)

App/src/pages/workspace/companyCards/WorkspaceCompanyCardsListHeaderButtons.tsx

Lines 110 to 112 in 46949ad

	{!!shouldShowAssignCardButton && (
	<Button
	success

                        <Button
                            success
      isDisabled={!shouldShowAssignCardButton || !currentFeedData || !!currentFeedData?.pending || isSelectedFeedConnectionBroken } // We should also rename shouldShowAssignCardButton to better reflect the updated logic.
                            onPress={handleAssignCard}
                            icon={Expensicons.Plus}
                            text={translate('workspace.companyCards.assignCard')}
                            style={shouldChangeLayout && styles.flex1}
                        />

[dmkt9]

Proposal

Please re-state the problem that we are trying to solve in this issue.

On opening visa card for the first time, the more button display is misaligned briefly.

What is the root cause of that problem?

1. The Assign card button is rendered depending on shouldShowAssignCardButton.
   

   App/src/pages/workspace/companyCards/WorkspaceCompanyCardsListHeaderButtons.tsx

   Lines 94 to 103 in 437acdd

   	{!!shouldShowAssignCardButton && (
   	<Button
   	success
   	isDisabled={!currentFeedData || !!currentFeedData?.pending || isSelectedFeedConnectionBroken}
   	onPress={handleAssignCard}
   	icon={Expensicons.Plus}
   	text={translate('workspace.companyCards.assignCard')}
   	style={shouldChangeLayout && styles.flex1}
   	/>
   	)}

2. shouldShowAssignCardButton is assigned here.
   

   App/src/pages/workspace/companyCards/WorkspaceCompanyCardsPage.tsx

   Lines 163 to 170 in 437acdd

   	{(isFeedAdded || isPending) && !!selectedFeed && (
   	<WorkspaceCompanyCardsListHeaderButtons
   	policyID={policyID}
   	selectedFeed={selectedFeed}
   	shouldShowAssignCardButton={isPending || !isEmptyObject(cards)}
   	handleAssignCard={handleAssignCard}
   	/>
   	)}

3. When switching to a Visa card, there is an approved card list, causing isPending=false and cards !== {}, leading to shouldShowAssignCardButton=false.

What changes do you think we should make in order to solve the problem?

We should display the Assign card button both when data is added and successfully loaded, just as when the page is fully rendered, meaning isFeedAdded=true.

App/src/pages/workspace/companyCards/WorkspaceCompanyCardsPage.tsx

Lines 163 to 170 in 437acdd

	{(isFeedAdded || isPending) && !!selectedFeed && (
	<WorkspaceCompanyCardsListHeaderButtons
	policyID={policyID}
	selectedFeed={selectedFeed}
	shouldShowAssignCardButton={isPending || !isEmptyObject(cards)}
	handleAssignCard={handleAssignCard}
	/>
	)}

shouldShowAssignCardButton={isFeedAdded || isPending || !isEmptyObject(cards)}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

N/A

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021932195306945703575

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)