[Due for payment 2025-06-24] [$250] Android - Search - Search focus is not lost by tapping outside.

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: V9 1.56-9
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): slottwo1gcd1@gmail.com
Issue reported by: Applause Internal Team
Device used: Redminote 10s android 13
App Component: Search

Action Performed:

1. Launch app
2. Tap search
3. Tap outside on top to lose search focus

Expected Result:

Search focus must be lost by tapping outside.

Actual Result:

Search focus is not lost by tapping outside.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6849926_1748974224271.Screenrecorder-2025-06-03-23-35-43-952.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021931036600335036494
• Upwork Job ID: 1931036600335036494
• Last Price Increase: 2025-06-06
• Automatic offers:
• truph01 | Contributor | 107623934

Issue Owner

Current Issue Owner: @abekkala

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Burhan-Rashid]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Android - Search - Search focus is not lost by tapping outside.

What is the root cause of that problem?

The onblur function of the Search TextInput is not triggered when we click outside of the TextInput here:

App/src/components/Search/SearchAutocompleteInput.tsx

Line 231 in 625b425

onBlur={() => {

What changes do you think we should make in order to solve the problem?

Instead of using the wrapping with View component here, we need to wrap it with PressableWithoutFeedback onPress={Keyboard.dismiss}, It will trigger the onBlur function of our TextInput when we click outside of it.

Changes to be made here:

App/src/components/Search/SearchRouter/SearchRouter.tsx

Line 322 in 625b425

<View

 <PressableWithoutFeedback
            accessibilityLabel={translate('common.search')}
            style={[styles.flex1, modalWidth, styles.h100, !shouldUseNarrowLayout && styles.mh85vh]}
            testID={SearchRouter.displayName}
            ref={ref}
            onPress={Keyboard.dismiss}
        >

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[dmkt9]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Search focus is not lost by tapping outside.

What is the root cause of that problem?

Because on iOS and Android, a TextInput only loses focus when we interact with other focusable elements.
This behavior is different from the web, so tapping outside will not cause it to lose focus.

What changes do you think we should make in order to solve the problem?

Add an onStartShouldSetResponder handler to the View to handle blurring the TextInput when tapping outside of it.

App/src/components/Search/SearchRouter/SearchRouter.tsx

Line 322 in d03ff24

<View

onStartShouldSetResponder={() => {
    textInputRef.current?.blur();
    return false;
}}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

N/A

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

qemu-system-x86_64_lFbaTBt2eB.mp4

[truph01]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• When tapping outside the search input on the SearchRoute screen, the focus remains on the input and the keyboard is not dismissed.

What is the root cause of that problem?

• The SearchRoute screen has two main sections:
  1. The data section
     This uses a list with the prop keyboardShouldPersistTaps="always":
     

     App/src/components/SelectionList/BaseSelectionList.tsx

     Line 922 in e3560bc

     keyboardShouldPersistTaps="always"

     
     This configuration prevents the keyboard from being dismissed when the user taps outside the input.

2. The rest of the screen: This includes the header and the search input component.
   (The interaction described in the reproduction steps in the OP specifically involves this section—in particular, the header area.)
   By default, tapping outside of a TextInput on native platforms does not dismiss the keyboard unless an explicit handler is added.

What changes do you think we should make in order to solve the problem?

• We should update the container at this location:
  

  App/src/components/Search/SearchRouter/SearchRouter.tsx

  Line 322 in e3560bc

  <View

  with the following props to handle touch events:

onStartShouldSetResponder={() => true}
onResponderRelease={() => {
    Keyboard.dismiss();
}}

This ensures that when the user lifts their finger (touchUp) on any non-interactive area of the screen, the keyboard will be dismissed. This behavior aligns with other pages in the app, where the keyboard is only dismissed upon finger lift rather than on touch down.

• Optionally: We can consider updating:
  

  App/src/components/HeaderWithBackButton/index.tsx

  Line 190 in e3560bc

  <View

        <View
            ...
            onStartShouldSetResponder={() => {
                return true;
            }}

This would prevent the keyboard from being dismissed when the user taps on the header area, further aligning with the behavior observed in other pages.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

• As an alternative, we could modify the list section only by updating this line:
  

  App/src/components/SelectionList/BaseSelectionList.tsx

  Line 922 in e3560bc

  keyboardShouldPersistTaps="always"

  Instead of keyboardShouldPersistTaps="always", we could use "handled".

  However, this would require adding a conditional flag to ensure the change only applies when the list is rendered within SearchRoute, to avoid affecting other screens that rely on the current behavior.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021931036600335036494

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)