[Due for payment 2025-06-25] [$250] Reports - Not here page opens when submitting expense offline and clicking View on expense row

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.54-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): sdjoisjnoisdjsdoi@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.4 / Chrome
App Component: Search

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Submit an expense.
4. Go to Reports.
5. Go to Expense Reports.
6. Go offline.
7. Click on the expense report.
8. Click + > Create expense > Manual.
9. Submit a manual expense.
10. Click back button on the report.
11. Click View on the new expense row created from Step 9.

Expected Result:

Transaction thread RHP will open.

Actual Result:

Not here page opens.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021928503528246009374
• Upwork Job ID: 1928503528246009374
• Last Price Increase: 2025-05-30
• Automatic offers:
• FitseTLT | Contributor | 107536194

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @lydiabarclay

[melvin-bot]

Triggered auto assignment to @lydiabarclay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[FitseTLT]

🚨 Edited by proposal-police: This proposal was edited at 2025-05-30 13:07:02 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Reports - Not here page opens when submitting expense offline and clicking View on expense row

What is the root cause of that problem?

When populating the search data optimistically we are not populating transactionThreadReportID for the transaction item here

App/src/libs/actions/IOU.ts

Lines 11321 to 11324 in df2c3c1

	[`${ONYXKEYS.COLLECTION.TRANSACTION}${transaction.transactionID}`]: {
	accountID: fromAccountID,
	managerID: toAccountID,
	...transaction,

so it navigates with undefined report id

What changes do you think we should make in order to solve the problem?

We need to pass the transaction thread report id to getSearchOnyxUpdate

App/src/libs/actions/IOU.ts

Line 1896 in df2c3c1

const searchUpdate = getSearchOnyxUpdate({

        transactionThreadReportID: transactionThreadReport?.reportID,

App/src/libs/actions/IOU.ts

Line 11323 in df2c3c1

managerID: toAccountID,

                                    transactionThreadReportID,

I also see other missing props we are not adding like policyID so we should address those too.
Moreover, we are only adding transaction to the snapshot so when we create the first expense for and expense report it doesn't appear in offline mode because we are not populating expense/iou report to the snapshot. So if needed, we can widen the scope of the issue and implement the update of the linked report data to the snapshot key.
We will do the same in other places needed where we use getSearchOnyxUpdate

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

If needed We can test whether the transaction item added to the snapshot has transaction thread report populated properly

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021928503528246009374

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ZhenjaHorbach (External)

[dangrous]

Can handle internal review when ready!

[ZhenjaHorbach]

This proposal looks good to me !

🎀 👀 🎀 C+ reviewed