[Due for payment 2025-06-16] [$250] Onboarding - Guest can open test drive modal and submit email which leads to not here page

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.54-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Mac 15.4 / Chrome
App Component: Other

Action Performed:

1. Go to staging.new.expensify.com
2. Log out if logged in.
3. Go to public room as guest - https://staging.new.expensify.com/r/7933543820671339
4. Open FAB.
5. Click Take a 2-minute test drive.
6. Enter email in the email field.
7. Click Start test drive.

Expected Result:

App should open login page because user is a guest and not signed in.

Actual Result:

Not here page opens after clicking Start test drive.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6845853_1748545880745.Screen_Recording_2025-05-29_at_4.01.31_PM.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021928469799077658391
• Upwork Job ID: 1928469799077658391
• Last Price Increase: 2025-05-30
• Automatic offers:
• Krishna2323 | Contributor | 107547570

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @rojiphil

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Krishna2323]

🚨 Edited by proposal-police: This proposal was edited at 2025-05-29 22:59:55 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Onboarding - Guest can open test drive modal and submit email which leads to not here page

What is the root cause of that problem?

• No logic is there to redirect user to login page is the user is anonymous.
  

  App/src/pages/home/sidebar/FloatingActionButtonAndPopover.tsx

  Lines 486 to 502 in 7338f19

  	{
  	icon: Expensicons.Binoculars,
  	iconStyles: styles.popoverIconCircle,
  	iconFill: theme.icon,
  	text: translate('testDrive.quickAction.takeATwoMinuteTestDrive'),
  	onSelected: () => {
  	InteractionManager.runAfterInteractions(() => {
  	if (introSelected?.choice === CONST.ONBOARDING_CHOICES.MANAGE_TEAM || introSelected?.choice === CONST.ONBOARDING_CHOICES.TEST_DRIVE_RECEIVER) {
  	completeTestDriveTask(isAnonymousUser());
  	Navigation.navigate(ROUTES.TEST_DRIVE_DEMO_ROOT);
  	} else {
  	Navigation.navigate(ROUTES.TEST_DRIVE_MODAL_ROOT.route);
  	}
  	});
  	},
  	},
  	]

What changes do you think we should make in order to solve the problem?

• Redirect to sign-in page if the user is anonymous.
• We can use interceptAnonymousUser instead of directly checking for isAnonymousUser() and redirecting.

    onSelected: () => {
        if (isAnonymousUser()) {
            signOutAndRedirectToSignIn();
            return;
        }
        InteractionManager.runAfterInteractions(() => {
            if (introSelected?.choice === CONST.ONBOARDING_CHOICES.MANAGE_TEAM || introSelected?.choice === CONST.ONBOARDING_CHOICES.TEST_DRIVE_RECEIVER) {
                completeTestDriveTask(isAnonymousUser());
                Navigation.navigate(ROUTES.TEST_DRIVE_DEMO_ROOT);
            } else {
                Navigation.navigate(ROUTES.TEST_DRIVE_MODAL_ROOT.route);
            }
        });
    },

///// OR

    onSelected: () => {
        InteractionManager.runAfterInteractions(() => {
            if (isAnonymousUser()) {
                signOutAndRedirectToSignIn();
            } else if (introSelected?.choice === CONST.ONBOARDING_CHOICES.MANAGE_TEAM || introSelected?.choice === CONST.ONBOARDING_CHOICES.TEST_DRIVE_RECEIVER) {
                completeTestDriveTask(isAnonymousUser());
                Navigation.navigate(ROUTES.TEST_DRIVE_DEMO_ROOT);
            } else {
                Navigation.navigate(ROUTES.TEST_DRIVE_MODAL_ROOT.route);
            }
        });
    },

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

• Do not render the test drive quick action when isAnonymousUser() is true, add the condition below.
  

  App/src/pages/home/sidebar/FloatingActionButtonAndPopover.tsx

  Line 484 in 7338f19

  ...(!hasSeenTour

• If we need to check for isAnonymousUser() for all FAB actions, we can add the check here and call redirect to sign-in.
  

  App/src/pages/home/sidebar/FloatingActionButtonAndPopover.tsx

  Lines 533 to 543 in 7338f19

  	menuItems={menuItems.map((item) => {
  	return {
  	...item,
  	onSelected: () => {
  	if (!item.onSelected) {
  	return;
  	}
  	navigateAfterInteraction(item.onSelected);
  	},
  	};
  	})}

Result

[truph01]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Onboarding - Guest can open test drive modal and submit email which leads to not here page

What is the root cause of that problem?

• In this block:
  

  App/src/pages/home/sidebar/FloatingActionButtonAndPopover.tsx

  Lines 491 to 500 in 7338f19

  	onSelected: () => {
  	InteractionManager.runAfterInteractions(() => {
  	if (introSelected?.choice === CONST.ONBOARDING_CHOICES.MANAGE_TEAM || introSelected?.choice === CONST.ONBOARDING_CHOICES.TEST_DRIVE_RECEIVER) {
  	completeTestDriveTask(isAnonymousUser());
  	Navigation.navigate(ROUTES.TEST_DRIVE_DEMO_ROOT);
  	} else {
  	Navigation.navigate(ROUTES.TEST_DRIVE_MODAL_ROOT.route);
  	}
  	});
  	},

  
  we do not check whether the current user is anonymous before proceeding. As a result, anonymous users are allowed to attempt actions that require authentication, leading them to be incorrectly routed to the test drive page instead of the sign-in modal.

What changes do you think we should make in order to solve the problem?

• All actions initiated via the FloatingActionButtonAndPopover component require the user to be signed in. Therefore, we should intercept anonymous users at the point they attempt to interact with this menu and redirect them to the sign-in modal.

• Specifically, we can update the toggleCreateMenu function to wrap it with interceptAnonymousUser:

App/src/pages/home/sidebar/FloatingActionButtonAndPopover.tsx

Line 266 in 7338f19

const toggleCreateMenu = () => {

Modified code:

const toggleCreateMenu = () => {
    interceptAnonymousUser(() => {
        if (isCreateMenuActive) {
            hideCreateMenu();
        } else {
            showCreateMenu();
        }
    });
};

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

• None

What alternative solutions did you explore? (Optional)

• None

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Guest can open test drive modal and submit email which leads to not here page

What is the root cause of that problem?

We allow anonymous to open test drive modal

App/src/pages/home/sidebar/FloatingActionButtonAndPopover.tsx

Lines 491 to 500 in 7338f19

	onSelected: () => {
	InteractionManager.runAfterInteractions(() => {
	if (introSelected?.choice === CONST.ONBOARDING_CHOICES.MANAGE_TEAM || introSelected?.choice === CONST.ONBOARDING_CHOICES.TEST_DRIVE_RECEIVER) {
	completeTestDriveTask(isAnonymousUser());
	Navigation.navigate(ROUTES.TEST_DRIVE_DEMO_ROOT);
	} else {
	Navigation.navigate(ROUTES.TEST_DRIVE_MODAL_ROOT.route);
	}
	});
	},

What changes do you think we should make in order to solve the problem?

Wrap this onSelected function with callFunctionIfActionIsAllowed so anonymous user will redirected to login page first before opening the test drive modal

App/src/pages/home/sidebar/FloatingActionButtonAndPopover.tsx

Lines 491 to 500 in 7338f19

	onSelected: () => {
	InteractionManager.runAfterInteractions(() => {
	if (introSelected?.choice === CONST.ONBOARDING_CHOICES.MANAGE_TEAM || introSelected?.choice === CONST.ONBOARDING_CHOICES.TEST_DRIVE_RECEIVER) {
	completeTestDriveTask(isAnonymousUser());
	Navigation.navigate(ROUTES.TEST_DRIVE_DEMO_ROOT);
	} else {
	Navigation.navigate(ROUTES.TEST_DRIVE_MODAL_ROOT.route);
	}
	});
	},

                      onSelected: callFunctionIfActionIsAllowed(() => {
                          InteractionManager.runAfterInteractions(() => {
                              if (introSelected?.choice === CONST.ONBOARDING_CHOICES.MANAGE_TEAM || introSelected?.choice === CONST.ONBOARDING_CHOICES.TEST_DRIVE_RECEIVER) {
                                  completeTestDriveTask(isAnonymousUser());
                                  Navigation.navigate(ROUTES.TEST_DRIVE_DEMO_ROOT);
                              } else {
                                  Navigation.navigate(ROUTES.TEST_DRIVE_MODAL_ROOT.route);
                              }
                          });
                      }),

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

None

[truph01]

@sakluger All actions initiated via the FloatingActionButtonAndPopover component require the user to be signed in. Therefore, should we intercept anonymous users at the point they attempt to interact with this button and redirect them to the sign-in modal?

[Krishna2323]

PROPOSAL UPDATED

• Added alternative 2

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021928469799077658391

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rojiphil (External)