[Due for payment 2025-06-12] [$125] RBR Hold Message Lacks Polished Tone

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.53-5
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @puneetlath
Slack conversation (hyperlinked to channel name): #Product

Action Performed:

1. Navigate to the expense report
2. Select an expense to put on hold by clicking More
3. Go to reports > Expense reports

Expected Result:

A clearer and more user-friendly message is shown like "This expense is on hold"

Actual Result:

A brief or curt "Hold" message is shown

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021928049646653081537
• Upwork Job ID: 1928049646653081537
• Last Price Increase: 2025-05-29
• Automatic offers:
• nkdengineer | Contributor | 107494745

Issue Owner

Current Issue Owner: @bfitzexpensify

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

🚨 Edited by proposal-police: This proposal was edited at 2025-05-29 05:12:58 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

A brief or curt "Hold" message is shown

What is the root cause of that problem?

We define this message in violations.hold

App/src/languages/en.ts

Line 5824 in 32cfed1

hold: 'Hold',

App/src/libs/Violations/ViolationsUtils.ts

Lines 403 to 404 in 32cfed1

	case 'hold':
	return translate('violations.hold');

What changes do you think we should make in order to solve the problem?

We should change this violation message something like This expense is on hold and also need to change es file

        hold: 'This expense is on hold',

App/src/languages/en.ts

Line 5824 in 32cfed1

hold: 'Hold',

Or we can create a new translation and use this in here

App/src/libs/Violations/ViolationsUtils.ts

Lines 403 to 404 in 32cfed1

	case 'hold':
	return translate('violations.hold');

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[nabi-ebrahimi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

RBR Hold Message Lacks Polished Tone

What is the root cause of that problem?

We translate the hold violation to only hold here

What changes do you think we should make in order to solve the problem?

We should add another text for this specific case like "This expense is on hold", and add it to languages

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N / A

What alternative solutions did you explore? (Optional)

[melvin-bot]

Triggered auto assignment to @ryanschaffer (Waiting for copy), see https://stackoverflow.com/c/expensify/questions/7025/ for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021928049646653081537