[Awaiting Checklist] [$250] bank-Manually add your bank account page is shown briefly before updating to plaid screen

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: V9..153-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: N/a
Email or phone of affected tester (no customers): slottwo1darls44@gmail.com
Issue reported by: Applause Internal Team
Device used: Redminote 10s android 13 phone
App Component: Other

Action Performed:

1. Launch app
2. Login with new gmail account
3. Create a workspace - more features - workflows
4. Tap connect Bank account
5. Enter magic code

Expected Result:

Manually add your bank account page must not be shown briefly before updating to plaid screen.

Actual Result:

Manually add your bank account page is shown briefly before updating to plaid screen.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021928097275156179426
• Upwork Job ID: 1928097275156179426
• Last Price Increase: 2025-06-05
• Automatic offers:
• daledah | Contributor | 107630533

Issue Owner

Current Issue Owner: @Pujan92

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[dominictb]

cc @narefyev91 to take a look

[dominictb]

Oops sorry I took a look again and Plaid screen is not exclusive to plaid import project. This should be treated as a normal bug.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Manually add your bank account page is shown briefly before updating to plaid screen.

What is the root cause of that problem?

After validating account in, we start the plaid flow:

App/src/pages/ReimbursementAccount/VerifiedBankAccountFlowEntryPoint.tsx

Lines 140 to 143 in 131b5fa

	} else if (optionPressed.current === CONST.BANK_ACCOUNT.SUBSTEP.PLAID) {
	setUSDBankAccountStep(CONST.BANK_ACCOUNT.STEP.BANK_ACCOUNT);
	openPlaidView();
	}

There's two actions:

1. setUSDBankAccountStep(CONST.BANK_ACCOUNT.STEP.BANK_ACCOUNT)

This action will make the screen renders USDVerifiedBankAccountFlow

App/src/pages/ReimbursementAccount/ReimbursementAccountPage.tsx

Lines 460 to 472 in 131b5fa

	if (USDBankAccountStep !== null) {
	return (
	<USDVerifiedBankAccountFlow
	USDBankAccountStep={currentStep}
	policyID={policyIDParam}
	onBackButtonPress={goBack}
	requestorStepRef={requestorStepRef}
	onfidoToken={onfidoToken}
	setUSDBankAccountStep={setUSDBankAccountStep}
	setShouldShowConnectedVerifiedBankAccount={setShouldShowConnectedVerifiedBankAccount}
	/>
	);
	}

2. openPlaidView()

This action is asynchronous, it will clear previous Plaid data before set bank account substep as Plaid

App/src/libs/actions/BankAccounts.ts

Lines 63 to 65 in 131b5fa

	function openPlaidView() {
	clearPlaid().then(() => setBankAccountSubStep(CONST.BANK_ACCOUNT.SETUP_TYPE.PLAID));
	}

App/src/libs/actions/ReimbursementAccount/index.ts

Lines 17 to 19 in 131b5fa

	function setBankAccountSubStep(subStep: BankAccountSubStep | null): Promise<void | void[]> {
	return Onyx.merge(ONYXKEYS.REIMBURSEMENT_ACCOUNT, {achData: {subStep}});
	}

And since we use that data to display manual/plaid view here:

App/src/pages/ReimbursementAccount/USD/BankInfo/BankInfo.tsx

Line 91 in 131b5fa

const bodyContent = setupType === CONST.BANK_ACCOUNT.SETUP_TYPE.PLAID ? plaidSubSteps : manualSubSteps;

For a short moment after action 1, USDVerifiedBankAccountFlow will be shown, with setupType is still being undefined because step 2 is not finished, so manualSubSteps will be shown briefly

What changes do you think we should make in order to solve the problem?

Not sure why it's implemented this way, we can see that in handleConnectPlaid we call setBankAccountSubStep immediately without awaiting any actions

App/src/pages/ReimbursementAccount/VerifiedBankAccountFlowEntryPoint.tsx

Lines 157 to 159 in 131b5fa

	setBankAccountSubStep(CONST.BANK_ACCOUNT.SETUP_TYPE.PLAID);
	setUSDBankAccountStep(CONST.BANK_ACCOUNT.STEP.BANK_ACCOUNT);
	openPlaidView();

So there's two solution:

1. We can ignore the asynchronous action of openPlaidView and call setBankAccountSubStep directly like handleConnectPlaid

App/src/pages/ReimbursementAccount/VerifiedBankAccountFlowEntryPoint.tsx

Lines 141 to 142 in 131b5fa

	setUSDBankAccountStep(CONST.BANK_ACCOUNT.STEP.BANK_ACCOUNT);
	openPlaidView();

        setBankAccountSubStep(CONST.BANK_ACCOUNT.SETUP_TYPE.PLAID);
        setUSDBankAccountStep(CONST.BANK_ACCOUNT.STEP.BANK_ACCOUNT);
        openPlaidView();

2. Or, add a callback param to openPlaidView, which we'll pass setUSDBankAccountStep so it can be called together with setBankAccountSubStep after clearing plaid data

App/src/libs/actions/BankAccounts.ts

Lines 63 to 65 in 131b5fa

	function openPlaidView() {
	clearPlaid().then(() => setBankAccountSubStep(CONST.BANK_ACCOUNT.SETUP_TYPE.PLAID));
	}

function openPlaidView(callback?: () => void) {
    clearPlaid().then(() => {
        callback?.();
        setBankAccountSubStep(CONST.BANK_ACCOUNT.SETUP_TYPE.PLAID);
    });
}

App/src/pages/ReimbursementAccount/VerifiedBankAccountFlowEntryPoint.tsx

Lines 141 to 142 in 131b5fa

	setUSDBankAccountStep(CONST.BANK_ACCOUNT.STEP.BANK_ACCOUNT);
	openPlaidView();

openPlaidView(() => setUSDBankAccountStep(CONST.BANK_ACCOUNT.STEP.BANK_ACCOUNT));

Make same changes to handleConnectPlaid for consistency.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None, race condition issue.

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[twisterdotcom]

Are we discussing how this screen flickers behind the Plaid modal? I agree, this is not great and seems @daledah has some good solutions already. Let's get a C+ on it too.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021928097275156179426

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)