[Due for payment 2025-07-01] [$250] After moving expenses to the same report, selection mode persists but checkboxes are missing

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.49-5
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+x34@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.4 / Chrome
App Component: Money Requests

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Submit two expenses to workspace chat.
4. Go to Reports.
5. Tap bookmark button.
6. Tap Expense Reports.
7. Tap on the expense report with two expenses.
8. Long press on any expense > Select.
9. Tap dropdown button.
10. Tap Move expenses.
11. Tap on the selected report.
12. Tap app back button.

Expected Result:

In Step 11, selection mode will exit.
In Step 12, app will return to Reports.

Actual Result:

In Step 11, selection mode persists, but checkboxes are missing on the expense rows.
In Step 12, app back button reopens the same expense report.

On web, in Step 11, after moving expenses to the same report, app returns to Inbox.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6839150_1747915569620.ScreenRecording_05-22-2025_19-59-18_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021925786519842829002
• Upwork Job ID: 1925786519842829002
• Last Price Increase: 2025-06-06
• Automatic offers:
• FitseTLT | Contributor | 107623220

Issue Owner

Current Issue Owner: @VictoriaExpensify

[melvin-bot]

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[FitseTLT]

🚨 Edited by proposal-police: This proposal was edited at 2025-05-22 12:59:29 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

After moving expenses to the same report, selection mode persists but checkboxes are missing

What is the root cause of that problem?

We don't reset the selectedTransaction list when moved to the current report

App/src/pages/iou/request/step/IOURequestEditReport.tsx

Lines 27 to 35 in 413eb10

	const selectReport = (item: ReportListItem) => {
	if (selectedTransactionsID.length === 0) {
	return;
	}
	if (item.value !== transactionReport?.reportID) {
	changeTransactionsReport(selectedTransactionsID, item.value);
	setSelectedTransactionsID([]);
	}
	Navigation.dismissModalWithReport({reportID: item.value});

Then the dismissModalWithReport will push a report screen on the stack with the same reportID so it will appear with the previous selectedTransactions but with selectionMode as false so the checkboxes will be missing.

What changes do you think we should make in order to solve the problem?

We should reset selectedTransaction no matter what the report it is moved to is the current one or not and we will need to only dismissModal when the current report is selected

   const selectReport = (item: ReportListItem) => {
        if (selectedTransactionsID.length === 0) {
            return;
        }
        if (item.value !== transactionReport?.reportID) {
            changeTransactionsReport(selectedTransactionsID, item.value);
        }
        setSelectedTransactionsID([]);
        turnOffMobileSelectionMode();
        if (item.value === transactionReport?.reportID) {
            Navigation.dismissModal(); // We can optionally also use goBack(backTo);
            return;
        }
        Navigation.dismissModalWithReport({reportID: item.value});
    };

We can add selectionMode?.isEnabled check before turnOffMobileSelectionMode to only turn off mobile selection for mobile.
This will achieve the Expected Result in the OP but if the expected behavior is different like if we don't want to turn off selection mode or reset selectedTransactions we can remove their corresponding code.

Additional note: When we refresh while on IOURequestEditReport page and selecting a report will not do anything because the selectedTransactions will be empty as they are provided by a context

App/src/pages/iou/request/step/IOURequestEditReport.tsx

Lines 27 to 30 in 413eb10

	const selectReport = (item: ReportListItem) => {
	if (selectedTransactionsID.length === 0) {
	return;
	}

so we can either dismissModal before early returning or start persisting the selectedTransactions in onyx so that they will not reset on refresh.
Also now we are navigating to the report screen when moving expenses from both search screen or report screen so if needed we can consider navigating to SEARCH_MONEY_REQUEST_REPORT when we are in search screen ( isSearchTopmostFullScreenRoute is true)

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N / A

What alternative solutions did you explore? (Optional)

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After moving expense to the same report, the selected transaction is not cleared.

What is the root cause of that problem?

When we select the same report, it won't clear the selected transaction.

App/src/pages/iou/request/step/IOURequestEditReport.tsx

Lines 31 to 35 in 409e68e

	if (item.value !== transactionReport?.reportID) {
	changeTransactionsReport(selectedTransactionsID, item.value);
	setSelectedTransactionsID([]);
	}
	Navigation.dismissModalWithReport({reportID: item.value});

It should simply close the edit report modal.

App/src/libs/Navigation/Navigation.ts

Lines 628 to 635 in 409e68e

	const topmostReportID = getTopmostReportId();
	const navigateToReportID = navigateToReportPayload.reportID ?? navigateToReportPayload.report?.reportID;
	const areReportsIDsDefined = !!topmostReportID && !!navigateToReportID;
	const isReportsSplitTopmostFullScreen = ref.getRootState().routes.findLast((route) => isFullScreenName(route.name))?.name === NAVIGATORS.REPORTS_SPLIT_NAVIGATOR;
	if (topmostReportID === navigateToReportID && areReportsIDsDefined && isReportsSplitTopmostFullScreen) {
	dismissModal();
	return;
	}

However, dismissModalWithReport will only works well if we are on a report page. In our case, the topmostReportID is undefined and isReportsSplitTopmostFullScreen is also false.

What changes do you think we should make in order to solve the problem?

To make it work with report screen on search too, we can create a new function, getTopmostSearchReportId.

const getTopmostSearchReportId = (state = navigationRef.getState()) => getTopmostSearchReportParams(state)?.reportID;

getTopmostSearchReportParams

function getTopmostSearchReportParams(state: State): SearchFullscreenNavigatorParamList[typeof SCREENS.SEARCH.MONEY_REQUEST_REPORT] | undefined {
    if (!state) {
        return;
    }

    const topmostSearchFullscreenNavigator = state.routes?.filter((route) => route.name === NAVIGATORS.SEARCH_FULLSCREEN_NAVIGATOR).at(-1);

    if (!topmostSearchFullscreenNavigator) {
        return;
    }

    const topmostReport = topmostSearchFullscreenNavigator.state?.routes.filter((route) => route.name === SCREENS.SEARCH.MONEY_REQUEST_REPORT).at(-1);

    if (!topmostReport) {
        return;
    }

    return topmostReport?.params as SearchFullscreenNavigatorParamList[typeof SCREENS.SEARCH.MONEY_REQUEST_REPORT];
}

Then, we will use getTopmostSearchReportId if we are on search page.

const topmostFullScreen = ref.getRootState().routes?.findLast((route) => isFullScreenName(route.name));
const isReportsSplitTopmostFullScreen = topmostFullScreen?.name === NAVIGATORS.REPORTS_SPLIT_NAVIGATOR;
const isSearchTopmostFullScreenRoute = topmostFullScreen?.name === NAVIGATORS.SEARCH_FULLSCREEN_NAVIGATOR;
const topmostReportID = isSearchTopmostFullScreenRoute ? getTopmostSearchReportId() : getTopmostReportId();

Next, we check if the search navigator topmost screen is the money request report.

const isSearchReportsTopmostFullScreen = isSearchTopmostFullScreenRoute && topmostFullScreen?.state?.routes.at(-1)?.name === SCREENS.SEARCH.MONEY_REQUEST_REPORT;

We dismiss the modal if either isReportsSplitTopmostFullScreen or isSearchReportsTopmostFullScreen is true.

(isReportsSplitTopmostFullScreen || isSearchReportsTopmostFullScreen)

(we can consider adding this logic to the page component instead to not alter the dismissModalWithReport behavior at all)

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

[VictoriaExpensify]

Yeah we should fix this

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021925786519842829002

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)