[Due for payment 2025-06-05] [$250] 400 Error message is shown in Merge account section and not translated to Spanish

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.1.45-6
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: -
Email or phone of affected tester (no customers): applausetester+en@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Macbook Pro 2023 / Sequoia 15.2
App Component: User Settings

Action Performed:

Precond: App is in Spanish

1. Go to staging.new.expensify.com
2. Go to Settings > Security.
3. Tap Merge account.
4. Enter email of an account that is already currently merged with this one
5. Mark "I understand this is not reversible" checkbox

Expected Result:

User expects an error message in Spanish that explains the situation

Actual Result:

User sees a 400 error message in English

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021923112566961739625
• Upwork Job ID: 1923112566961739625
• Last Price Increase: 2025-05-22
• Automatic offers:
• QichenZhu | Contributor | 107452948

Issue Owner

Current Issue Owner: @CortneyOfstad

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

User sees a 400 error message in English

What is the root cause of that problem?

We don't handle this error yet in getMergeErrorPage

App/src/pages/settings/Security/MergeAccounts/AccountValidatePage.tsx

Line 30 in 23537ae

const getMergeErrorPage = (err: string): ValueOf<typeof CONST.MERGE_ACCOUNT_RESULTS> | null => {

So the error will be displayed directly

App/src/pages/settings/Security/MergeAccounts/AccountValidatePage.tsx

Line 95 in 23537ae

const latestError = getLatestErrorMessage(mergeWithValidateCode);

App/src/pages/settings/Security/MergeAccounts/AccountValidatePage.tsx

Lines 128 to 129 in 23537ae

	const authenticationErrorKey = getAuthenticationErrorKey(latestError);
	const validateCodeError = !errorPage && authenticationErrorKey ? {authError: translate(authenticationErrorKey)} : undefined;

App/src/pages/settings/Security/MergeAccounts/AccountValidatePage.tsx

Line 172 in 23537ae

validateError={validateCodeError}

What changes do you think we should make in order to solve the problem?

We should create a new Error key for this here

App/src/CONST.ts

Line 5067 in 23537ae

MERGE_ACCOUNT_RESULTS: {

Something like:

ERR_MERGE_SELF: "err_merge_self"

Then handle it in getMergeErrorPage

App/src/pages/settings/Security/MergeAccounts/AccountValidatePage.tsx

Line 30 in 23537ae

const getMergeErrorPage = (err: string): ValueOf<typeof CONST.MERGE_ACCOUNT_RESULTS> | null => {

    if (err.includes('400 Cannot merge account into itself')) {
        return CONST.MERGE_ACCOUNT_RESULTS.ERR_MERGE_SELF;
    }

Then we need to create messages for this error in MergeResultPage, this will need design. Add after here

App/src/pages/settings/Security/MergeAccounts/MergeResultPage.tsx

Line 228 in 23537ae

},

            [CONST.MERGE_ACCOUNT_RESULTS.ERR_MERGE_SELF]: {
                heading: translate('mergeAccountsPage.mergeFailureGenericHeading'),
                description: `You cannot merge account that is already currently merged with this one`, // need design
                buttonText: translate('common.buttonConfirm'),
                onButtonPress: () => Navigation.goBack(ROUTES.SETTINGS_SECURITY),
                illustration: Illustrations.LockClosedOrange,
            },

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We can add unit test for getMergeErrorPage

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021923112566961739625

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[melvin-bot]

@allroundexperts Whoops! This issue is 2 days overdue. Let's get this updated quick!